From 8486e585f567ba1b0a908ef77648dbbfd6cff04d Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Tue, 11 Feb 2025 00:39:24 +0100 Subject: libservo: Add a delegate method for HTTP authentication (#35400) Add a delegate method for HTTP authentication and a related `AuthenticationRequest` object that carries with it the URL as well as whether or not the authentication request is for a proxy or not. This is now separate from the prompt API because requesting authentication doesn't necessarily involve prompting -- this is an implementation detail of the embedder. In addition, the internal bits are cleaned up slightly. Signed-off-by: Martin Robinson --- components/net/tests/main.rs | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'components/net/tests/main.rs') diff --git a/components/net/tests/main.rs b/components/net/tests/main.rs index 0bbbde9cf59..99bb918091a 100644 --- a/components/net/tests/main.rs +++ b/components/net/tests/main.rs @@ -28,7 +28,7 @@ use std::sync::{Arc, LazyLock, Mutex, RwLock, Weak}; use crossbeam_channel::{unbounded, Receiver, Sender}; use devtools_traits::DevtoolsControlMsg; -use embedder_traits::{EmbedderMsg, EmbedderProxy, EventLoopWaker}; +use embedder_traits::{AuthenticationResponse, EmbedderMsg, EmbedderProxy, EventLoopWaker}; use futures::future::ready; use http_body_util::combinators::BoxBody; use http_body_util::{BodyExt, Empty, Full}; @@ -125,21 +125,13 @@ fn create_embedder_proxy_and_receiver() -> (EmbedderProxy, Receiver fn receive_credential_prompt_msgs( embedder_receiver: Receiver, - username: Option, - password: Option, + response: Option, ) -> std::thread::JoinHandle<()> { std::thread::spawn(move || loop { let embedder_msg = embedder_receiver.recv().unwrap(); match embedder_msg { - embedder_traits::EmbedderMsg::Prompt(_, prompt_definition, _prompt_origin) => { - match prompt_definition { - embedder_traits::PromptDefinition::Credentials(ipc_sender) => { - ipc_sender - .send(embedder_traits::PromptCredentialsInput { username, password }) - .unwrap(); - }, - _ => unreachable!(), - } + embedder_traits::EmbedderMsg::RequestAuthentication(_, _, _, response_sender) => { + let _ = response_sender.send(response); break; }, embedder_traits::EmbedderMsg::WebResourceRequested(..) => {}, -- cgit v1.2.3