From 54244797688fbeec85baac6fcfc9b71d555bf72c Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Fri, 21 Mar 2025 15:55:00 +0100 Subject: metrics: Simplify `ProgressiveWebMetrics` (#35985) Simply how `ProgressiveWebMetrics` works: 1. Keep only a single struct instead of one in layout and one script that both implement the `ProgressiveWebMetrics` trait. Since layout and script are the same thread these can now just be a single `ProgressiveWebMetrics` struct stored in script. 2. Have the compositor be responsible for informing the Constellation (which informs the ScripThread) about paint metrics. This makes communication flow one way and removes one dependency between the compositor and script (of two). 3. All units tests are moved into the `metrics` crate itself since there is only one struct there now. Signed-off-by: Martin Robinson --- components/compositing/tracing.rs | 1 - 1 file changed, 1 deletion(-) (limited to 'components/compositing/tracing.rs') diff --git a/components/compositing/tracing.rs b/components/compositing/tracing.rs index 1ef0b41971c..907c931aebe 100644 --- a/components/compositing/tracing.rs +++ b/components/compositing/tracing.rs @@ -39,7 +39,6 @@ mod from_constellation { Self::SetThrottled(..) => target!("SetThrottled"), Self::NewWebRenderFrameReady(..) => target!("NewWebRenderFrameReady"), Self::PipelineExited(..) => target!("PipelineExited"), - Self::PendingPaintMetric(..) => target!("PendingPaintMetric"), Self::LoadComplete(..) => target!("LoadComplete"), Self::WebDriverMouseButtonEvent(..) => target!("WebDriverMouseButtonEvent"), Self::WebDriverMouseMoveEvent(..) => target!("WebDriverMouseMoveEvent"), -- cgit v1.2.3