Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | auto merge of #2129 : lpy/servo/issue2116, r=jdm | bors-servo | 2014-04-17 | 5 | -13/+92 |
|\ | | | | | | | | | | | see #2116 I add an `is_interval` field, so that when the `TimerData` is passed by `SetInterval`, we will not delete it from `active_timers`. Also I think maybe we can extract the code in `ClearTimeout` and `ClearInterval` into another method to avoid duplicate. | ||||
| * | Implement Window.set/clearInterval.(fixes #2116) | lpy | 2014-04-18 | 5 | -13/+92 |
| | | |||||
* | | auto merge of #2146 : metajack/servo/bye-bye-nss, r=jdm | bors-servo | 2014-04-17 | 2 | -0/+0 |
|\ \ | | | | | | | | | | | | | These were not being used and are responsible for a large amount of work and problems. | ||||
| * | | Remove NSS and NSPR from the build. | Jack Moffitt | 2014-04-17 | 2 | -0/+0 |
| | | | | | | | | | | | | | | | These were not being used and are responsible for a large amount of work and problems. | ||||
* | | | auto merge of #2145 : SimonSapin/servo/to_ascii_lower, r=metajack | bors-servo | 2014-04-17 | 1 | -51/+40 |
|\ \ \ | |/ / |/| | | | | | | | | | | | This reverts [some changes made during the 2014-03-04 Rust upgrade](https://github.com/mozilla/servo/commit/bbac8aa5c3d95e70151b824ca3443f0fb4d9b5a5#diff-d084c1d37003c83f26aa4dac0e8d9e6bL221). @larsberg, what was the reason for preferring the unsafe `.to_ascii_nocheck()`? r? @larsberg | ||||
| * | | Use to_ascii_lower() and eq_ignore_ascii_case() instead of unsafe code. | Simon Sapin | 2014-04-17 | 1 | -51/+40 |
| | | | |||||
* | | | Ensure that optional primitive arguments aren't treated as nullable. | Ms2ger | 2014-04-17 | 1 | -7/+9 |
|/ / | | | | | | | | | | | | | | | | | | | By forgetting the Some(), we caused type inference to convert to Option<T> for optional non-nullable primitive arguments, and to Option<Option<T>> for optional nullable primitive arguments (essentially the same thing). This change brings the primitive codegen in line with the DOMString codegen. Using distinct types for optionality and nullability would have prevented this issue. | ||||
* | | auto merge of #2135 : mbrubeck/servo/refcell-get, r=larsbergstrom | bors-servo | 2014-04-16 | 3 | -10/+7 |
|\ \ | | | | | | | | | | | | | | | | It's going away in the next Rust upgrade (mozilla/rust#13301). r? @larsbergstrom We'll need to do the same in rust-layers. | ||||
| * | | Stop using deprecated RefCell<T>::get | Matt Brubeck | 2014-04-16 | 3 | -10/+7 |
| | | | | | | | | | | | | It's going away in the next Rust upgrade. | ||||
* | | | Stop cloning FrameTrees | Matt Brubeck | 2014-04-16 | 1 | -25/+18 |
|/ / | | | | | | | | | This fixes an issue where a ChildFrameTree is inserted into a clone of its parent, rather than its "real" parent, as noted in #2124. | ||||
* | | auto merge of #2102 : jdm/servo/warnings, r=metajack | bors-servo | 2014-04-16 | 14 | -25/+27 |
|\ \ | |||||
| * | | Fix some private type in public signature warnings. | Josh Matthews | 2014-04-16 | 14 | -25/+27 |
| | | | |||||
* | | | auto merge of #2097 : SimonSapin/servo/pseudo-cleanup, r=pcwalton | bors-servo | 2014-04-16 | 3 | -33/+19 |
|\ \ \ | |||||
| * | | | fixup! Rename ElementType to PseudoElementType, to avoid confusion with ↵ | Simon Sapin | 2014-04-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | ElementTypeId. | ||||
| * | | | fixup! Merge new_with_pseudo_without_self() and new_with_pseudo() into ↵ | Simon Sapin | 2014-04-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | with_pseudo() | ||||
| * | | | Merge new_with_pseudo_without_self() and new_with_pseudo() into with_pseudo() | Simon Sapin | 2014-04-14 | 1 | -14/+7 |
| | | | | |||||
| * | | | Rename ElementType to PseudoElementType, to avoid confusion with ElementTypeId. | Simon Sapin | 2014-04-14 | 3 | -12/+12 |
| | | | | |||||
| * | | | Use #[deriving(Clone)] for ThreadSafeLayoutNode | Simon Sapin | 2014-04-14 | 1 | -9/+2 |
| | | | | |||||
* | | | | De-RefCell FrameTree::pipeline | Matt Brubeck | 2014-04-16 | 1 | -34/+31 |
| | | | | |||||
* | | | | Privatize some Constellation internals | Matt Brubeck | 2014-04-16 | 1 | -17/+17 |
| | | | | |||||
* | | | | auto merge of #2130 : mbrubeck/servo/frametree-copy-fix, r=larsbergstrom | bors-servo | 2014-04-16 | 1 | -38/+38 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | We are calling `get` when we should call `borrow` or `borrow_mut`. This is causing bugs with iframes because we append the child frame to a copy of the parent's `children` vector rather than the original. r? @larsbergstrom | ||||
| * | | | | Remove unintentional copies due to RefCell<T>::get | Matt Brubeck | 2014-04-16 | 1 | -38/+38 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are calling `get` when we should call `borrow` or `borrow_mut`. This is causing bugs with iframes because we append to a copy of the `children` vector rather than the original. | ||||
* | | | | | Remove unwrap_object. | Ms2ger | 2014-04-16 | 2 | -21/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no good reason to have both unwrap_object and unwrap_jsmanaged. Removing unwrap_object simplifies the codegen and makes further simplifications easier. | ||||
* | | | | | auto merge of #2112 : Ms2ger/servo/IDLInterface-JS, r=jdm | bors-servo | 2014-04-16 | 3 | -7/+55 |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | |||||
| * | | | | Implement FromJSValConvertible for JS<T>. | Ms2ger | 2014-04-15 | 3 | -7/+55 |
| | | | | | |||||
* | | | | | auto merge of #2119 : pcwalton/servo/rm-unused-code, r=pcwalton | bors-servo | 2014-04-15 | 1 | -72/+0 |
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | trivial | ||||
| * | | | | box_: Remove unused code that resurfaced with the Rust upgrade | Patrick Walton | 2014-04-15 | 1 | -72/+0 |
| |/ / / | |||||
* | | | | auto merge of #2054 : sankha93/servo/imageattr, r=jdm | bors-servo | 2014-04-15 | 3 | -52/+61 |
|\ \ \ \ | |||||
| * | | | | HTMLImageElement attribute getters and setters | Sankha Narayan Guria | 2014-04-08 | 3 | -52/+61 |
| | | | | | |||||
* | | | | | auto merge of #2114 : Ms2ger/servo/unused-obj-local-arg, r=jdm | bors-servo | 2014-04-15 | 1 | -6/+3 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | This removes the local variable and prefixes the argument with an underscore. Neither is used right now. | ||||
| * | | | | | Remove unused variable 'obj' from binding functions. | Ms2ger | 2014-04-15 | 1 | -6/+3 |
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | This removes the local variable and prefixes the argument with an underscore. Neither is used right now. | ||||
* / | | | | Remove the return value from DefineDOMInterface. | Ms2ger | 2014-04-15 | 1 | -3/+3 |
|/ / / / | | | | | | | | | | | | | | | | | This moves the assertion from its only caller into the function itself, to clarify that we don't intent to deal with any failure here. | ||||
* | | | | Move child_inserted into VirtualMethods. | Matt Brubeck | 2014-04-14 | 3 | -16/+34 |
| | | | | | | | | | | | | | | | | Follow-up from #1984. | ||||
* | | | | Move inline stylesheet parsing out of HTML parser. | Matt Brubeck | 2014-04-14 | 8 | -46/+83 |
| |/ / |/| | | | | | | | | | | | | | | | | | Instead, use shared code to parse stylesheet content when it is inserted, whether during parsing or dynamically by script. Based on work by sanools in #1350. | ||||
* | | | auto merge of #2098 : Manishearth/servo/ref-noteq, r=metajack | bors-servo | 2014-04-12 | 3 | -0/+17 |
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | See #2090 One reftest compares a green image to a white div. The other has green text being compared with normal text. If necessary, I can add some absolute positioning ones. | ||||
| * | | Add the second reftest (#2090) | Manish Goregaokar | 2014-04-12 | 1 | -0/+1 |
| | | | |||||
| * | | A couple of != reftests (#2090) | Manish Goregaokar | 2014-04-12 | 3 | -0/+16 |
| | | | |||||
* | | | auto merge of #2094 : Manishearth/servo/id-efficiency, r=Ms2ger | bors-servo | 2014-04-11 | 1 | -12/+14 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | This improves the code written for #1822 to use a single linear traversal. The current code uses a binary search with `CompareDocumentPosition()` for comparing element position, however this method internally calls `traverse_preorder()` (i.e. a linear traversal) so calling this on every pass is quite inefficient. | ||||
| * | | | Make register_named_element more efficient | Manish Goregaokar | 2014-04-11 | 1 | -12/+14 |
| |/ / | |||||
* | | | auto merge of #2087 : Ms2ger/servo/vtable2, r=jdm | bors-servo | 2014-04-11 | 9 | -140/+266 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | Fixes #1527. Does *not* include the code for #1528. (Originally by @jdm in #1688 and #1866.) | ||||
| * | | | Remove the IElement trait. | Ms2ger | 2014-04-10 | 1 | -29/+14 |
| | | | | |||||
| * | | | Add overridable tree binding/unbinding behaviour. | Josh Matthews | 2014-04-10 | 3 | -10/+39 |
| | | | | |||||
| * | | | Integrate Element's after_set/remove behaviour into the virtual method ↵ | Josh Matthews | 2014-04-10 | 1 | -50/+54 |
| | | | | | | | | | | | | | | | | hierarchy. | ||||
| * | | | Add support for trait-based virtual methods on Nodes, and use it for ↵ | Josh Matthews | 2014-04-10 | 9 | -65/+173 |
| | | | | | | | | | | | | | | | | before_remove_attr and after_set_attr. | ||||
| * | | | Rename before_remove_attr and after_set_attr to allow reusing those names in ↵ | Ms2ger | 2014-04-09 | 1 | -7/+7 |
| |/ / | | | | | | | | | | the next commit. | ||||
* | | | auto merge of #2071 : hyunjunekim/servo/try, r=larsbergstrom | bors-servo | 2014-04-11 | 5 | -0/+66 |
|\ \ \ | | | | | | | | | | | | | If <span> element has pseudo style, draw pseudo element. | ||||
| * | | | Add a reftest for the pseudo element | hyunjunekim | 2014-04-12 | 4 | -0/+63 |
| | | | | |||||
| * | | | inline pseudo element | hyunjunekim | 2014-04-09 | 1 | -0/+3 |
| | | | | |||||
* | | | | auto merge of #2096 : larsbergstrom/servo/fix_fontconfig, r=jdm | bors-servo | 2014-04-11 | 1 | -0/+0 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Please don't r+ until https://github.com/mozilla-servo/rust-fontconfig/pull/12 is merged. r? @SimonSapin @mbrubeck or whomever. | ||||
| * | | | | Update fontconfig submodule version to fix linker order bug | Lars Bergstrom | 2014-04-11 | 1 | -0/+0 |
| | | | | |