aboutsummaryrefslogtreecommitdiffstats
path: root/python
Commit message (Collapse)AuthorAgeFilesLines
...
* | Update scripts to reflect new WPT directory nameMartin Robinson2023-06-2616-35/+29
| |
* | Auto merge of #29917 - mrobinson:more-environment-cleanup, r=jdmbors-servo2023-06-241-24/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up environment variables in `command_base.py` - The `HOST_FILE` setting is completely unused by the code. - Remove some likely Python 2 compatibility code. - Remove things pertaining to Ubuntu 16.04 which is EOL. - Remove a workaround for MacOS which no longer applies. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they mostly remove dead build script code. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Clean up environment variables inn `command_base.py`Martin Robinson2023-06-221-24/+1
| | | | | | | | | | | | | | | | | | | | | - The `HOST_FILE` setting is completely unused by the code. - Remove some likely Python 2 compatibility code. - Remove things pertaining to Ubuntu 16.04 which is EOL. - Remove a workaround for MacOS which no longer applies.
* | | Update command_base.pySamson2023-06-241-1/+1
| | | | | | | | | Fixup for https://github.com/servo/servo/pull/29912#issuecomment-1605347271
* | | Auto merge of #29920 - sagudev:py-fixups, r=mrobinsonbors-servo2023-06-241-7/+1
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Standalone Flake8 config Instead of passing flake8 config via CLI flags, I extracted them in flake8 config, so IDE tools can also pick it up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it is so trivial <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Standalone Flake8 configsagudev2023-06-231-7/+1
| | |
* | | Auto merge of #29912 - mrobinson:try-gold-on-windows, r=jdmbors-servo2023-06-231-2/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't explicitly disable gold on Windows This seems to be working fine now on CI, so I think we can remove this workaround. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are just build changes. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Don't explicitly disable gold on WindowsMartin Robinson2023-06-221-2/+1
| | | | | | | | | | | | | | | | | | | | This seems to be working fine now on CI, so I think we can remove this workaround.
* | | | Collect build timings on GitHub CIMartin Robinson2023-06-232-21/+22
| |/ / |/| | | | | | | | This will help to investigate slow builds on GitHub.
* | | Rename metadata directoriesMartin Robinson2023-06-223-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | This renames: - `tests/wpt/metadata` → `tests/wpt/meta-legacy-layout` - `tests/wpt/metadata-layout-2020` → `tests/wpt/meta` - `tests/wpt/mozilla/meta` → `tests/wpt/mozilla/meta-legacy-layout` - `tests/wpt/mozilla/meta-layout-2020` → `tests/wpt/mozilla/meta`
* | | Auto merge of #29913 - mrobinson:mach-unicode-paths, r=atbrakhibors-servo2023-06-221-10/+0
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow building on paths with Unicode characters This now works since the upgrade to Python 3, so we can remove this code which prevents mach from running in these situations. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #10002. - [x] These changes do not require tests because they just change build scripts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Allow building on paths with Unicode charactersMartin Robinson2023-06-221-10/+0
| | | | | | | | | | | | | | | This now works since the upgrade to Python 3, so we can remove this code which prevents mach from running in these situations.
* | | Implement `./mach bootstrap` for MacOSMartin Robinson2023-06-221-0/+15
|/ /
* | Auto merge of #29903 - mrobinson:improve-windows-build-instructions, r=mregobors-servo2023-06-221-2/+2
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify the build instructions in README.md - Add a chocolatey configuration that installs all dependencies and split the instructions into a normal and manual installation section. In addition fix a warning print statement for the Windows build that would trigger a Python exception. - Simplify the build instructions in the README and move all manual setup details to: https://github.com/servo/servo/wiki/Building <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Simplify the build instructionsMartin Robinson2023-06-211-2/+2
| | | | | | | | | | | | | | | | | | - Add a chocolatey configuration that installs all dependencies and split the instructions into a normal and manual installation section. In addition fix a warning print statement for the Windows build that would trigger a Python exception. - Simplify the build instructions in the README and move all manual setup details to: https://github.com/servo/servo/wiki/Building
* | Auto merge of #29901 - mukilan:switch-nightly-to-2020-layout, r=mrobinsonbors-servo2023-06-211-3/+7
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | Default nightly builds to layout 2020 This PR switches the filenames used by nightly builds so that the default `servo-latest.{ext}` packages use the 2020 engine and the 'servo-latest-legacy-layout.{ext}` packages use the 2013 engine. Since the platform workflows are reused by the main, quick-check, PR and WPT import flows and since the 2013/2020 flags are also controlled by try branches, I've kept the changes isolated to `nightly.yml` and `package_commands.py` and have avoided changing the input parameters. If we want to deault all the workflows to 2020, I can decline this PR and raise a new one. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they modify packaging logic.
| * Default nightly builds to layout 2020Mukilan Thiyagarajan2023-06-211-3/+7
| | | | | | | | Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
* | Clean up rustdoc runMartin Robinson2023-06-202-17/+5
|/ | | | | | | | | 1. The options specified in `rustdoc-with-private` are essentially the default now so we can remove this script. 2. `./mach browse-doc` is redundant with `./mach doc --open` which uses the underlying cargo functionality to browse the documentation. Fixes #29888.
* Auto merge of #29882 - mukilan:fix-windows-nightly, r=mrobinsonbors-servo2023-06-161-20/+28
|\ | | | | | | | | | | | | | | | | | | | | | | | | Fix windows nightly build failure PR #29865 changed the target directory for windows to be different from the source folder. However, the 'upload-nightly' command assumes the packages are stored in the default cargo target directory (./target), so the nightly jobs for windows were failing to find the packages. This PR fixes the 'upload-nightly' command to account for non-default target directories specified via CARGO_TARGET_DIR. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they fix a bug in packaging logic.
| * Fix windows nightly build failure.Mukilan Thiyagarajan2023-06-161-20/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | PR #29865 changed the target directory for windows to be different from the source folder. However, the 'upload-nightly' command assumes the packages are stored in the default cargo target directory (./target), so the nightly jobs for windows were failing to find the packages. This PR fixes the 'upload-nightly' command to account for non-default target directories specified via CARGO_TARGET_DIR.
* | Convert tidy to a non-egg Python packageMartin Robinson2023-06-1553-264/+65
|/ | | | | | | | | | | It seems that servo-tidy is only used by webrender in my GitHub searches. WebRender could simply use `rustfmt` and the tidy on pypi hasn't been updated since 2018. Converting tidy to a normal Python package removes the maintenance burden of continually fixing the easy install configuration. Fixes #29094. Fixes #29334.
* Auto merge of #29862 - mukilan:default-to-layout-2020, r=jdmbors-servo2023-06-091-1/+1
|\ | | | | | | | | | | | | | | | | | | | | Use layout 2020 by default This PR switches `./mach build` to use layout 2020 by default. It doesn't switch the nightly builds served from download.servo.org to layout 2020. I can add that change to this PR if we are ready to make the switch in nightly builds as well. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29843 - [x] These changes do not require tests because modify mach build configuration.
| * Use layout 2020 by defaultMukilan Thiyagarajan2023-06-081-1/+1
| | | | | | | | Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
* | Auto merge of #29860 - mrobinson:clang-format-python, r=jdmbors-servo2023-06-092-32/+18
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Get clang-format from pip and upgrade to version 16 This allows relying on a specific version of clang-format and no longer use any version checks. In addition, we can use --dry-run -Werror in order to avoid having to run against every file individually. Fix #29847. Fix #29846. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29847 and fix #29846. - [x] These changes do not require tests because they update dev infrastructure. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Get clang-format from pip and upgrade to version 16Martin Robinson2023-06-082-32/+18
| |/ | | | | | | | | | | | | | | | | This allows relying on a specific version of clang-format and no longer use any version checks. In addition, we can use --dry-run -Werror in order to avoid having to run against every file individually. Fix #29847. Fix #29846.
* / Set `id_hash` as default wpt chunkersagudev2023-06-091-0/+3
|/
* Auto merge of #29791 - sagudev:webgpu-cts, r=jdmbors-servo2023-06-031-0/+51
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Vendoring machanism for webgpu cts & update - Add `update-webgpu` command to mach to vendor webgpu cts. - Update webgpu cts (https://github.com/gpuweb/cts/commit/480edec387e8cd5bf5934680050c59a3f7a01438) & expectations (even though most are failing due to out of date impl) - Ignore vendored path from tidy check --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27508 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they are tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Add webgpu cts vendoring mechanismsagudev2023-06-011-0/+51
| |
* | recognize artix as valid distribution65432023-06-011-0/+1
|/
* Auto merge of #29811 - mrobinson:remove-more-python-2, r=jdmbors-servo2023-05-294-37/+8
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove more Python 2 compatibility code - os.environ is always `str` in Python 3. - The only string type is `str` so we can stop using `six.str_types`. - `iteritems()` isn't necessary because dicts have the `items()` method. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Remove more Python 2 compatibility codeMartin Robinson2023-05-294-37/+8
| | | | | | | | | | | | - os.environ is always `str` in Python 3. - The only string type is `str` so we can stop using `six.str_types`. - `iteritems()` isn't necessary because dicts have the `items()` method.
* | Auto merge of #29807 - sagudev:pyfail, r=mrobinsonbors-servo2023-05-291-1/+1
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Propagate status on `build_like_command_arguments` As observed in #29805 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29806 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Propagate status on `build_like_command_arguments`sagudev2023-05-291-1/+1
| |
* | Do not pass features when running `./mach test-unit`Martin Robinson2023-05-291-4/+3
|/
* Only check the GStreamer installation when buildingMartin Robinson2023-05-272-4/+5
| | | | | | | | | Instead of always checking whether GStreamer is installed in mach's `build_env`, only do this when actually building. Also, use the instance variable to find features and look for the "media-gstreamer" feature instead of looking for !"media-dummy." Fixes #29797.
* Clean up cross-compilation and featuresMartin Robinson2023-05-256-173/+182
| | | | | | | | | | | | Integrate cross-compilation and media-stack handling into the `build_like_command_arguments` decorator. This removes a lot of repetition in the code and standardizes how targets are selected for all similar commands. Now cross compilation targets, feature flags, and helper variables are stored in the CommandBase instance. This also avoids having to continuously pass these arguments down to functions called by the commands.
* Auto merge of #29781 - mrobinson:bootstrap-gstreamer, r=mukilanbors-servo2023-05-2511-233/+400
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement `bootstrap-gstreamer` for all platforms This change makes it so that the Platform classes can now handle installing GStreamer dependencies and properly setting up the environment including when cross-compiling. For Windows and Linux, prepackaged GStreamer is now installed into `target/dependencies/gstreamer` when not installed system-wide. In addition this change: 1. The Environment path append helper is moved to `util.py` and a new `prepend` version is added. 2. `set_run_env` and `build_dev` functions are combined and include more code from callers so environment setup is more often in the same place. Now code that used to call `set_run_env` calls `build_dev` and then `os.environ.update(...)`. We can further refine this with the `is_build` argument later. 4. Python typing information is added in many places. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25335 - [x] These changes do not require tests because they are to the build scripts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Implement `bootstrap-gstreamer` for all platformsMartin Robinson2023-05-2511-233/+400
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change makes it so that the Platform classes can now handle installing GStreamer dependencies and properly setting up the environment including when cross-compiling. For Windows and Linux is now installed into `target/dependencies/gstreamer` when not installed system-wide. In addition: 1. Creating and moving existing environment path append helpers to `util.py`. 2. Combining the `set_run_env` and `build_dev` functions and moving some outside code into them so that it can be shared. Now code that used to call `set_run_env` calls `build_dev` and then `os.environ.update(...)`. 3. Adding Python typing information in many places. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* | Upload nightly builds for layout2020 variantMukilan Thiyagarajan2023-05-241-0/+7
|/ | | | | | | | We'd like to start offering servo nightly builds with layout 2020 engine so that users can test the new layout without building servo. These new builds will be offered in addition to the current 2013 builds until we switch over to 2020 as the default.
* Merge branch 'servo:master' into issue#29773Michael Grigoryan2023-05-231-0/+1
|\
| * Auto merge of #29745 - mrobinson:compositor-side-scroll-tree, r=mukilanbors-servo2023-05-231-0/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a compositor-side scroll tree This will allow the compositor to properly chain scrolling requests up when a node has reached the extent of the scroll area. In addition, it removes the use of the deprecated WebRender `scroll()` API. This fixes scrolling on servo.org. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes: - Fix #29402. - Fix #27996. - Fix #27624. - Fix #24028. - Fix #23918. - Fix #21165. - [x] There are tests for these changes
| | * Add a compositor-side scroll treeMartin Robinson2023-05-191-0/+1
| | | | | | | | | | | | | | | | | | This will allow the compositor to properly chain scrolling requests up when a node has reached the extent of the scroll area. This fixes scrolling on servo.org.
* | | Remove unused importmichaelgrigoryan252023-05-221-1/+0
| | |
* | | Apply some review fixesmichaelgrigoryan252023-05-221-0/+5
| | |
* | | Patched a bugmichaelgrigoryan252023-05-221-1/+1
| | |
* | | Removed MagicLeap occurrences from Python filesmichaelgrigoryan252023-05-225-216/+26
| | |
* | | Remove `magicleap` command from command_base.pymichaelgrigoryan252023-05-221-6/+0
|/ /
* | Auto merge of #29767 - mukilan:fix-slowness-in-macos-copy-dependencies, ↵bors-servo2023-05-221-3/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=mrobinson Fix slowness in macos copy_dependencies The `copy_dependencies` logic is invoking `change_non_system_libraries_path` with absolute paths to gstreamer *plugin dylibs*. `change_non_system_libraries_path` skips editing links in servo binary to relocatable dylibs, but the since the plugins have absolute paths, they are treated as 'non-relocable' and it will try to edit the *non-existent* link (since plugins are loaded dynamically) in servo bin . These unnecessary calls to change_link_name is the cause of the slowness identified in #29764 This PR fixes the issue by ensuring plugin dylibs are not passed to the first call to change_non_system_libraries_path that patches the links in the main servo binary. With this fix, the time taken by copy_dependencies is reduced to ~3 seconds on my system. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29764 <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they fix slowness in build step
| * | Count post-cargo build steps in elapsed timeMukilan Thiyagarajan2023-05-211-2/+1
| | |
| * | Print message when packaging macos dylibsMukilan Thiyagarajan2023-05-211-0/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-05-01 16:04:40 +0000