aboutsummaryrefslogtreecommitdiffstats
path: root/python/tidy/servo_tidy_tests
Commit message (Collapse)AuthorAgeFilesLines
* Make tidy check that opening and closing braces that begin a line do so with ↵coalman2017-04-182-0/+11
| | | | proper alignment.
* Allow using servo as dependency, by fixing Cargo.toml of servo-test-tidy.강동윤2017-03-271-0/+3
|
* added tidy check for -> ()lucantrop2017-03-132-1/+2
|
* Fix Cargo.toml in servo_tidy_testsUK9922017-02-271-1/+4
|
* Rewrite the ban-type lint in PythonJefry Lagrange2017-02-253-0/+48
| | | | | | Delete old rust ban lint and move tests to python tidy Fix ban lint regex and fix test
* Add 'use statements with extraneous spaces' tidy checkvwvww2017-02-232-0/+3
| | | | | | | | | | | | | | | | | | | | | Add 'use statements with extraneous spaces' tidy check I added simple check routine for 'use statements with extraneous spaces' and codes that breaks the check routine in rust_tidy.rs. * Added a code that using 'use statements with extraneous spaces' code in rust_tidy.rs * Added assertion code in test_tidy.py. * check_rust function in tidy.py now recognizes the simple case in the 'use statements with extraneous spaces'. * Ran tidy check on rust code and modified a code(tests/unit/style/parsing/inherited_text.rs) that is not passing on this new tidy check. TODO: this code has to be refactored to support more general cases. - [X] ./mach test-tidy does not report any errors - [X] These changes fix #14898 (github issue number if applicable).
* Tidy: Report invalid listed ignored directories and filesUK9922017-01-182-2/+8
|
* Moved tidy's BLOCKED_PACKAGES to the config fileMatthias Devlamynck2017-01-141-0/+2
|
* Rust tidy: disallow assignment = in the beginning of lineJure Podgoršek2017-01-062-0/+4
|
* Tidy: Check Cargo.lock for packages with same version and different sourcesUK9922016-12-262-7/+37
|
* Add a tidy check for problematic match cases in script_thread.rsJosh Matthews2016-12-162-0/+24
|
* Auto merge of #14051 - birryree:tidy-check-buildbot-steps, r=aneeshusabors-servo2016-12-084-0/+31
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding linting checks for buildbot_steps.yml This pull request adds some tidy checks around YAML files, and specifically `buildbot_steps.yml`. Tidy checks added: * YAML files are checked for well-formedness/parse-ability * Whether a YAML file has duplicate keys * Whether a `buildbot_steps.yml` file contains only mappings to list-of-strings. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #13838 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> …ing checking for correct mappings and duplicate YAML keys. Added unit tests to test_tidy.py. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14051) <!-- Reviewable:end -->
| * Add tidy linting checks for buildbot_steps.ymlWilliam Lee2016-12-084-0/+31
| | | | | | | | | | | | | | | | | | This commit adds tidy checks for buildbot_steps.yml, as well as unit tests. These checks include: * Checking buildbot_steps.yml can be parsed by a YAML loader * buildbot_steps.yml does not contain duplicate keys * buildbot_steps.yml keys map to a list of strings
* | Add tests for the new LintRunnerRavi Shankar2016-11-117-0/+46
| |
* | Move file list iterator to a new moduleRavi Shankar2016-11-101-4/+3
|/
* Check for JSON key non-duplication and orderYuki Izumi2016-11-072-0/+13
|
* Auto merge of #13986 - iamrohit7:tidy-feature-attrs, r=Wafflespeanutbors-servo2016-11-012-0/+22
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make test-tidy check for alphabetical ordering of #![feature(...)] statements <!-- Please describe your changes on the following line: --> <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #13954 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13986) <!-- Reviewable:end -->
| * Tests alphabetical ordering of #![feature(...)]Rohit Burra2016-11-012-0/+22
| |
* | test-tidy: Check for space between function name and `(`Daan Sprenkels2016-10-312-1/+4
|/ | | | | | | | Disallow an extraneous space in a function call between the function name and the opening parenthesis in Rust code, while ignoring macro declarations. This commit fixes #13980.
* Auto merge of #13447 - gterzian:check_webidls_folder_files, r=Wafflespeanutbors-servo2016-10-026-0/+12
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Have tidy ensure that the there are no extra files in the webidls folder #13427 <!-- Please describe your changes on the following line: --> Have tidy ensure that the there are no extra files in the webidls folder #13427 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13427 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13447) <!-- Reviewable:end -->
| * tidy: checking directories for unexpected file extensionsGregory2016-10-026-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | update config, check_dir func to use config pass only_changed_files and exclude_dirs as args simplify config better conditional remove unused default, amend error message undo doc change
* | using word license in test name for consistencyMatt Schmoyer2016-10-011-1/+1
|/
* Issue #13350 Report tidy error for space after (Hugo Thiessard2016-09-232-0/+11
|
* Fix ordering `use` statements with bracesUK9922016-09-091-0/+1
|
* Tidy: Handle empty filesUK9922016-08-292-0/+5
|
* Check for license only in Cargo.tomlUK9922016-08-252-1/+1
|
* Some cleanups in tidyRavi Shankar2016-08-231-3/+3
|
* Check for errors in tidy config fileUK9922016-08-202-0/+20
|
* Check for blank line after shebang and grab actual comment block instead of ↵UK9922016-08-122-0/+9
| | | | hard-coded one
* Improve tidy's license validation logicedunham2016-08-122-0/+9
| | | | | | | | | | | fixes https://github.com/servo/servo/issues/10716 I took the lazy way out and hardcoded the size of block we examine for licenses. fixes https://github.com/servo/servo/issues/10719 Includes tests for new functionality.
* Add lint for `[` instead of `[[` in shells scriptsAneesh Agrawal2016-08-052-0/+6
|
* Add lint to ensure substitutions use the full formAneesh Agrawal2016-08-052-0/+2
| | | | | Check that any variable substitutions use the full ${VAR} form, not just $VAR (but don't check for quoting yet).
* Add lint for backticks in shell scriptsAneesh Agrawal2016-08-052-0/+3
| | | | | | The "$(some_command arg1 arg2)" form is preferred to the `some_command arg1 arg2` form because it nests unambiguously. Add a lint for this to tidy.
* Auto merge of #12295 - jimberlage:12158/shell-linting, r=aneeshusabors-servo2016-08-042-0/+13
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add linting for shell scripts <!-- Please describe your changes on the following line: --> This changes tidy to check shell scripts for the proper shebang and options. It does not check that variables are formatted correctly. It also adds a check for the MPL 2.0 license in shell scripts. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12158 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12295) <!-- Reviewable:end -->
| * Add linting for shell scriptsJim Berlage2016-07-222-0/+13
| | | | | | | | | | | | This changes tidy to check shell scripts for the proper shebang and options. It does not check that variables are formatted correctly. It also adds a check for the MPL 2.0 license in shell scripts.
* | Auto merge of #12567 - servo:tidy-self-test-result, r=jdmbors-servo2016-07-241-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | Return failure if the tidy self-tests fail. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12567) <!-- Reviewable:end -->
| * | Return failure if the tidy self-tests fail.Ms2ger2016-07-231-1/+1
| |/
* / Issue #12564: Fix "./mach test-tidy --self-test".Simon Martin2016-07-231-3/+4
|/
* [tidy] check for duplicate keys in .json filesOwen Coutts2016-07-082-0/+12
|
* Auto merge of #12317 - tallowen:add-tidy-test, r=jdmbors-servo2016-07-072-0/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [tidy] Test json parsing functionality We didn't have a test for json parsing so lets start with that --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12317) <!-- Reviewable:end -->
| * [tidy] Add test for existing json functionalityOwen Coutts2016-07-072-0/+9
| |
* | Added a subdirectory with a file to test whether tidy command ignores files ↵Nikhil Shagrithaya2016-07-071-0/+0
|/ | | | in subdirectories
* Add style check, test, and code fixes for an else brace check.Travis Dean2016-07-042-0/+7
|
* Tidy test for ignoring attributesRavi Shankar2016-06-161-0/+1
|
* Removed unused function and minor cleanupRavi Shankar2016-06-161-1/+1
|
* Auto merge of #11621 - h4xr:mach_fix, r=Wafflespeanutbors-servo2016-06-142-0/+10
|\ | | | | | | | | | | | | | | | | | | | | | | | | Make mach test-tidy consider ignored dirs Made changes so that mach test-tidy considers the ignored directories Fixes #11386 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11621) <!-- Reviewable:end -->
| * Make mach consider ignored dirsSaurabh Badhwar2016-06-152-0/+10
| | | | | | | | Address indentation changes
* | Auto merge of #11190 - mrmiywj:Root-tidy-checker, r=jdmbors-servo2016-06-052-1/+2
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add &Root<T> checker Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11137 (github issue number if applicable). Either: - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11190) <!-- Reviewable:end -->
| * add &Root<T> checkermrmiywj2016-06-052-1/+2
| | | | | | | | | | | | update rust_tidy tests update rust_tidy.rs and test_tidy.py
* | Warn about empty lines following an open brace.Josh Matthews2016-05-271-0/+1
| |