aboutsummaryrefslogtreecommitdiffstats
path: root/components/style
Commit message (Collapse)AuthorAgeFilesLines
* Stop transitioning properties with a discrete animation type (#30565)Oriol Brufau2023-10-202-0/+16
| | | | | | | | | They are not transitionable: https://drafts.csswg.org/css-transitions-1/#transitionable There are some new failures in background-image-interpolation.html, but I think the test is wrong, because it expects background-image to be transitionable, even though the spec defines it with a discrete animation type.
* Temporarily convert more cfg(debug_assertions) crashes to warnings (#30590)Delan Azabani2023-10-201-0/+32
|
* Anonymous boxes that wrap inlines should not inherit overflow (#30579)Martin Robinson2023-10-191-51/+60
| | | | | | | | | | | | | | In legacy layout, anonymous text wrappers were inheriting the `overflow` and `text-overflow` properties. This results in the creation of extra clipping for these anonymous wrappers which could clip away floats. We will likely implement `text-overflow` differently in non-legacy layout. This change marks all legacy layout pseudo elements as "legacy" and also adds a new pseudo element for non-legacy layout that does not inherit `overflow`. Fixes #30562. Co-authored-by: Oriol Brufau <obrufau@igalia.com>
* Temporarily convert existing cfg(debug_assertions) crashes to warnings (#30578)Delan Azabani2023-10-181-0/+16
|
* Implement support for the `drop-shadow` filter (#30439)Ennui Langeweile2023-10-044-13/+5
| | | | | | | | | | | | | | | | | | * Implement support for `drop-shadow` * Clean up remnant from early attempts * Fix misleading comments on GenericSimpleShadow If Servo-specific `style` changes will need to be upstreamed anyway, I might as well fix a thing that had thrown me off! * Revert "Fix misleading comments on GenericSimpleShadow" This reverts commit cdc810b826ac082041adc212c24649ee3b86ca0a. * Clean up an import * Update test expectations * Fix missing expectation on Layout 2013
* Further changes required by ServoOriol Brufau2023-10-021-0/+14
|
* style: Implement CSS @supports font-format(...) and font-tech(...) functionsJonathan Kew2023-10-022-16/+55
| | | | | | | | These are gated by the same layout.css.font-tech.enabled pref as the closely-related `tech()` function for the @font-face src descriptor; once the spec questions are settled, we should enable them all together. Differential Revision: https://phabricator.services.mozilla.com/D155359
* Further changes required by ServoOriol Brufau2023-10-021-1/+8
|
* style: Put the @font-face src tech() function behind a pref, enabled only on ↵Jonathan Kew2023-10-021-1/+1
| | | | | | | | | | | | Nightly for now There are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this. - In https://github.com/w3c/IFT/pull/113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?) - In https://github.com/w3c/csswg-drafts/issues/7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release. Differential Revision: https://phabricator.services.mozilla.com/D155458
* style: When serializing background shorthand skip initial values and order ↵Connor Pearson2023-10-021-17/+53
| | | | | | values according to grammar Differential Revision: https://phabricator.services.mozilla.com/D155077
* Further changes required by ServoOriol Brufau2023-10-021-9/+8
|
* style: Add basic support for nan / infinity in calc()Emilio Cobos Álvarez2023-10-021-11/+17
| | | | | | | | | | | | | | | | | | | Fix some tests to: * Not assume `double` precision. * Account for recent working group resolution with regards to NaN: https://github.com/w3c/csswg-drafts/issues/7067#issuecomment-1111211295 Not sure I caught all, but normalizing to 0 was already our existing behavior. This feature needs more work before it can be enabled more generally, so make it nightly-only, for now. Also, it's unclear per spec what the serialization for infinity*1s or so should be. Right now we serialize to <very-big-number>s, which seems reasonable, but some tests (but not others!) expect different behavior. I left those untouched for now. Differential Revision: https://phabricator.services.mozilla.com/D154883
* style: Implement atan2(), and enable calc() trigonometric functions by ↵Emilio Cobos Álvarez2023-10-023-117/+180
| | | | | | | | | | | default on nightly We now have test coverage, so let's do this. The remaining failures are just about infinity/nan, which is a completely different feature. Differential Revision: https://phabricator.services.mozilla.com/D154831
* Further changes required by ServoOriol Brufau2023-10-021-0/+1
|
* style: Add support for the @font-face src descriptor's tech() functionJonathan Kew2023-10-021-4/+124
| | | | | | WPT tests to be added in a following patch. Differential Revision: https://phabricator.services.mozilla.com/D154399
* style: Use the style-system format hint directly in gfx, instead of mapping ↵Jonathan Kew2023-10-021-0/+5
| | | | | | | | | | | to a separate internal enum Now that the style system has keywords for this, we don't need to define them in gfx but can just use the enum directly. (No functional change, just code simplification.) Depends on D154237 Differential Revision: https://phabricator.services.mozilla.com/D154238
* Further changes required by ServoOriol Brufau2023-10-021-2/+16
|
* style: Accept keywords in addition to strings in the @font-face format() ↵Jonathan Kew2023-10-021-4/+33
| | | | | | | | | | hint function The CSS Fonts 4 spec requires this, and Safari (at least) has long supported it. Depends on D154277 Differential Revision: https://phabricator.services.mozilla.com/D154237
* style: Do not allow a list of strings in the @font-face src descriptor's ↵Jonathan Kew2023-10-021-19/+10
| | | | | | | | | | | | format() function, only a single format string This aligns with CSS Fonts 4 (rather than Fonts 3) and with behavior in other browsers; I don't expect any significant breakage, given that specifying multiple format strings was never supported in other engines AFAIK, and never served any useful purpose. Depends on D154234 Differential Revision: https://phabricator.services.mozilla.com/D154235
* style: Don't use -moz-bool-pref for flexbox -moz-box emulationEmilio Cobos Álvarez2023-10-021-1/+2
| | | | | | | Use a bool pref media query which allows dynamic changes to get reflected instantly. Differential Revision: https://phabricator.services.mozilla.com/D154449
* style: Add a chrome-only -moz-box-layout: legacy | flex, and use that to ↵Emilio Cobos Álvarez2023-10-021-0/+10
| | | | | | implement flexbox emulation Differential Revision: https://phabricator.services.mozilla.com/D154153
* style: Remove -moz-* display values enabled-in-content prefsEmilio Cobos Álvarez2023-10-021-12/+3
| | | | | | | We have unshipped these since forever, no point in keeping the pref around. Move the relevant tests to chrome ref/mochitests. Differential Revision: https://phabricator.services.mozilla.com/D154152
* style: Remove aspect-ratio preferenceBoris Chiou2023-10-021-1/+0
| | | | | | | We shipped this in Firefox 89, one year ago. It should be okay to drop this preference now. Differential Revision: https://phabricator.services.mozilla.com/D153680
* style: Make color-scheme affect Windows' non-native menusEmilio Cobos Álvarez2023-10-022-12/+5
| | | | | | | | | | | | This matches what Linux and macOS do, and that allows the fix for bug 1782623 to work on Windows for unstyled selects. This also simplifies the CSS (though it adds a new system color which is a bit more annoying). I filed https://github.com/w3c/csswg-drafts/issues/7561 to propose adding a more generic way to do this in the future (not just for Firefox). Differential Revision: https://phabricator.services.mozilla.com/D153549
* style: Properly fail to serialize grid shorthand when not roundtrippingEmilio Cobos Álvarez2023-10-021-29/+36
| | | | | | | Other browsers also don't roundtrip properly, but they fail less severely. Differential Revision: https://phabricator.services.mozilla.com/D152794
* style: Remove nsTimingFunction and ComputedTimingFunctionEmilio Cobos Álvarez2023-10-021-8/+4
| | | | | | | They're simple wrappers of StyleComputedTimingFunction so we can remove them. Differential Revision: https://phabricator.services.mozilla.com/D152700
* style: `linear(...)` easing: Implement right-continuous behaviour on ↵David Shin2023-10-021-15/+18
| | | | | | discontinuities Differential Revision: https://phabricator.services.mozilla.com/D152078
* style: Ensure we cancel transitions without the need of an extra flushEmilio Cobos Álvarez2023-10-022-1/+7
| | | | | | | | | | | | | | | | | When something switches to display: none, right now we rely on StopAnimationsForElementsWithoutFrames(), which posts a restyle and the previous ProcessPendingRestyles call was papering over it. For other elements in the display none subtree it doesn't matter, because we don't keep their styles around, but for the display: none element themselves we do need to update transitions on time. We could, possibly more generally, remove StopAnimationsForElementsWithoutFrames() altogether and cancel animations when we clear style data, perhaps... But that's probably worth a follow-up. Differential Revision: https://phabricator.services.mozilla.com/D151600
* style: Propagate flags from original property to aliasesEmilio Cobos Álvarez2023-10-021-0/+1
| | | | | | | | | | | | Even we don't have internal aliases right now (and that seems a bit silly) we do have pref-gated aliases. An alias ID passed to IsEnabled with the wrong EnabledState would misbehave, assert, and crash. Though we don't have such callers in the tree because InspectorUtils passes only arguments that make us not look at the flags, it seems more reliable this way. Differential Revision: https://phabricator.services.mozilla.com/D151594
* Further changes required by ServoOriol Brufau2023-10-021-1/+2
|
* style: Support animation-composition in keyframe at rulesBoris Chiou2023-10-022-34/+85
| | | | | | | | | | | | | | So we can specify the keyframe-specific composite operation. However, these is a spec issue about the default composite for CSS Animations: https://github.com/w3c/csswg-drafts/issues/7476. I choose to use auto as the default composite for missing keyframes to match the definition in web-animations-1 because I think this makes more sense: > If the keyframe-specific composite operation for a keyframe is not set, the > composite operation specified for the keyframe effect as a whole is used for > values specified in that keyframe. Differential Revision: https://phabricator.services.mozilla.com/D150808
* style: Implement CSS animation-composition longhand in style systemBoris Chiou2023-10-022-1/+19
| | | | | | | | | | | | This patch introduces animation-composition longhand but we don't accept it in @keyframe rule for now. I will support this for @keyframe in the patch series. Besides, the shorthand of animation doesn't include animation-composition. The spec issue is: https://github.com/w3c/csswg-drafts/issues/6946. We could fix the shorthand once this spec issue gets updated. Differential Revision: https://phabricator.services.mozilla.com/D150299
* style: Clean up a bit traversal cullingEmilio Cobos Álvarez2023-10-021-26/+4
| | | | Differential Revision: https://phabricator.services.mozilla.com/D151544
* style: make contain-intrinsic-size *animatable*Ziran Sun2023-10-022-2/+3
| | | | Differential Revision: https://phabricator.services.mozilla.com/D151231
* style: C++ `ComputedTimingFunction` uses Rust's timing function calculationDavid Shin2023-10-025-85/+134
| | | | | | | | This was made economical by having Rust's computed `easing::TimingFunction` use a fully resolved function for `linear(...)` easing, as per draft resolution from https://github.com/w3c/csswg-drafts/issues/7415 Differential Revision: https://phabricator.services.mozilla.com/D151295
* style: Port bezier edge cases handling from C++ to RustDavid Shin2023-10-022-13/+68
| | | | Differential Revision: https://phabricator.services.mozilla.com/D150569
* style: Update rust's step function basd on C++ `ComputedTimingFunction`David Shin2023-10-023-19/+50
| | | | Differential Revision: https://phabricator.services.mozilla.com/D150566
* style: Move Rust animation to `ComputedTimingFunction`David Shin2023-10-022-69/+75
| | | | Differential Revision: https://phabricator.services.mozilla.com/D150565
* Further changes required by ServoOriol Brufau2023-10-021-1/+1
|
* style: Add color-mix to DevTools autocompleteEmilio Cobos Álvarez2023-10-021-0/+3
| | | | Differential Revision: https://phabricator.services.mozilla.com/D151180
* style: Minor indentation fix. DONTBUILDEmilio Cobos Álvarez2023-10-021-1/+1
| | | | MANUAL PUSH: White-space only change
* style: Add support for parsing the `contain-intrinsic-size` property from ↵Ziran Sun2023-10-027-3/+101
| | | | | | the CSS-sizing specification Differential Revision: https://phabricator.services.mozilla.com/D151001
* style: Make fullscreen modalEmilio Cobos Álvarez2023-10-021-1/+1
| | | | | | As per https://github.com/w3c/csswg-drafts/issues/7311. Differential Revision: https://phabricator.services.mozilla.com/D150335
* style: `linear(...)` easing: Simplify piecewise linear implementation given ↵David Shin2023-10-022-8/+4
| | | | | | parsing simplification Differential Revision: https://phabricator.services.mozilla.com/D150163
* style: `linear(...)` easing: Parsing should split a linear stop value into ↵David Shin2023-10-023-31/+37
| | | | | | | | two for entries with both `linear-stop-length` set This brings the behaviour inline with `linear-gradient(...)` Differential Revision: https://phabricator.services.mozilla.com/D149926
* style: `linear(...)` Easing: First linear entry should Get 0.0 assigned for ↵David Shin2023-10-021-11/+5
| | | | | | | | | | input if not specified Previously, had the smallest input value over all entries was assigned. However, that does not match the behaviour of `linear-gradient(...)`, which this easing function is modeled after. Differential Revision: https://phabricator.services.mozilla.com/D149916
* style: Improve LookAndFeel color cachingEmilio Cobos Álvarez2023-10-021-52/+53
| | | | | | | | | | | | | | | | | | To be honest, I'm a bit baffled that bug 1773795 caused a performance regression, but I think it's because the standins codepath is not really cached, so system colors that are "spoofed" always go through the massive switch, which could potentially be expensive. To fix, this, rejigger a bit the caches so that we key on both color-scheme and use-standins. Also, while at it, make the set of colors we spoof a single bitflag check, rather than relying on the compiler to do something potentially smart with it. I had to shuffle the order of colors around so that the expression to initialize the bitfield is constexpr (doesn't go over 1 << 64), but other than that this patch should be relatively straight-forward. Differential Revision: https://phabricator.services.mozilla.com/D150100
* Further changes required by ServoOriol Brufau2023-10-021-2/+0
|
* style: Use Rust's `ComputedTimingFunction` for IPDLDavid Shin2023-10-022-0/+11
| | | | Differential Revision: https://phabricator.services.mozilla.com/D149663
* style: Use style interpolation code for gradientsEmilio Cobos Álvarez2023-10-023-3/+5
| | | | | | | | This ensures they're clamped on Animated -> sRGB conversion, and in the future we'll have to implement different color spaces so we'll need to use it anyways. Differential Revision: https://phabricator.services.mozilla.com/D149792