| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
Also adjusted WPT tests to always expect deg like similar past changes.
WPT tests: https://github.com/web-platform-tests/wpt/blob/master/css/css-values/calc-infinity-nan-computed.html#L57-L71
Differential Revision: https://phabricator.services.mozilla.com/D172401
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D172339
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D172338
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D172341
|
|
|
|
|
|
| |
Redefine/Rename the fields in CoordPair to align the data members of gfx::Point.
Differential Revision: https://phabricator.services.mozilla.com/D5903
|
|
|
|
|
|
|
|
|
|
| |
Starts to add part of the basic functionality for popover. Including
[1] :open & :closed CSS pseudo class
[2] showPopover(), hidePopover() and togglePopover() interfaces. Much of the
functionality is still to-do.
[3] PopoverData interface
Differential Revision: https://phabricator.services.mozilla.com/D171719
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Times like NaN and infinity are now parsed and serialized correctly.
Rewrote time to use `calc_clamping_mode` instead of `was_calc` to
stop some parse-time clamping which broke these values.
Adjusted WPT test expectations, 19 newly pass :tada:
Also added a new WPT test to cover a missing edge case:
`calc(1<unit> * NaN)` -> `calc(NaN * 1<canonical_unit>)`
The very similar angle tests do this already for angle's units.
Differential Revision: https://phabricator.services.mozilla.com/D171911
|
| |
|
|
|
|
|
|
| |
And so we can lookup the timeline from TimelineCollection.
Differential Revision: https://phabricator.services.mozilla.com/D169273
|
| |
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D171640
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Computed color values will not be in the correct format, closer to the
one specified by the author. This also means that colors accross the
code are stored now as AbsoluteColor or StyleAbsoluteColor. This allows
color space/gamut information to be available for use.
Some animation related test failures had to be changed, because colors
now has greater precision. Animated a color now causes a lot more
animation updates, which was not initially expected. See the bug for
discussion.
Differential Revision: https://phabricator.services.mozilla.com/D171021
|
|
|
|
|
|
|
|
| |
I will need to do most of the work anyways during the style updates,
so by enabling this it will be easier to detect mistakes.
Also, canvas colors are now parsed as <color>, precisely to support
these new features. This is according to the HTML spec:
https://html.spec.whatwg.org/multipage/infrastructure.html#parsed-as-a-css-color-value
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
`NaN`, `infinity`, and `-infinity` angles should be specially serialized.
Also fixed a few relevant WPT tests which did not follow spec.
(see https://github.com/web-platform-tests/wpt/pull/38825)
Adjusted WPT test expectations, 40 newly pass :tada:
Differential Revision: https://phabricator.services.mozilla.com/D171658
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per the spec update, the new syntax is:
`ray() = ray( <angle> && <ray-size>? && contain? )`
And for `<ray-size>`:
"If no <ray-size> is specified it defaults to closest-side."
So `<ray-size>` is optional and we omit it if it's default value, for
serialization.
By the way, offset=* properties are supported only in Gecko, so we don't
need a servo function to check the preference.
Differential Revision: https://phabricator.services.mozilla.com/D171625
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make display: -moz-box's visibility: collapse handling switchable by its
own CSS property.
Longer term maybe we should switch the front-end away from visibility:
collapse altogether (there are some alternatives), but for now this will
allow to move the front-end to switch to modern `display: flex` while
keeping `visibility: collapse` work as in -moz-box.
Differential Revision: https://phabricator.services.mozilla.com/D171472
|
| |
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D170842
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, we make it animatable but don't apply it to the motion transform and
don't run it on the compositor for now (so it works for getComputedStyle but
doesn't have rendering result).
Per spec: https://w3c.github.io/csswg-drafts/css-values/#calc-serialize,
we tweak the WPT to let calc() serialize the percentage first, and maintain
zero-valued terms, i.e. 0%. (We are doing the same thing as
offset-anchor, so it should be fine with other browsers.)
Besides, I tweak the serialization of shorthand a little bit so we match
the implementation of WebKit.
Differential Revision: https://phabricator.services.mozilla.com/D170972
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove some legacy appearance aliases that other engines don't
implement.
* Allow to pass with unimplemented <compat-auto> values, since per the
spec the idea of these is to get them removed, see
https://github.com/w3c/csswg-drafts/issues/8506 for the ones we don't
implement.
* Also allow the `-moz-` prefix to be implemented, because we can't
quite get rid of it (people use it to remove the <input type=number>
buttons with -moz-appearance: textfield and so on), and the
alternative is to implement a bunch of non-standard ::-webkit-
pseudo-elements.
Differential Revision: https://phabricator.services.mozilla.com/D171243
|
|
|
|
|
|
|
|
| |
Now it's on by default everywhere, so all this is not needed. No behavior
change effectively since the xul.css bits being removed effectively achieve the
same.
Differential Revision: https://phabricator.services.mozilla.com/D170944
|
| |
|
|
|
|
|
|
|
|
| |
In stead of having the css parser construct a color in it's own format
and then converting it to what Gecko needs to perform operations, we now
construct a Gecko friendly color type directly.
Differential Revision: https://phabricator.services.mozilla.com/D170187
|
|
|
|
|
|
|
|
|
|
| |
This unveils an issue with image-set() tests, which expect 0x to not
parse (inconsistently with media queries).
Fix the test, since the spec doesn't restrict the range of <resolution>
values (and more importantly, it shouldn't allow open ranges).
Differential Revision: https://phabricator.services.mozilla.com/D170762
|
|
|
|
|
|
| |
Clean-up some other test expectations while at it.
Differential Revision: https://phabricator.services.mozilla.com/D170677
|
|
|
|
|
|
|
|
|
| |
Nested image-set CSS functions should fail to parse as per spec.
WPT tests (2 newly pass):
https://github.com/web-platform-tests/wpt/blob/a2154e3f971f3630643741206ce02bbbc5f31d6f/css/css-images/image-set/image-set-parsing.html#L223-L239
Differential Revision: https://phabricator.services.mozilla.com/D170829
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D170676
|
|
|
|
|
|
|
| |
There are no users of non-auto values, so we can just simplify some code and
remove the property.
Differential Revision: https://phabricator.services.mozilla.com/D170010
|
| |
|
|
|
|
|
|
| |
After the previous patches this is rather straight-forward.
Reviewed in: https://phabricator.services.mozilla.com/D168148
|
|
|
|
|
|
|
|
| |
not just chrome-docshells
This will be necessary to make the new env var testable.
Reviewed in: https://phabricator.services.mozilla.com/D168148
|
|
|
|
|
|
|
|
| |
stop arguments valid
Latest spec no longer handles `linear() == linear` and `linear(<single value>) == <single value>`.
Differential Revision: https://phabricator.services.mozilla.com/D169955
|
| |
|
|
|
|
|
|
|
|
| |
Adds the forced-color-adjust property and ForcedColorAdjust keywords.
Updates tweak_when_ignoring_colors to check for `none` value of that property when determining if a color adjustment in needed.
Adds a check for `none` when styling selections to make sure they can be styled in forced color modes.
Differential Revision: https://phabricator.services.mozilla.com/D169000
|
|
|
|
|
|
|
| |
The color mixing is npw using AbsoluteColor and it's conversion
functions. The result is still being converted back to sRGB for now.
Differential Revision: https://phabricator.services.mozilla.com/D169930
|
|
|
|
|
|
|
|
| |
Mixing is now using the new color space for specifying the interpolation
color space. For that reason hsl and hwb is added to the color space
and also converting to/from them.
Differential Revision: https://phabricator.services.mozilla.com/D169929
|
|
|
|
|
|
|
| |
No functional changes, just moving the code to the shared library in
preperation for replacing it with the new AbsoluteColor.
Differential Revision: https://phabricator.services.mozilla.com/D169928
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D169862
|
| |
|
|
|
|
|
|
|
|
|
| |
For ToResolvedValue implementation purposes we wouldn't need to split
out the vertical / font / line-height arguments and we could just pass
around the ComputedStyle, but the lh unit would need that distinction,
(because computing lh on font properties should use the parent style).
Differential Revision: https://phabricator.services.mozilla.com/D168705
|
|
|
|
|
|
|
|
| |
native theme
Untested, but it should work.
Differential Revision: https://phabricator.services.mozilla.com/D169836
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D169607
|
|
|
|
|
|
| |
The patch adds some of the color conversions away from sRGB.
Differential Revision: https://phabricator.services.mozilla.com/D168895
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D149743
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D168788
|
|
|
|
| |
Differential Revision: https://phabricator.services.mozilla.com/D168520
|
|
|
|
|
|
|
|
|
|
| |
This makes the serialization of the 'font' shorthand on computed style return the line-height
as an absolute length rather than a number (font-size multiplier), which is consistent with
what the line-height longhand already returns, and with other browsers.
(See also https://github.com/w3c/csswg-drafts/issues/8385.)
Differential Revision: https://phabricator.services.mozilla.com/D168542
|