aboutsummaryrefslogtreecommitdiffstats
path: root/components/style/properties/helpers.mako.rs
Commit message (Collapse)AuthorAgeFilesLines
...
* Move #[css(iterable)] on fields rather than variantsAnthony Ramine2018-03-061-7/+11
|
* Derive ToCss for all vector longhands that cannot be emptyAnthony Ramine2018-03-051-10/+24
| | | | We don't need to check for emptiness and write `none` for them.
* style: Handle properly potentially-disabled longhands in a shorthand.Emilio Cobos Álvarez2018-02-281-1/+19
|
* style: Only expose longhands to rust via iterators.Emilio Cobos Álvarez2018-02-281-7/+11
| | | | | | | | | The key here is that we only filter longhands if the shorthand is accessible to content and vice-versa. This prevents the bug that prevented me to land this patch before, which was us not expanding properly chrome-only shorthands. Again, this is incomplete, and I need to teach LonghandsToSerialize to get a potentially incomplete list of properties, and all that.
* Auto merge of #19970 - janczer:change_debug_assertions, r=emiliobors-servo2018-02-071-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change debug assertions to specific ones <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #19962 (github issue number if applicable). <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19970) <!-- Reviewable:end -->
| * Change debug assertions to specific onesjanczer2018-02-071-1/+1
| |
* | style: Get rid of gecko_size_type.Emilio Cobos Álvarez2018-02-071-107/+0
| | | | | | | | This also fixes a style sharing issue with MaxLength, anecdotally.
* | style: Move flex-basis out of gecko_size_type.Emilio Cobos Álvarez2018-02-061-6/+0
|/
* Make all PropertyDeclaration variants have only one fieldAnthony Ramine2018-02-061-3/+4
|
* Derive ToComputedValue for keywords without extra specified valuesAnthony Ramine2018-02-031-29/+6
|
* Don't duplicate specified and computed keywordsAnthony Ramine2018-02-031-17/+23
| | | | | The previous code would generate two distinct types for specified and computed values if some variants had aliases.
* Don't use define_css_keyword_enum in style anymoreAnthony Ramine2018-02-011-36/+28
|
* Change ToCss to take a CssWriter<W>Anthony Ramine2018-01-231-9/+14
| | | | | | This more concrete wrapper type can write a prefix the very first time something is written to it. This allows removing plenty of useless monomorphisations caused by the former W/SequenceWriter<W> pair of types.
* style: Remove "derived" properties and the concept of "custom cascade".Emilio Cobos Álvarez2018-01-141-96/+83
|
* Avoid entraining various Debug impls in release builds.Bobby Holley2018-01-131-1/+1
| | | | MozReview-Commit-ID: Lp9i9EI5qdU
* style: Make all keywords CamelCase for consistency.Emilio Cobos Álvarez2017-12-061-11/+13
| | | | This prevents confusion and paves the ground for derive(Parse) of them.
* style: Remove unnecessary explicit argument passing.Emilio Cobos Álvarez2017-11-151-3/+2
| | | | It passes kwargs anyway, and it's not used.
* Move text-decoration-line out of makoKeith Yeung2017-11-141-1/+3
|
* Auto merge of #19119 - CYBAI:font-size-out-of-mako, r=emiliobors-servo2017-11-081-3/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: Move font-size outside of mako This is a sub-PR of #19015 r? emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19111 (github issue number if applicable). - [x] These changes do not require tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19119) <!-- Reviewable:end -->
| * style: Move font-size outside of makoCYBAI2017-11-081-3/+3
| |
* | style: Get rid of parse_specified.Emilio Cobos Álvarez2017-11-081-27/+30
|/ | | | It has a single use, and I don't think we should use it in the future.
* style: respect allow_quirks for boxed properties.Emilio Cobos Álvarez2017-11-071-13/+21
| | | | This will unblock #19119
* style: Do not require to import ToCss in define_css_keyword_enum.Emilio Cobos Álvarez2017-10-241-3/+1
|
* Replace all uses of the `heapsize` crate with `malloc_size_of`.Nicholas Nethercote2017-10-181-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Servo currently uses `heapsize`, but Stylo/Gecko use `malloc_size_of`. `malloc_size_of` is better -- it handles various cases that `heapsize` does not -- so this patch changes Servo to use `malloc_size_of`. This patch makes the following changes to the `malloc_size_of` crate. - Adds `MallocSizeOf` trait implementations for numerous types, some built-in (e.g. `VecDeque`), some external and Servo-only (e.g. `string_cache`). - Makes `enclosing_size_of_op` optional, because vanilla jemalloc doesn't support that operation. - For `HashSet`/`HashMap`, falls back to a computed estimate when `enclosing_size_of_op` isn't available. - Adds an extern "C" `malloc_size_of` function that does the actual heap measurement; this is based on the same functions from the `heapsize` crate. This patch makes the following changes elsewhere. - Converts all the uses of `heapsize` to instead use `malloc_size_of`. - Disables the "heapsize"/"heap_size" feature for the external crates that provide it. - Removes the `HeapSizeOf` implementation from `hashglobe`. - Adds `ignore` annotations to a few `Rc`/`Arc`, because `malloc_size_of` doesn't derive those types, unlike `heapsize`.
* Update to cssparser 0.22 (source location in error types)Simon Sapin2017-10-101-7/+7
|
* Auto merge of #18525 - emilio:border-spacing, r=noxbors-servo2017-09-171-6/+0
|\ | | | | | | | | | | | | | | | | | | | | style: various serialization fixes This should close https://github.com/servo/servo/pull/18458, and fix https://bugzilla.mozilla.org/show_bug.cgi?id=1397619. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18525) <!-- Reviewable:end -->
| * style: Make border-spacing serialization consistent, and move it to ↵Emilio Cobos Álvarez2017-09-171-6/+0
| | | | | | | | precomputed_type.
* | style: Remove unused extra_servo_aliases.Emilio Cobos Álvarez2017-09-171-2/+2
| | | | | | | | Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
* | style: No more need_clone.Emilio Cobos Álvarez2017-09-171-13/+11
|/ | | | Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
* Auto merge of #18499 - heycam:rule-cache, r=emiliobors-servo2017-09-141-0/+14
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rule cache <!-- Please describe your changes on the following line: --> This adds a TLS-based cache reset styles structs keyed off rule nodes. Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1367635 by me and Emilio. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * style: Record the property we are computing on computed::Context, if it's a ↵Cameron McCormack2017-09-141-0/+7
| | | | | | | | non-inherited one.
| * style: Set writing mode dependency and uncacheable state only for ↵Cameron McCormack2017-09-141-2/+4
| | | | | | | | non-inherited properties.
| * style: Add a TLS-based style struct caching mechanism.Emilio Cobos Álvarez2017-09-141-0/+5
| |
* | Measure PropertyDeclaration more thoroughly.Nicholas Nethercote2017-09-141-0/+4
|/ | | | | | | | | | | | | | | This patch replaces the handwritten MallocSizeOf implementation for PropertyDeclaration with a derived one, which gives much more thorough measurement. This requires (a) deriving MallocSizeOf for a *lot* of additional types (most of which already have `derive(HeapSizeOf)` in Servo builds), and (b) implementing MallocSizeOf for a few more types in the `malloc_size_of` crate. These changes would significantly improve the reporting coverage for gmail if it weren't for the fact that SpecifiedUrl isn't measured due to a lack of clarity about its fields; that can be fixed as a follow-up once bug 1397971 has landed.
* Implement ToComputedValue for Box<T>Anthony Ramine2017-09-121-0/+4
|
* Do not use CVAS for FontSettings<T>Anthony Ramine2017-09-121-1/+1
|
* style: Remove the special-case in single_keyword_computed.Emilio Cobos Álvarez2017-09-111-23/+17
| | | | The other case is pretty much the same.
* style: Remove HasViewportPercentage.Emilio Cobos Álvarez2017-08-291-6/+2
| | | | It's not needed since #18268
* style: Remove CascadeInfo.Emilio Cobos Álvarez2017-08-281-6/+0
|
* order derivable traits listsClément DAVID2017-08-231-1/+1
| | | | | | Ignoring : - **generated**.rs - python/tidy/servo_tidy_tests/rust_tidy.rs
* Derive the most trivial Animate implsAnthony Ramine2017-08-221-9/+2
|
* Introduce values::animated::AnimateAnthony Ramine2017-08-221-10/+5
| | | | This replaces the Animatable trait and merges its three former methods into a single one.
* Derive ComputeSquaredDistanceAnthony Ramine2017-08-131-9/+4
|
* Introduce ComputeSquaredDistanceAnthony Ramine2017-08-131-6/+4
| | | | | This allows us to merge the former Animatable methods compute_distance and compute_squared_distance, reducing code size.
* Remove impl_animatable_for_option_tupleAnthony Ramine2017-08-131-57/+0
|
* Bug 1374233 - Part 11: Implement ToAnimatedValue for background-size.Boris Chiou2017-08-041-3/+5
| | | | MozReview-Commit-ID: DMcvpaqHdy9
* style: Standardize different methods to inherit and reset properties.Emilio Cobos Álvarez2017-07-311-0/+9
| | | | | | | This avoids special-casing justify-items. MozReview-Commit-ID: FoEs2IHC1t6 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
* style: Cleanup the cascade a good bit.Emilio Cobos Álvarez2017-07-201-56/+32
|
* Auto merge of #17775 - michael-p:rename-stylearc-to-servo-arc, r=emiliobors-servo2017-07-191-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace all uses of the style::stylearc alias with servo_arc. The `stylearc` alias is left there temporarilly and will be removed completely in a later commit/PR where also `components/style/gecko/generated/structs_{debug|release}.rs` are re-generated (they still use the old alias). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17768 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because no new features / only refactoring <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17775) <!-- Reviewable:end -->
| * Replace all uses of the style::stylearc alias with servo_arc.Michael Partheil2017-07-191-1/+1
| | | | | | | | | | | | The alias is left there temporarilly and will be removed completely in a later commit where also components/style/gecko/generated/structs_{debug|release}.rs are re-generated (they still use the old alias).