| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|\
| |
| |
| | |
This prepares for the rust upgrade currently being conducted.
|
| |
| |
| |
| | |
They are to be removed from the language in the next rust upgrade.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is possible for a PaintTask to start exiting soon after sending new
buffers to the compositor. In that case, the compositor should return
the now unnecessary buffers to the PaintTask so that it can properly
free them.
To accomplish this, the compositor now keeps a hash map of paint task
channels per pipeline id. When a PaintTask exists, the constellation
informs the compositor that it can forget about it. Additionally, the
PaintTask should not wait for any buffers when the engine is doing a
complete shutdown. In that case, the compositor is already halted and
has simply let all buffers leak. We pipe through the shutdown type when
destroying the pipeline to make this decision.
Fixes #2641.
|
|\
| |
| |
| | |
This is a start towards fixing #3868. Not all callers have been fixed yet, so the `Deref` implementation remains for now.
|
| |
| |
| |
| | |
This changes those calls that were already sound.
|
|/
|
|
|
| |
This method is deprecated in rust master; removing its users in advance will
make a future rust upgrade smoother.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| | |
This replaces the specialized TrustedXHRAddress and TrustedWorkerAddress code that was used for the same purpose. A non-zero refcount pins the given DOM object's reflector and prevents it from being GCed even when there are no other outstanding references visible to SpiderMonkey. This will enable us to implement asynchronous operations that refer to particular DOM objects (such as "queue a task to fire a simple event named load at the iframe element" from the spec) safely and conveniently, and paves the way for things like asynchronous network responses.
Some concerns about the resulting size of XHR progress messages have been expressed, but I believe optimizations to reduce that can be implemented in subsequent PRs.
r? @Ms2ger - note in particular the changes to the worker lifetime code. I couldn't figure out how to achieve an identical lifetime to the previous addref/release pairing, and I also was having trouble figuring out why the existing setup was safe. The new implementation now holds the main script task Worker object alive via the TrustedWorkerAddress field in the dedicated worker global scope, which is a significant difference.
|
| |
| |
| |
| | |
the ScriptMsg. This ensures that the main-thread Worker object is rooted for as long as there are events in flight or being processed.
|
| |
| |
| |
| | |
safe, asynchronous/cross-task references to pinned objects.
|
|/ |
|
| |
|
|\
| |
| |
| | |
This refs #3735. As discussed in the issue, I did it cloning when I couldn't dereference an attribute. The trait method should be on `&self` for object-safety reasons.
|
| |
| |
| |
| |
| |
| | |
fixup! Replace XHR events for generic ones in ScriptTask
fixup! Replace XHR events for generic ones in ScriptTask
|
|/
|
|
| |
the mouse moves while on top of it
|
|\ |
|
| | |
|
|/
|
|
|
| |
The name of the method makes it clear it's supposed to be used with a target
override, so we might as well enforce that.
|
|\
| |
| |
| | |
#4406
|
| | |
|
|\ \
| |/
|/|
| |
| |
| | |
I have verified that back and forward work once again.
Sorry about this one. r? @jdm
|
| |
| |
| |
| | |
I have verified that back and forward work once again.
|
| |
| |
| |
| |
| | |
I'm not sure how we want to handle Linux cursors, and GLFW has no
ability to set cursors (short of disabling it and managing it yourself).
|
|/ |
|
|\
| |
| |
| | |
servo/pull/4369 with the right commit.
|
| |
| |
| |
| | |
fixup! Add auxiliary method to EventTargetHelpers for events without target
|
| |
| |
| |
| | |
This was my fault. It comes up on almost any page after scrolling a bit.
|
| | |
|
|/
|
|
|
| |
This fixes race conditions whereby layout and script could be running
simultaneously.
|
|\ |
|
| | |
|
| | |
|
| | |
|
| | |
|
|/
|
|
| |
Fixes #4167.
|
|
|
|
| |
Fixes #4163
|
| |
|
|
|
|
|
| |
In both the javascript and non-javascript url cases, final_url is set to the
same url as is stored by the Page.
|
|
|
|
|
| |
It does not need to take ownership, and I want to reuse final_url in the
caller.
|
|
|
|
| |
This seems like a clearer name, as it's used for more than just as a base url.
|
|
|
|
|
| |
This url is the pre-redirect url, which is not particularly meaningful, and it
is used only in a panic message.
|
|
|
|
|
| |
It is None iff the parser input is an InputString variant, so it makes more
sense to pass it in the same enum.
|
|
|
|
|
| |
Now that the code lives in the same function, I see no reason for them to
remain separate.
|
|
|
|
| |
It turns out the case where it woul be None can't happen.
|
|
|
|
|
|
| |
This doesn't really have anything to do with parsing HTML, and fits in better
with the code in ScriptTask::load. In particular, all changes to Page's url
now go through ScriptTask methods.
|
| |
|
| |
|