| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
| |
becomes display:none.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We create the SequentialTask only if:
* We have no old computed values and we have animation name style in the new
computed values.
* Any animation properties is changed.
* display property is changed from 'none' and we have animation name style.
* display property is changed to 'none'.
In a subsequent patch we skip the SequentialTask if we have no running
animations and the display propery is changed to 'none'.
|
| |
|
|
|
|
|
| |
or_else in more idiomatic rust construction than
match, where Some(x) => Some(x)
|
| |
|
| |
|
|
|
|
|
| |
This is necessary to start synthesizing the styles in match_element and avoid
round-tripping them through the caller.
|
| |
|
| |
|
|
|
|
| |
style. r=emilio
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fix inline layout of table cells impacted by rowspan
This is part of the fix for #11297. This PR fixes the inline layout of table cells impacted by row-spanning cells from previous rows. A separate PR to follow will fix the table block size calculations to account for rowspan.
This PR doesn't yet include any test changes. If it doesn't cause any existing tests to pass, I will add a new test to it.
r? @pcwalton
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14518)
<!-- Reviewable:end -->
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
tree logging. r=heycam
MozReview-Commit-ID: 4Fy3ujpI4n2
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary idea of this patch is to ditch the rigid enum of Previous/Current
styles, and replace it with a series of indicators for the various types of
work that needs to be performed (expanding snapshots, rematching, recascading,
and damage processing). This loses us a little bit of sanity checking (since
the up-to-date-ness of our style is no longer baked into the type system), but
gives us a lot more flexibility that we'll need going forward (especially when
we separate matching from cascading). We also eliminate get_styling_mode in
favor of a method on the traversal.
This patch does a few other things as ridealongs:
* Temporarily eliminates the handling for transfering ownership of styles to the
frame. We'll need this again at some point, but for now it's causing too much
complexity for a half-implemented feature.
* Ditches TRestyleDamage, which is no longer necessary post-crate-merge, and is
a constant source of compilation failures from either needing to be imported
or being unnecessarily imported (which varies between gecko and servo).
* Expands Snapshots for the traversal root, which was missing before.
* Fixes up the skip_root stuff to avoid visiting the skipped root.
* Unifies parallel traversal and avoids spawning for a single work item.
* Adds an explicit pre_traverse step do any pre-processing and determine whether
we need to traverse at all.
MozReview-Commit-ID: IKhLAkAigXE
|
| |
|
|
|
|
| |
MozReview-Commit-ID: 6AV2UWyl6pl
|
|
|
|
|
| |
The idea is this will fix the bad behavior of the bloom filter in parallel
traversal.
|
|
|
|
| |
MozReview-Commit-ID: 7wH5XcILVmX
|
| |
|
|
|
|
| |
This makes it consistent with an upcoming update of the selectors crate.
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Urlmageddon
<!-- Please describe your changes on the following line: -->
Still needs a bunch of code in net to be converted in order to get more
advantage of this for images and stuff, but meanwhile this should help quite a
bit with #13778.
Still wanted to get this in.
r? @SimonSapin
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14246)
<!-- Reviewable:end -->
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
damage.
This will take the place of setting IS_DIRTY and HAS_CHANGED.
|
|/
|
|
|
|
| |
The style system never actually does anything with the document. This allows us
to remove a bunch of stubbing on the Gecko side and streamline some things on
the Servo side in future patches.
|
|
|
|
| |
MozReview-Commit-ID: LfaZFCVlIb1
|
|
|
|
| |
MozReview-Commit-ID: LS23s2RbMBg
|
| |
|
|
|
|
| |
MozReview-Commit-ID: 8ls43oAGWRg
|
|
|
|
|
|
|
|
|
| |
either styling or restyling.
We also make sure that an element never has an ElementData with ElementDataStyles::Uninitialized,
and eagerly call prepare_for_styling whenever an ElementData is instantiated.
MozReview-Commit-ID: 9YP6eSmdMt0
|
|
|
|
| |
MozReview-Commit-ID: 96VsmsoZtjZ
|
|
|
|
| |
MozReview-Commit-ID: DZ8ZrsZIiAU
|
| |
|
|
|
|
| |
MozReview-Commit-ID: 3V6JIlOVVhw
|
|
|
|
| |
MozReview-Commit-ID: 6CtQMxbcLnF
|
|
|
|
|
|
|
|
| |
Instead of maintaining a dummy restyle damage field for text nodes, we can just
perform the necessary parent inheritance and is_changed adjustments on the fly
in ThreadSafeLayoutNode, simplifying the requirements on the style system.
MozReview-Commit-ID: DCqiCRLsLUF
|
|
|
|
| |
MozReview-Commit-ID: IolVN5puF1i
|
|
|
|
| |
MozReview-Commit-ID: 926ReI1BSsf
|
|
|
|
| |
MozReview-Commit-ID: 5tF075EJKBa
|
|
|
|
|
|
| |
restyle algorithm.
MozReview-Commit-ID: 8iOALQylOuK
|
|
|
|
|
|
|
|
| |
A couple of changes here:
* Remove the option to unset with the dirty bit setters.
* Add an explicit API for setting text node style.
* Hoist has_changed handling into the restyle damage setter and text node style setter.
* Make set_style take a non-Option.
|
|\
| |
| |
| |
| |
| |
| |
| | |
Use mem::replace in take_pseudo_styles.
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13691)
<!-- Reviewable:end -->
|