Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix misspelled "get_suported_extensions" function | Daniel Alley | 2020-04-06 | 2 | -2/+2 |
| | | | | closes #21122 | ||||
* | Auto merge of #26110 - servo:layout-2020-rm-note-dirty-descendant, r=emilio | bors-servo | 2020-04-04 | 1 | -2/+8 |
|\ | | | | | | | Kill ServoLayoutElement::note_dirty_descendant | ||||
| * | Kill ServoLayoutElement::note_dirty_descendant | Anthony Ramine | 2020-04-04 | 1 | -2/+8 |
| | | | | | | | | | | | | There is no need to set the dirty descendants flag unsafely from the layout side for elements with pending restyles, we can do that on the DOM side when draining the restyles from the Document. | ||||
* | | Auto merge of #26105 - servo:layout-2020-less-opaque, r=emilio | bors-servo | 2020-04-04 | 2 | -59/+13 |
|\ \ | |/ |/| | | | Make DOM own the style and layout data, in an UnsafeCell | ||||
| * | Make DOM own the style and layout data, in an UnsafeCell | Anthony Ramine | 2020-04-04 | 2 | -59/+13 |
| | | | | | | | | The previous Cell was a lie. | ||||
* | | Form constraints validation | teapotd | 2020-04-02 | 20 | -213/+1107 |
|/ | |||||
* | Auto merge of #26083 - servo:layout-2020-more-cleanups, r=jdm | bors-servo | 2020-04-01 | 20 | -536/+480 |
|\ | | | | | | | | | | | More layout cleanups from the introduction of a lifetime in LayoutDom<T> What can I say, the follow-up fixes just kept coming to my door one by one, I couldn't just tell them to go away. | ||||
| * | Add some comments and remove obsolete allow attributes | Anthony Ramine | 2020-04-01 | 2 | -3/+9 |
| | | |||||
| * | Introduce more layout helpers to make selection_for_layout be safe | Anthony Ramine | 2020-04-01 | 3 | -18/+30 |
| | | |||||
| * | Introduce <LayoutDom<Element>>::focus_state | Anthony Ramine | 2020-04-01 | 3 | -2/+14 |
| | | |||||
| * | Make LayoutShadowRootHelpers::get_style_data_for_layout return a &CascadeData | Anthony Ramine | 2020-04-01 | 1 | -3/+6 |
| | | | | | | | | That return type is Sync, which thus means that the method can be safe. | ||||
| * | Make synthesize_presentational_hints_for_legacy_attributes be safe | Anthony Ramine | 2020-04-01 | 1 | -4/+2 |
| | | |||||
| * | Make LayoutDocumentHelpers::style_shared_lock be safe | Anthony Ramine | 2020-04-01 | 1 | -3/+3 |
| | | | | | | | | StyleSharedRwLock is Sync. | ||||
| * | Move unsafe code out of <LayoutDom<HTMLTextAreaElement>>::value_for_layout | Anthony Ramine | 2020-04-01 | 1 | -10/+19 |
| | | |||||
| * | Introduce a bunch of LayoutDom<HTMLInputElement> private helpers | Anthony Ramine | 2020-04-01 | 1 | -30/+31 |
| | | | | | | | | Those help contain the unsafety in most of the actual helpers used by layout. | ||||
| * | Introduce <LayoutDom<HTMLImageElement>>::current_request | Anthony Ramine | 2020-04-01 | 2 | -43/+26 |
| | | | | | | | | | | This safe helper contains the only source of unsafety from the actual image layout helpers methods, making them completely safe. | ||||
| * | Make LayoutNodeHelpers::composed_parent_node_ref be safe | Anthony Ramine | 2020-04-01 | 2 | -28/+30 |
| | | | | | | | | | | | | For clarity, I introduce <LayoutDom<Element>>::parent_node_ref to contain the remaining unsafety bits out of composed_parent_node_ref which is more complex than just a field access. | ||||
| * | Make LayoutShadowRootHelpers::get_host_for_layout be safe | Anthony Ramine | 2020-03-31 | 1 | -6/+8 |
| | | |||||
| * | Make a bunch of LayoutNodeHelpers be safe | Anthony Ramine | 2020-03-31 | 1 | -24/+21 |
| | | |||||
| * | Introduce LayoutDom::is | Anthony Ramine | 2020-03-31 | 2 | -4/+12 |
| | | | | | | | | Just like Castable::is. | ||||
| * | Make layout methods accessing rare data be safe | Anthony Ramine | 2020-03-31 | 2 | -19/+22 |
| | | | | | | | | | | | | They don't do anything fancy so there is no additional unsafety calling them compared to using LayoutDom in the first place, the usual story of all those changes. | ||||
| * | Don't generate rare_data_for_layout methods anymore | Anthony Ramine | 2020-03-31 | 3 | -9/+6 |
| | | | | | | | | It is only used twice. | ||||
| * | Introduce LayoutDom::to_layout_slice | Anthony Ramine | 2020-03-31 | 2 | -8/+10 |
| | | | | | | | | It generalises <LayoutDom<Element>>::attrs. | ||||
| * | Make a bunch of LayoutDocumentHelpers be safe | Anthony Ramine | 2020-03-31 | 1 | -17/+23 |
| | | | | | | | | The other methods are actually unsafe. | ||||
| * | Make LayoutCanvasRenderingContext2DHelpers::get_canvas_id be safe | Anthony Ramine | 2020-03-31 | 1 | -7/+11 |
| | | |||||
| * | Make a bunch or trivial LayoutElementHelpers safe | Anthony Ramine | 2020-03-31 | 1 | -13/+7 |
| | | |||||
| * | Reduce scope of unsafe block in LayoutHTMLCanvasElementHelpers::data | Anthony Ramine | 2020-03-31 | 1 | -15/+15 |
| | | |||||
| * | Introduce <LayoutDom<Element>>::attrs() | Anthony Ramine | 2020-03-31 | 14 | -238/+150 |
| | | | | | | | | | | | | This safe method is the basic block to access element attributes from layout. We reuse it in the other attr-related layout methods to remove a pretty big source of rampant unsafe code between script and layout. | ||||
| * | Merge RawLayoutElementHelpers into LayoutElementHelpers | Anthony Ramine | 2020-03-31 | 14 | -76/+69 |
| | | |||||
| * | Move around some code in the element | Anthony Ramine | 2020-03-31 | 1 | -52/+52 |
| | | | | | | | | | | The intent is to merge the two layout helper traits together so I'm moving them around to make later diffs more readable. | ||||
* | | Auto merge of #26077 - jdm:xr-canvas-dirty, r=asajeffrey | bors-servo | 2020-03-31 | 3 | -0/+18 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | webgl: Don't dirty canvas element while in immersive mode. There are various WebGL APIs that are supposed to trigger a frame composite at the end of the event loop when they're used. We enforce this via dirtying the canvas element and ensuring that reflow occurs for normal content. This is redundant when we're using immersive mode and incurs extra work by the layout thread and compositor that inhibits the immersive rendering performance. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix (part of) #26019 - [x] These changes do not require tests because we do not have infrastructure to test immersive mode on CI. | ||||
| * | | webgl: Don't dirty canvas element while in immersive mode. | Josh Matthews | 2020-03-31 | 3 | -0/+18 |
| | | | |||||
* | | | Cache the result of retrieving an element's client rectangle from layout. | Josh Matthews | 2020-03-31 | 4 | -21/+124 |
|/ / | |||||
* | | Auto merge of #26070 - servo:layout-2020-more-cleanups, r=SimonSapin | bors-servo | 2020-03-31 | 6 | -66/+73 |
|\| | | | | | | | | | | | Make LayoutNodeHelpers::text_content return a cow What does it mean? It means that layout can process `Text` nodes' contents by just borrowing them, potentially saving us from a lot of unnecessary tempoorary allocations, which is nice. | ||||
| * | Remove an obsolete comment | Anthony Ramine | 2020-03-31 | 1 | -1/+0 |
| | | |||||
| * | Make LayoutNodeHelpers::text_content return a cow | Anthony Ramine | 2020-03-31 | 1 | -6/+6 |
| | | |||||
| * | Make LayoutCharacterDataHelpers::data_for_layout be safe | Anthony Ramine | 2020-03-31 | 2 | -7/+5 |
| | | |||||
| * | Make LayoutHTMLTextAreaElementHelpers::value_for_layout safe | Anthony Ramine | 2020-03-31 | 2 | -14/+13 |
| | | |||||
| * | Make LayoutHTMLInputElementHelpers::value_for_layout return a cow | Anthony Ramine | 2020-03-31 | 2 | -26/+31 |
| | | |||||
| * | Introduce AttrHelpersForLayout::namespace | Anthony Ramine | 2020-03-31 | 2 | -1/+7 |
| | | |||||
| * | Don't clone the result of AttrHelpersForLayout::local_name | Anthony Ramine | 2020-03-31 | 2 | -5/+5 |
| | | | | | | | | There is no need to do that. Embrace returning borrows from the DOM, it good. | ||||
| * | Rename AttrHelpersForLayout methods | Anthony Ramine | 2020-03-31 | 2 | -11/+11 |
| | | |||||
| * | Make AttrHelpersForLayout methods be safe | Anthony Ramine | 2020-03-31 | 1 | -10/+10 |
| | | | | | | | | The unsafety isn't there, it's in the creation of the LayoutDom<T> values. | ||||
* | | Use mozjs exposed function to generate SourceText | CYBAI | 2020-03-31 | 2 | -16/+6 |
|/ | |||||
* | Auto merge of #26054 - shnmorimoto:fix_tojson_unconditionally_serializes, r=jdm | bors-servo | 2020-03-31 | 2 | -11/+22 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix tojson unconditionally serializes <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25281 <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> | ||||
| * | fixed CGCollectJSONAttributesMethod | Shinichi Morimoto | 2020-03-31 | 1 | -5/+3 |
| | | |||||
| * | fixed is_satisfied condition | Shinichi Morimoto | 2020-03-30 | 1 | -12/+14 |
| | | |||||
| * | remove unnecessary condition | Shinichi Morimoto | 2020-03-30 | 1 | -3/+0 |
| | | |||||
| * | fixed fmt | Shinichi Morimoto | 2020-03-28 | 2 | -3/+7 |
| | | |||||
| * | fixed #25281 | Shinichi Morimoto | 2020-03-28 | 3 | -3/+13 |
| | |