aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
Commit message (Collapse)AuthorAgeFilesLines
* Auto merge of #24789 - gterzian:fix_unloading, r=jdmbors-servo2019-11-221-1/+12
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix unloading, active BC, and clearing js runtime <!-- Please describe your changes on the following line: --> Do not set the window to be the currently active one for the windowproxy as part of `load`, as it will be done later when the document activity is set. And doing it later means that when unload runs, it is with the unloaded pipeline as the active window. Only nullify the window proxy if it's not used by another (currently-active) window. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #24591 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * ensure unload run with old pipeline as currently-active, do not nullify ↵Gregory Terzian2019-11-211-1/+12
| | | | | | | | proxy unless currently-active
* | Auto merge of #24816 - saschanaz:promiserejection, r=jdmbors-servo2019-11-213-20/+12
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Require PromiseRejectionEventInit dictionary <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #22670 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Require PromiseRejectionEventInit dictionaryKagami Sascha Rosylight2019-11-223-20/+12
| | |
* | | dom: Unindent Document::set_activity.Josh Matthews2019-11-211-54/+61
|/ /
* | Auto merge of #24757 - Akash-Pateria:async-wasm-compilation-subsequent, r=jdmbors-servo2019-11-203-3/+13
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Async wasm compilation event loop integration The PR contains changes related to binding the runnable dispatching in script_runtime and is part of the Asynchronous WebAssembly Compilation fix. This is the first step in the subsequent steps mentioned in the [wiki](https://github.com/servo/servo/wiki/Asynchronous-WebAssembly-compilation-project). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes are part of #21476 fix
| * | Bind runnable dispatching in script_runtimeAkash-Pateria2019-11-193-3/+13
| | |
* | | Fix metadata updateFernando Jiménez Moreno2019-11-203-25/+48
| | |
* | | Fallback to current url as metadata titleFernando Jiménez Moreno2019-11-201-2/+7
| | |
* | | Update media session metadata according to media playerFernando Jiménez Moreno2019-11-202-5/+33
| | |
* | | Remove prev and next track action buttons for nowFernando Jiménez Moreno2019-11-201-1/+0
| | |
* | | Fix media session action handlingFernando Jiménez Moreno2019-11-202-27/+11
| | |
* | | Default media session actionsFernando Jiménez Moreno2019-11-202-2/+36
| | |
* | | Format code and fix rebase errorsFernando Jiménez Moreno2019-11-201-1/+1
| | |
* | | Move active media session logic to constellationFernando Jiménez Moreno2019-11-202-11/+10
| | |
* | | Send MediaSessionAction from AndroidFernando Jiménez Moreno2019-11-202-6/+1
| | |
* | | Adapt MediaMetadata interface to new way of declaring constructorsFernando Jiménez Moreno2019-11-201-2/+2
| | |
* | | MediaSession show media controls on AndroidFernando Jiménez Moreno2019-11-201-1/+7
| | |
* | | Send MediaSessionEvent::PlaybackStateChange when neededFernando Jiménez Moreno2019-11-201-8/+22
| | |
* | | Introduce embedder MediaSessionEvent and move active session to ServoFernando Jiménez Moreno2019-11-202-10/+13
| | |
* | | Register media instance with session and prepare communication with embedderFernando Jiménez Moreno2019-11-203-4/+47
| | |
* | | Handle media session action, no default handling yetFernando Jiménez Moreno2019-11-202-2/+9
| | |
* | | MediaSession: update action handler algorithmFernando Jiménez Moreno2019-11-202-4/+36
| | |
* | | Make MediaSession handle embedder requested actionFernando Jiménez Moreno2019-11-201-0/+5
| | |
* | | Use BrowsingContextId for MediaSession registrationFernando Jiménez Moreno2019-11-201-11/+9
| | |
* | | MediaSession registrationFernando Jiménez Moreno2019-11-201-7/+26
| | |
* | | Set MediaMetadata MediaSession ownerFernando Jiménez Moreno2019-11-202-5/+11
| | |
* | | MediaSession API DOM bindingsFernando Jiménez Moreno2019-11-206-0/+262
|/ /
* | Auto merge of #24687 - ferjm:mediaelementaudionode, r=Manishearthbors-servo2019-11-198-27/+165
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | WebAudio MediaElementAudioSourceNode implementation - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #22370 - [X] There are tests for these changes Depends on https://github.com/servo/media/pull/321 Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/ I am still investigating why it is playing back with a low rate.
| * Implement AudioContext.createMediaElementAudioSourceNode()Fernando Jiménez Moreno2019-11-183-7/+20
| |
| * MediaElementAudioSourceNode: set audio rendererFernando Jiménez Moreno2019-11-183-8/+29
| |
| * MediaElementAudioSourceNode implementationFernando Jiménez Moreno2019-11-184-0/+103
| |
| * Rename frame_renderer to video_rendererFernando Jiménez Moreno2019-11-181-10/+10
| |
| * Update servo-media with MediaElementAudioSourceNode engineFernando Jiménez Moreno2019-11-183-15/+16
| |
* | Auto merge of #24685 - shnmorimoto:fix_revoke_blob_url, r=jdmbors-servo2019-11-181-7/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix revoke blob url <!-- Please describe your changes on the following line: --> fix #24290 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24290 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | check same-origin and url against the blob beign revokedShinichi Morimoto2019-11-181-7/+9
| |/
* | Auto merge of #24669 - glowe:issue-24628/set-mime-type, r=jdmbors-servo2019-11-181-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set response mime_type based on Content-Type <!-- Please describe your changes on the following line: --> Set the response's `mime_type` based on its `Content-Type` header whenever `Response::set_headers` is called. This ensures that `mime_type` is always consistent with `Content-Type`. The other reason for going with this approach is it relies on `extract_mime_type`: https://github.com/servo/servo/blob/afbcbf75eaa63ff0eec8fd3858e9155eb8dbadaa/components/script/dom/headers.rs#L260-L261 Besides the consistency argument, I also expect that we'll update the `extract_mime_type` method to conform with its specification. Another option I explored was adding a `set_mime_type` member to `Response` and calling that with the mime type from `Metadata::content_type` in `FetchResponseListener::process_response`. I decided against this since it expanded the interface of `Response` and didn't have the same benefits of the first option. Fixes #24628. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24628. <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Set response mime_type based on Content-Typeglowe2019-11-141-0/+1
| | | | | | | | | | | | | | | | | | | | | Set the response's mime_type based on its Content-Type header whenever Response::set_headers is called. Fixes #24628.
* | | Auto merge of #24664 - gterzian:fix_port_transfer, r=jdmbors-servo2019-11-181-15/+73
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix loophole in messageport transfer <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #24600 (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | fix complete messageport transferGregory Terzian2019-11-151-15/+73
| | |
* | | Auto merge of #24665 - saschanaz:timerhandler, r=noxbors-servo2019-11-174-91/+54
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use TimerHandler IDL union type <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20700 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Use TimerHandler IDL union typeKagami Sascha Rosylight2019-11-054-91/+54
| | | |
* | | | Use `#![register_tool]` instead of `#![register_attr]`Simon Sapin2019-11-1536-57/+58
| | | | | | | | | | | | | | | | CC https://github.com/rust-lang/rust/issues/66079
* | | | Auto merge of #24624 - garasubo:fix-keypress-trigger, r=paulrougetbors-servo2019-11-141-1/+9
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix keypress trigger condition Fix #22346 keypress event should be triggered for keys representing character values. So, we should trigger this event for enter key. This event should not trigger for IME inputs. TODO: - It seems we don't handle composition events correctly. To implement this keypress condition correctly, we should fix that first. In my current implementation, onkeypress event will be trigger when the user press Enter key to send inputs in IME (onCompotionEnd). - I don't update any tests, and I couldn't find any tests related to this change in WPT. It might be better to add some tests for it, but I don't know what is the appropriate way. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Solve #22346takumi2019-11-031-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | keypress event should be triggered for keys representing character values. So, we should trigger this event for enter key. This event should not trigger for IME inputs.
* | | | Auto merge of #24674 - servo:jdm-patch-34, r=noxbors-servo2019-11-131-4/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Correct inverted logic for available image checks. From https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data: Step 3 says to initialize selected source to null. Step 4 says to set the selected source to the image element's src value if it's not using responsive images and it has a non-empty src value. Step 6 performs some steps if selected source is not null. The existing code tried to do the step 6 check in a roundabout way which caused us to always check for an available image when using responsive images, which is incorrect. The new code is easier to read and matches the specification text. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's not worth writing a test to verify that an image cache check that would always fail does not happen.
| * | | | Correct inverted logic for available image checks.Josh Matthews2019-11-061-4/+1
| | | | |
* | | | | dom: Reduce the scope of iframe's load blocker borrow.Josh Matthews2019-11-121-4/+7
| | | | |
* | | | | Implement srcdoc support for iframes.jaymodi982019-11-122-4/+49
| | | | |
* | | | | Addresses issues raised in #24465; removes redundancy in set_bitmap_dimensionsBailey Blankenship2019-11-107-39/+92
| | | | | | | | | | | | | | | | | | | | Removed passing test .ini files and moved euclid extensions to euclidext.rs to factor out redundant code