aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom/element.rs
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove recursiveness from directionality searchDmitry Kolupaev2020-02-251-2/+5
|
* Rearrange directionality algorithm functionsDmitry Kolupaev2020-02-251-58/+4
|
* Implement dirname for form submit and directionality for elementDmitry Kolupaev2020-02-251-0/+64
|
* Auto merge of #25548 - pshaughn:docnamedgetter, r=jdmbors-servo2020-02-131-12/+43
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add SupportedPropertyNames to Document (also fix iframe getting) Existing test of named-getting an iframe now succeeds. I added a new test for Object.getOwnPropertyNames(document) based on my understanding of the spec; that test could use a second opinion. UPDATE: This was trying to do too many things in one PR as originally submitted. It is now using #25572 as a base, and I suggest reviewing that PR before this one to avoid duplicating review effort. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #7273 for all implemented named getters, fix #25146, and fix the iframe case only of #25145. <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Doc named getter improvementsPatrick Shaughnessy2020-02-131-11/+43
| |
| * Names should now be consistently atomsPatrick Shaughnessy2020-02-131-1/+0
| |
* | Auto merge of #25488 - pshaughn:clickactivate, r=jdmbors-servo2020-02-131-48/+0
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Event dispatch rewritten to align to spec, activate on clicks better I went over the changes to the event dispatch spec that had accumulated over the past few years, rewriting dispatch/invoke/inner-invoke almost completely and modifying other code where it was relevant. Most of the remaining obvious deviations from spec are things that will only come up when we start handling events in shadow DOM. I am pushing now because I want to see CI test results, but please do not approve this PR just if automated test improvements look good. I may have broken some actual UI interactions in the course of fixing synthetic events, and some manual testing is needed, including checking that manual interactions with interactive content continue to fire the events they're supposed to. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25384 and fix #22783 and fix #25199 <!-- Either: --> - [ ] There are automated tests for the synthetic-click parts of these changes, BUT the effects on real UI events need some manual testing before merging <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Event dispatch rewritten to resemble spec more often, activate on clicks betterPatrick Shaughnessy2020-02-121-48/+0
| |
* | Auto merge of #25572 - pshaughn:atomnames, r=jdmbors-servo2020-02-131-2/+44
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make name content attributes consistently atoms and put them in rare_data for fast access <!-- Please describe your changes on the following line: --> All codepaths setting the name content attribute now use an atom, which is also stored in rare_data for direct lookup by a get_name method. Paralleling the get_name method, I added a get_id method, which makes some internal id-lookup cases nicer. A new test tests for a name setter on every HTML element type. In addition to its overt and upstreamable purpose of checking IDL property reflection semantics, for us this test also hits some Servo assertions that make sure the name is an atom in every case. If the test doesn't crash, even a failed test case still has the attribute as an atom rather than some other type. The failed cases are for elements that we have unimplemented or completely stubbed; I added a few missing name IDL properties to otherwise implemented elements. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25570 and make progress on #25057 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Names should now be consistently atomsPatrick Shaughnessy2020-02-131-2/+44
| |/
* | Auto merge of #25629 - pshaughn:reflect_translate, r=jdmbors-servo2020-02-131-0/+19
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement "translate" attribute This attribute is almost a straightforward enumerated one, but the getter value inherits from parents when the content attribute is absent, even when the parents are non-HTML elements. This initial commit is using LocalName::from on a static string; once html5ever has a release with "translate" in the built-in local name list, a small change will be needed. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25628 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Translate attribute and its inheritance semanticsPatrick Shaughnessy2020-02-121-0/+19
| |
* | :defined worksPatrick Shaughnessy2020-01-301-2/+12
|/
* Prevent infinite recursion when upgrading custom elementsPatrick Shaughnessy2020-01-221-0/+4
|
* Modify `script` to prevent further violations of snake_caseKunal Mohan2020-01-181-0/+1
|
* Add accountable-refcell as optional build time featureKunal Mohan2020-01-081-3/+2
|
* Attr is a Node, with consequences for many Node methodsPatrick Shaughnessy2019-12-231-2/+1
|
* style: Fix servo build.Emilio Cobos Álvarez2019-11-301-0/+8
|
* Support CORS attributes for image elements.Josh Matthews2019-10-041-2/+10
|
* Upgrade to rustc 1.38.0-nightly (dddb7fca0 2019-07-30)Simon Sapin2019-07-311-9/+9
|
* More detach shadow changesFernando Jiménez Moreno2019-07-221-1/+0
|
* Detach shadow clean upFernando Jiménez Moreno2019-07-221-1/+2
|
* Remove unused ShadowRoot constructor argumentFernando Jiménez Moreno2019-07-221-1/+1
|
* Implement method to remove media controlsFernando Jiménez Moreno2019-07-221-0/+9
|
* Barebones media UIFernando Jiménez Moreno2019-07-221-9/+4
|
* style: Rustfmt again.Emilio Cobos Álvarez2019-06-251-1/+4
|
* Fix style system build with recent changes.Emilio Cobos Álvarez2019-06-251-3/+2
|
* Auto merge of #23503 - emilio:gecko-sync, r=emiliobors-servo2019-06-041-4/+9
|\ | | | | | | | | | | | | | | | | | | | | style: sync changes from mozilla-central See each individual commit for details. This also cherry-picks #23463 with a few fixes that were needed in Gecko-only code. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23503) <!-- Reviewable:end -->
| * style: Do not use borrowed types in the selectors::Element trait.Evgeniy Reizner2019-06-041-4/+9
| | | | | | | | | | Closes #22972 Closes #23463
* | Auto merge of #23499 - est31:unused_code_removal_3, r=jdmbors-servo2019-06-041-34/+0
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove unused code (3/N) <!-- Please describe your changes on the following line: --> Third PR in a series of PRs to remove unused/dead code from servo, powered by an (upcoming) tool of mine. Please take a look and tell me if you want to keep something. * First PR: #23477 * Second PR: #23498 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they only remove dead code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23499) <!-- Reviewable:end -->
| * Remove unused code from script* cratesest312019-06-021-34/+0
| |
* | script: Fix Servo build.Emilio Cobos Álvarez2019-05-291-3/+7
|/
* layout: fix Servo build.Emilio Cobos Álvarez2019-05-071-0/+4
|
* Set self as containing_shadow_root for shadow rootsFernando Jiménez Moreno2019-04-291-0/+3
|
* Final nits; fix custom elements rare data usage; s/owner_s_r/containing_s_rFernando Jiménez Moreno2019-04-291-51/+55
| | | | | Clarify special case for containing_shadow_root and add it to layout accessor
* Do not lazy initialize RareData on its gettersFernando Jiménez Moreno2019-04-261-64/+53
|
* Make Node and Element rare_data an OptionFernando Jiménez Moreno2019-04-261-24/+42
|
* Merge Node::shadow_including_inclusive_ancestors into inclusive_ancestorsFernando Jiménez Moreno2019-04-261-5/+8
|
* Minor tweaks: rename composed_parent_node_ref, remove or update outdated ↵Fernando Jiménez Moreno2019-04-261-1/+1
| | | | comments...
* Tweak list of shadow roots attached to docFernando Jiménez Moreno2019-04-261-2/+6
|
* Set IS_CONNECTED flag on host and children instead of on containing shadow rootFernando Jiménez Moreno2019-04-261-1/+1
|
* Add custom elements related stuff into ElementRareDataFernando Jiménez Moreno2019-04-261-29/+20
|
* Introduce NodeRareData and ElementRareDataFernando Jiménez Moreno2019-04-261-8/+10
|
* Introduce BindContext with in_doc and connected flagsFernando Jiménez Moreno2019-04-261-12/+11
| | | | Fix some is_in_doc -> is_connected mistakes
* Register named elements in either the document or shadow treeFernando Jiménez Moreno2019-04-261-6/+22
|
* Relax attachShadow restrictions for user agent widgetsFernando Jiménez Moreno2019-04-261-2/+11
|
* Fix the way the IS_CONNECTED flag is setFernando Jiménez Moreno2019-04-261-7/+2
|
* Register/unregister shadow roots in documents when they are connectedFernando Jiménez Moreno2019-04-261-6/+13
|
* Move stylesheets related code to DocumentOrShadowRootFernando Jiménez Moreno2019-04-261-1/+1
|
* First bits of shadow dom layoutFernando Jiménez Moreno2019-04-261-3/+20
|