aboutsummaryrefslogtreecommitdiffstats
path: root/components/layout/table_row.rs
Commit message (Collapse)AuthorAgeFilesLines
...
* Update bitflags to 1.0 in every servo crateBastien Orivel2017-10-191-3/+3
| | | | | It still needs dependencies update to remove all the other bitflags versions.
* Introduce an unsafe HasBaseFlow trait for base()/base_mut() casts.Simon Sapin2017-10-141-0/+4
|
* Auto merge of #18506 - mrobinson:position-sticky-table, r=emiliobors-servo2017-09-181-2/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix issues with the combination of position:sticky and tables <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #18441 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18506) <!-- Reviewable:end -->
| * Fix panic when tables having position:stickyMartin Robinson2017-09-151-2/+3
| | | | | | | | | | We no longer do any stacking context or clip node creation for table wrappers, instead relying on their TableFlows to do this.
* | style: Make border-spacing serialization consistent, and move it to ↵Emilio Cobos Álvarez2017-09-171-9/+6
|/ | | | precomputed_type.
* Auto merge of #18462 - mrobinson:cleanup-building-state, r=emiliobors-servo2017-09-151-1/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Do some minor cleanups in display list building <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they should not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18462) <!-- Reviewable:end -->
| * Separate stacking context collection and display list building stateMartin Robinson2017-09-121-1/+2
| | | | | | | | | | | | | | These are two different passes during layout, but previously they shared a state object. While some of the members are the same, many are different so we separate them out into two separate objects. We also change the HashMaps of these state objects to use the FnvHashMap.
* | Use CSSPixelLength in LengthOrPercentage{*}.Boris Chiou2017-09-131-1/+1
| | | | | | | | | | Replace Au with CSSPixelLength in LengthOrPercentage, LengthOrPercentageOrAuto, and LengthOrPercentageOrNone.
* | Introduce CSSPixelLength and update NonNegativeLength.Boris Chiou2017-09-131-11/+11
|/ | | | | | | | | | | First, we define computed::CSSPixelLength which contains a CSSFloat, a pixel value, and then we replace computed::Length with CSSPixelLength. Therefore, the |ComputedValue| of NoCalcLength, AbsoluteLength, FontRelativeLength, ViewportPercentageLength, CharacterWidth, and PhysicalLength is CSSPixelLength. Besides, we drop NonNegativeAu, and replace computed::NonNegativeLength with NonNegative<computed::Length>. (i.e. NonNegative<CSSPixelLength>)
* Add support for position:stickyMartin Robinson2017-09-051-2/+3
| | | | | | | | This leverages the position:sticky support in WebRender to bring basic support for position:sticky in Servo. There are still some issues with nested sticky flows as well as a few other corner cases. Tests are imported from WPT and can be removed once we update to the latest version.
* order derivable traits listsClément DAVID2017-08-231-4/+4
| | | | | | Ignoring : - **generated**.rs - python/tidy/servo_tidy_tests/rust_tidy.rs
* Improve containing block creation for position:absolute flowsMartin Robinson2017-08-171-0/+8
| | | | | | | | | | Instead of only promoting flows with positioned fragments to containing blocks, also do this for flows which have the transform, perspective or filter properties set. This is what the spec requires and also fixes some failing tests. It will allow us to stop creating stacking contexts for overflow:hidden and overflow:scroll flows. Fixes #18091.
* Rename compute_absolute_position to compute_stacking_relative_positionMatt Brubeck2017-08-081-2/+2
|
* Bug 1374233 - Part 5: Use NonNegativeLength and NonNegativeAu for ↵Boris Chiou2017-08-041-7/+7
| | | | | | | | | | border-spacing. We already have NonNegativeLength and NonNegativeAu, so we can re-use it to define the specified value and the computed value of border-spacing. And then implement ToAnimatedValue for it. MozReview-Commit-ID: CLckpKMYVXU
* Bug 1374233 - Part 2: Add NonNegativeAu.Boris Chiou2017-08-041-4/+4
| | | | | | | | | | | Add values::computed::NonNegativeAu, so BorderSideWith could be computed to this non-negative Au, for the following properties: 1. outline-width 2. border-{*}-width 3. column-rule-width 4. -webkit-text-stroke-width MozReview-Commit-ID: ASHaB2F7VtM
* Replace all uses of the style::stylearc alias with servo_arc.Michael Partheil2017-07-191-1/+1
| | | | | | The alias is left there temporarilly and will be removed completely in a later commit where also components/style/gecko/generated/structs_{debug|release}.rs are re-generated (they still use the old alias).
* stylo: Use ComputedValuesInner instead of ComputedValues when we don't need itManish Goregaokar2017-07-171-12/+12
|
* Make computed types hold Percentage instead of bare CSSFloatAnthony Ramine2017-06-151-1/+1
|
* Add separate computed Color value.Xidorn Quan2017-06-081-3/+2
|
* Fix up script and layout.Bobby Holley2017-05-021-2/+1
|
* Update serde to 0.9 (fixes #15325)Anthony Ramine2017-02-181-3/+3
|
* style: Unbox a bunch of color properties.Emilio Cobos Álvarez2017-02-141-6/+1
| | | | This builds on https://github.com/servo/rust-cssparser/pull/118.
* Remove cached thread local context from LayoutContextPu Xingyu2017-02-081-4/+4
| | | | | Remove cached thread local context from LayoutContext, use LayoutContext for assign_inline_sizes(), and simplify the parallel flow traversal code.
* Fix provenance of first cell's inline collapsed borderMatt Brubeck2017-01-241-1/+1
| | | | This fixes the inline-direction part of #14834.
* Rework the way scroll roots are collectedMartin Robinson2017-01-101-6/+2
| | | | | | | | | | | | Collect scroll roots during the collect_stacking_context phase instead of during display list construction. This will be useful in order to collect containing block scroll roots as well as to give scroll roots sequential ids in the future. This change also pulls stacking context children out of the StackingContext struct itself, which should reduce very slightly the memory used by the finished display list. This also simplifies the DisplayListBuilder because it no longer has to maintain a stack of ScrollRootIds and StackingContextIds and can instead just rely on the program stack.
* Fix rowspan handling for rows that span to the end of the rowgroupMatt Brubeck2016-12-301-1/+6
|
* Minor code cleanup in table_rowMatt Brubeck2016-12-141-8/+6
|
* Simplify propagation of column sizes from TableWrapperFlowMatt Brubeck2016-12-141-4/+0
|
* Account for rowspan in inline layout of table columns/cellsMatt Brubeck2016-12-141-9/+81
|
* Add the HTMLTableCellElement::rowspan propertyMatt Brubeck2016-12-141-0/+5
|
* Propagate column info to rows sequentiallyMatt Brubeck2016-12-091-3/+6
| | | | | | | | | This avoids storing it in the rowgroup (which doesn't need it) and ensures that it is done sequentially, which will be important when rowspan support is added to this function. Note that this does not reduce parallelism in the common case where all rows are in the same rowgroup.
* Remove unnecessary Flow::column_sizes methodsMatt Brubeck2016-11-301-8/+0
|
* Stop using associated types for the concrete TRestyleDamage implementation.Bobby Holley2016-11-071-1/+1
| | | | MozReview-Commit-ID: LfaZFCVlIb1
* Migrated -Z trace-layout to serde_jsonShing Lyu2016-11-071-8/+8
|
* Use a new id type for tracking scrolling areasMartin Robinson2016-10-301-2/+5
| | | | | | This is a step in disassociating scrolling areas from stacking contexts. Now scroll areas are defined by unique ids, which means that in the future stacking context will be able to contain more than one.
* layout: Refactor `Flow::from_fragment`-style constructors to bePatrick Walton2016-10-261-1/+1
| | | | consistent.
* Auto merge of #13401 - notriddle:master, r=pcwaltonbors-servo2016-09-291-1/+5
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement sequential fallback to float speculation This shouldn't impact any pages that are already rendering correctly, but it is a very naive implementation of this pass. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13284 and fix #13223 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13401) <!-- Reviewable:end -->
| * Implement sequential fallback to float speculationMichael Howell2016-09-271-1/+5
| | | | | | | | | | Fixes #13284 Fixes #13223
* | Simplify stacking context collectionMartin Robinson2016-09-271-6/+2
|/ | | | | | | | | | Simplify the way that stacking contexts are collected. Instead of passing the StackingContextId down the tree, pass the parent StackingContext itself. This will allow future patches to get more information about the parent stacking context (such as location). Also remove the return value of collect_stacking_contexts, which was unused.
* layout: Remove reflow damage after reflowing table rows.Patrick Walton2016-09-261-60/+72
|
* Handle row borders in border collapsing logic.Gabriel Poesia2016-08-301-5/+33
| | | | Fixes #11527.
* Pass SharedLayoutContext to Flow::compute_absolute_position.Ms2ger2016-08-241-2/+2
|
* Fix table vertical alignment (middle, bottom, not yet baseline) with ↵Adam Casey2016-07-261-0/+3
| | | | | | | differing height cells Includes reftest for this behaviour Patch fixes margin-collapse-clear-002,3,8,9
* Remove some type aliases that are now just re-exports.Simon Sapin2016-07-201-1/+1
|
* Remove the ComputedValue traits and style_struct_traitsSimon Sapin2016-07-201-1/+1
|
* Move util::print_tree to gfx_traitsAnthony Ramine2016-07-041-1/+1
|
* Pass SharedStyleContext to assign_inline_sizes.Ms2ger2016-06-221-4/+4
|
* Pass SharedStyleContext to propagate_assigned_inline_size_to_children.Ms2ger2016-06-221-1/+1
|
* Pass SharedStyleContext to compute_used_inline_size.Ms2ger2016-06-221-1/+2
|
* Remove unused argument to place_float_if_applicable.Ms2ger2016-06-201-1/+1
|