aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Auto merge of #29913 - mrobinson:mach-unicode-paths, r=atbrakhibors-servo2023-06-221-10/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow building on paths with Unicode characters This now works since the upgrade to Python 3, so we can remove this code which prevents mach from running in these situations. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #10002. - [x] These changes do not require tests because they just change build scripts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Allow building on paths with Unicode charactersMartin Robinson2023-06-221-10/+0
| | | | | | | | | | This now works since the upgrade to Python 3, so we can remove this code which prevents mach from running in these situations.
* | Auto merge of #25623 - nipunG314:25516, r=mrobinsonbors-servo2023-06-224-14/+22
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor ServoParser Tokenizer to return TokenizerResult As stated in #25516, this PR refactors the feed functions in the following files to return an Option instead of a Result: - components/script/dom/servoparser/async_html.rs - components/script/dom/servoparser/html.rs - components/script/dom/servoparser/xml.rs - components/script/dom/servoparser/mod.rs Originally, these functions were returning the Err values for situations that didn't actually result in an error. This PR fixes that. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25516 <!-- Either: --> - [X] These changes do not require tests because it is a refactor. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Refactor ServoParser Tokenizer to return TokenizerResultNipun Garg2023-06-224-14/+22
| |/
* | Auto merge of #29909 - mrobinson:mach-bootstrap-macos, r=mukilanbors-servo2023-06-224-6/+20
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Implement `./mach bootstrap` for MacOS <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they just change build scripts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Implement `./mach bootstrap` for MacOSMartin Robinson2023-06-224-6/+20
|/
* Auto merge of #29903 - mrobinson:improve-windows-build-instructions, r=mregobors-servo2023-06-223-237/+43
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify the build instructions in README.md - Add a chocolatey configuration that installs all dependencies and split the instructions into a normal and manual installation section. In addition fix a warning print statement for the Windows build that would trigger a Python exception. - Simplify the build instructions in the README and move all manual setup details to: https://github.com/servo/servo/wiki/Building <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Simplify the build instructionsMartin Robinson2023-06-213-237/+43
| | | | | | | | | | | | | | | | | | - Add a chocolatey configuration that installs all dependencies and split the instructions into a normal and manual installation section. In addition fix a warning print statement for the Windows build that would trigger a Python exception. - Simplify the build instructions in the README and move all manual setup details to: https://github.com/servo/servo/wiki/Building
* | Auto merge of #29899 - mrobinson:absolute-floats, r=Loirooriolbors-servo2023-06-2217-135/+114
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Properly position absolutes with static insets that are children of floats Previously, final float positions were calculated when their parents were positioned. This prevented proper positioning of absolute children of floats with static insets, because they accumulate offsets as they are hoisted up the tree. This change moves the final float positioning to `PlacementState::place_fragment` for the float itself so that it happens before any insets are updated for hoisted descendants. In addition to simplifying the code, this makes it a bit more efficient. Finally, floats are taken into account when updating static insets of hoisted boxes. Fixes #29826. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29826 - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Properly position absolutes with static insets that are children of floatsMartin Robinson2023-06-2217-135/+114
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, final float positions were calculated when their parents were positioned. This prevented proper positioning of absolute children of floats with static insets, because they accumulate offsets as they are hoisted up the tree. This change moves the final float positioning to `PlacementState::place_fragment` for the float itself so that it happens before any insets are updated for hoisted descendants. In addition to simplifying the code, this makes it a bit more efficient. Finally, floats are taken into account when updating static insets of hoisted boxes. Fixes #29826.
* | Auto merge of #29902 - Loirooriol:clearance-prevents-margin-collapse2, ↵bors-servo2023-06-217-24/+41
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=mrobinson Fix interaction of clearance with margin collapse In #29897 I did the simple naive thing, but it wasn't entirely correct. This patch tries to address the problems. In particular: - Clearance should prevent margins from collapsing through if it happens between them, as opposed to on the element that owns them. - The margins of an element with clearance can still collapse through, and collapse with other siblings as normal, but the resulting margin can't collapse with the bottom margin of the parent. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29896 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Fix interaction of clearance with margin collapseOriol Brufau2023-06-217-24/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #29897 I did the simple naive thing, but it wasn't entirely correct. This patch tries to address the problems. In particular: - Clearance should prevent margins from collapsing through if it happens between them, as opposed to on the element that owns them. - The margins of an element with clearance can still collapse through, and collapse with other siblings as normal, but the resulting margin can't collapse with the bottom margin of the parent.
* | | Auto merge of #29901 - mukilan:switch-nightly-to-2020-layout, r=mrobinsonbors-servo2023-06-212-18/+22
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Default nightly builds to layout 2020 This PR switches the filenames used by nightly builds so that the default `servo-latest.{ext}` packages use the 2020 engine and the 'servo-latest-legacy-layout.{ext}` packages use the 2013 engine. Since the platform workflows are reused by the main, quick-check, PR and WPT import flows and since the 2013/2020 flags are also controlled by try branches, I've kept the changes isolated to `nightly.yml` and `package_commands.py` and have avoided changing the input parameters. If we want to deault all the workflows to 2020, I can decline this PR and raise a new one. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they modify packaging logic.
| * | | Default nightly builds to layout 2020Mukilan Thiyagarajan2023-06-212-18/+22
| | | | | | | | | | | | | | | | Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
* | | | Auto merge of #29900 - mrobinson:fix-documentation, r=mukilanbors-servo2023-06-211-1/+1
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the rustdoc build after recent changes If passing --disable-minification, we must also enable unstable-options. This was happening before, but by accident. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are a build fix. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Fix the rustdoc build after recent changesMartin Robinson2023-06-211-1/+1
| | |/ | |/| | | | | | | | | | If passing --disable-minification, we must also enable unstable-options. This was happening before, but by accident.
* | | Auto merge of #29894 - mrobinson:ditch-static-position-closure, r=Loirooriolbors-servo2023-06-217-236/+175
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify layout of absolutes with static insets Absolutes with static insets need to be laid out at their ancestor containing blocks, but their position is dependent on their parent's layout. The static layout position is passed up the tree during hoisting and ancestors each add their own offset to the position until it is relative to the containing block that contains the absolute. This is currently done with a closure and a fairly tricky "tree rank" numbering system that needs to be threaded through the entire layout. This change replaces that system. Every time a child is laid out we create a positioning context to hold any absolute children (this can be optimized away at a later time). At each of these moments, we call a method to aggregate offsets to the static insets of hoisted absolutes. This makes the logic easier to follow and will also allow implementing this behavior for inline-blocks, which was impossible with the old system. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it should not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Simplify layout of absolutes with static insetsMartin Robinson2023-06-207-236/+175
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Absolutes with static insets need to be laid out at their ancestor containing blocks, but their position is dependent on their parent's layout. The static layout position is passed up the tree during hoisting and ancestors each add their own offset to the position until it is relative to the containing block that contains the absolute. This is currently done with a closure and a fairly tricky "tree rank" numbering system that needs to be threaded through the entire layout. This change replaces that system. Every time a child is laid out we create a positioning context to hold any absolute children (this can be optimized away at a later time). At each of these moments, we call a method to aggregate offsets to the static insets of hoisted absolutes. This makes the logic easier to follow and will also allow implementing this behavior for inline-blocks, which was impossible with the old system.
* | | Auto merge of #29897 - Loirooriol:clearance-prevents-margin-collapse, ↵bors-servo2023-06-2015-26/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r=mrobinson Prevent margins from collapsing through when separated by clearance This fixes #29884 and improves #29896. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29884 and improve #29896 - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Prevent margins from collapsing through when separated by clearanceOriol Brufau2023-06-2015-26/+3
| | | | | | | | | | | | | | | | This fixes #29884 and improves #29896.
* | | | Auto merge of #29895 - mrobinson:cleanup-rustdoc, r=jdmbors-servo2023-06-204-41/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up rustdoc run 1. The options specified in `rustdoc-with-private` are essentially the default now so we can remove this script. 2. `./mach browse-doc` is redundant with `./mach doc --open` which uses the underlying cargo functionality to browse the documentation. 3. `etc/rustdoc-style.html` is unused and can simply be removed. Fixes #29888. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29888 (GitHub issue number if applicable) - [x] These changes do not require tests because they just update build scripts. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | | Clean up rustdoc runMartin Robinson2023-06-204-41/+5
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. The options specified in `rustdoc-with-private` are essentially the default now so we can remove this script. 2. `./mach browse-doc` is redundant with `./mach doc --open` which uses the underlying cargo functionality to browse the documentation. Fixes #29888.
* | | | Auto merge of #29870 - mrobinson:float-root, r=Loirooriolbors-servo2023-06-208-31/+17
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout 2020: Correct rendering of floated root Fix two issues around floating a root element: 1. In the StackingContext code handle the case where a root element is a Float fragment and not a Box fragment. This fixes a debug assertion failure in the css/CSS2/float/float-root.html test. 2. When initializing the SequentialLayoutState, use the containing block width as the maximum inline float placement position instead of infinity. This fixes the rendering of css/CSS2/float/float-root.html. Note that css/CSS2/float/float-root.html was passing before, because both the test and reference were subject to the same bug. This fixes a couple other tests as well. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Correct rendering of floated rootMartin Robinson2023-06-208-31/+17
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix two issues around floating a root element: 1. In the StackingContext code handle the case where a root element is a Float fragment and not a Box fragment. This fixes a debug assertion failure in the css/CSS2/float/float-root.html test. 2. When initializing the SequentialLayoutState, use the containing block width as the maximum inline float placement position instead of infinity. This fixes the rendering of css/CSS2/float/float-root.html. Note that css/CSS2/float/float-root.html was passing before, because both the test and reference were subject to the same bug. This fixes a couple other tests as well.
* | | Auto merge of #29887 - Loirooriol:float-inline-size-complete, r=mrobinsonbors-servo2023-06-194-28/+112
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Handle floats in BlockContainer::inline_content_sizes Typically, block-level contents are stacked vertically, so this was just taking the maximum size among all contents. However, floats can be stacked horizontally, so we need to sum their sizes. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29874 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Handle floats in BlockContainer::inline_content_sizesOriol Brufau2023-06-194-28/+112
| |/ | | | | | | | | | | Typically, block-level contents are stacked vertically, so this was just taking the maximum size among all contents. However, floats can be stacked horizontally, so we need to sum their sizes.
* | Auto merge of #29890 - servo:wpt_update_18-06-2023, r=servo-wpt-syncbors-servo2023-06-18807-7631/+12421
|\ \ | |/ |/| | | | | | | | | | | Sync WPT with upstream (18-06-2023) Automated downstream sync of changes from upstream as of 18-06-2023 [no-wpt-sync] r? @servo-wpt-sync
| * Update web-platform-tests to revision ↵WPT Sync Bot2023-06-18807-7631/+12421
|/ | | | b'b31eaacb964b5e159b841d9eb18aa12e1d37867a'
* Auto merge of #29883 - Loirooriol:float-inline-size, r=mrobinsonbors-servo2023-06-1637-77/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement BlockLevelBox::inline_content_sizes for floats This improves #29874, but `BlockContainer::inline_content_sizes` will still need more changes in order to correctly handle sequences of floats. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Implement BlockLevelBox::inline_content_sizes for floatsOriol Brufau2023-06-1637-77/+3
| | | | | | | | | | This improves #29874, but BlockContainer::inline_content_sizes will still need more changes in order to correctly handle sequences of floats.
* | Auto merge of #29880 - mrobinson:fix-float-stacking-context-order, r=Loirooriolbors-servo2023-06-1621-38/+35
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't pass float stacking containers up to parent stacking contexts Don't pass up float stacking containers to parent stacking contexts Instead of passing up stacking containers created by floated content, keep them in their original parent stacking containers. This is in in line with specification text for stacking containers: > To paint a stacking container, given a box root and a canvas canvas: > > 1. Paint a stacking context given root and canvas, treating root as > if it created a new stacking context, but omitting any positioned > descendants or descendants that actually create a stacking context > (letting the parent stacking context paint them, instead). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Don't pass up float stacking containers to parent stacking contextsMartin Robinson2023-06-1621-38/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of passing up stacking containers created by floated content, keep them in their original parent stacking containers. This is in in line with specification text for stacking containers: > To paint a stacking container, given a box root and a canvas canvas: > > 1. Paint a stacking context given root and canvas, treating root as > if it created a new stacking context, but omitting any positioned > descendants or descendants that actually create a stacking context > (letting the parent stacking context paint them, instead).
* | | Auto merge of #29882 - mukilan:fix-windows-nightly, r=mrobinsonbors-servo2023-06-161-20/+28
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix windows nightly build failure PR #29865 changed the target directory for windows to be different from the source folder. However, the 'upload-nightly' command assumes the packages are stored in the default cargo target directory (./target), so the nightly jobs for windows were failing to find the packages. This PR fixes the 'upload-nightly' command to account for non-default target directories specified via CARGO_TARGET_DIR. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they fix a bug in packaging logic.
| * | | Fix windows nightly build failure.Mukilan Thiyagarajan2023-06-161-20/+28
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR #29865 changed the target directory for windows to be different from the source folder. However, the 'upload-nightly' command assumes the packages are stored in the default cargo target directory (./target), so the nightly jobs for windows were failing to find the packages. This PR fixes the 'upload-nightly' command to account for non-default target directories specified via CARGO_TARGET_DIR.
* | | Auto merge of #29877 - mrobinson:unegg-tidy, r=jdmbors-servo2023-06-1654-266/+68
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Convert tidy to a non-egg Python package It seems that servo-tidy is only used by webrender in my GitHub searches. WebRender could simply use `rustfmt` and the tidy on pypi hasn't been updated since 2018. Converting tidy to a normal Python package removes the maintenance burden of continually fixing the easy install configuration. Fixes #29094. Fixes #29334. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29094. - [x] These changes fix #29334. - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | | Convert tidy to a non-egg Python packageMartin Robinson2023-06-1554-266/+68
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that servo-tidy is only used by webrender in my GitHub searches. WebRender could simply use `rustfmt` and the tidy on pypi hasn't been updated since 2018. Converting tidy to a normal Python package removes the maintenance burden of continually fixing the easy install configuration. Fixes #29094. Fixes #29334.
* | | Auto merge of #29876 - mrobinson:update-float-docs, r=mregobors-servo2023-06-152-60/+64
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout 2020: Fix issues with float implementation documentation Fix some rustdoc comments which won't process properly unless they start with three '/' characters. In addition, improve the name of a function and add some missing documentation. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * | Layout 2020: Fix issues with float implementation documentationMartin Robinson2023-06-142-60/+64
| |/ | | | | | | | | | | Fix some rustdoc comments which won't process properly unless they start with three '/' characters. In addition, improve the name of a function and add some missing documentation.
* | Auto merge of #29873 - Loirooriol:import-assert, r=mrobinsonbors-servo2023-06-143-4/+14
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid assert failure when using @import <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #29872 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they only affect debug builds, and tests run in release builds. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Avoid assert failure when using @importOriol Brufau2023-06-143-4/+14
|/
* Auto merge of #29845 - mrobinson:floats-always-on, r=Loirooriolbors-servo2023-06-14135-315/+37
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Layout 2020: Remove the floats preference Enable floats always. It doesn't make sense to have this preference as it's a basic feature of an experimental layout engine. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Layout 2020: Remove the floats preferenceMartin Robinson2023-06-13135-315/+37
|/ | | | | Enable floats always. It doesn't make sense to have this preference as it's a basic feature of an experimental layout engine.
* Auto merge of #29848 - Loirooriol:sync, r=mrobinsonbors-servo2023-06-12143-8843/+2651
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport several style changes from Gecko (4) <!-- Please describe your changes on the following line: --> This continues https://github.com/servo/servo/pull/29816. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
| * Update test expectationsOriol Brufau2023-06-099-331/+0
| |
| * Avoid complaints from ./mach test-tidyOriol Brufau2023-06-091-0/+5
| |
| * style: Remove some no longer used use statementsEmilio Cobos Álvarez2023-06-091-1/+0
| | | | | | | | MANUAL PUSH: Bustage fix CLOSED TREE
| * style: Use atomic ops to read / write node flags from styloEmilio Cobos Álvarez2023-06-091-7/+24
| | | | | | | | | | | | | | The flags stylo cares about reading and writing potentially at the same time are disjoint, so there's no need for any strong memory ordering. Differential Revision: https://phabricator.services.mozilla.com/D141829
| * style: Put overflow: -moz-hidden-unscrollable behind a pref on NightlyEmilio Cobos Álvarez2023-06-091-2/+19
| | | | | | | | Differential Revision: https://phabricator.services.mozilla.com/D141759
| * style: Honor background-color: transparent in forced colors modeEmilio Cobos Álvarez2023-06-091-10/+11
| | | | | | | | | | | | | | | | | | | | See comment as for why, and linked bugs, in particular: https://bugzilla.mozilla.org/show_bug.cgi?id=1755713#c16 And the following screenshot for example. Differential Revision: https://phabricator.services.mozilla.com/D141514
| * style: Add support for parsing the `content-visibility` property from the ↵Martin Robinson2023-06-097-6/+44
| | | | | | | | | | | | | | | | | | CSS Contain specification Add initial parsing support for the CSS `content-visibility` attribute. Currently these parsed values have no effect. Differential Revision: https://phabricator.services.mozilla.com/D140834
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 18:53:08 +0000