aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* style: Move property allowance tests to PropertyId::parse_into.Emilio Cobos Álvarez2017-11-219-135/+137
| | | | | | | | | | | It's not only more consistent (since we have a proper ParserContext there), but also fixes a bunch of bugs where Gecko accidentally exposes and allows setting internal state because of conversions from nsCSSPropertyID to PropertyId. This adds the extra complexity of caring about aliases for longer, but that's probably not a big deal in practice, since we also have PropertyDeclarationId. MozReview-Commit-ID: C2Js8PfloxQ
* Auto merge of #19315 - emilio:chrome-rules-user-sheets, r=heycambors-servo2017-11-215-29/+52
|\ | | | | | | | | | | | | | | | | | | | | | | | | style: Enable chrome-only CSS features in user stylesheets. MozReview-Commit-ID: FJ4vTiOrotH Bug: 1418963 Reviewed-by: heycam <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19315) <!-- Reviewable:end -->
| * style: Enable chrome-only CSS features in user stylesheets.Emilio Cobos Álvarez2017-11-215-29/+52
| | | | | | | | | | | | MozReview-Commit-ID: FJ4vTiOrotH Reviewed-by: heycam Bug: 1418963
* | Auto merge of #19195 - wilsoniya:issue-16840, r=emiliobors-servo2017-11-217-27/+73
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: :dir() pseudo class now represented by enum `:dir()` pseudo class param now represented as enum variants. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #16840 - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19195) <!-- Reviewable:end -->
| * style: :dir() pseudo class now represented by enumMichael Wilson2017-11-157-27/+73
| | | | | | | | Fixes #19195
* | Auto merge of #19312 - aethanyc:use-computedurl, r=heycambors-servo2017-11-212-10/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: Use ComputedUrl instead of SpecifiedUrl in conversion.rs In stylo, ComputedUrl and SpecifiedUrl happen to be the same. However, using ComputedUrl can make code clearer that conversion.rs is for converting computed values between gecko and servo types. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19312) <!-- Reviewable:end -->
| * | style: Use ComputedUrl instead of SpecifiedUrl in conversion.rsTing-Yu Lin2017-11-212-10/+9
| | | | | | | | | | | | | | | | | | In stylo, ComputedUrl and SpecifiedUrl happen to be the same. However, using ComputedUrl can make code clearer that conversion.rs is for converting computed values between gecko and servo types.
* | | Auto merge of #19313 - heycam:layer-filling, r=CJKubors-servo2017-11-214-22/+27
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: Update layer filling function call in Gecko glue. This is the (small) Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1418899, reviewed there by CJKu. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19313) <!-- Reviewable:end -->
| * | | style: Regenerate Gecko bindings.Cameron McCormack2017-11-213-20/+25
| | | |
| * | | style: Update layer filling function call.Cameron McCormack2017-11-211-2/+2
| | | |
* | | | Auto merge of #19310 - servo:bumps, r=KiChjangbors-servo2017-11-201-22/+45
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update clap to 2.27.1 This brings bitflags 0.9.1 to clap, which removes bitflags 0.7.0. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19310) <!-- Reviewable:end -->
| * | | Update clap to 2.27.1Anthony Ramine2017-11-211-22/+45
| | | | | | | | | | | | | | | | This brings bitflags 0.9.1 to clap, which removes bitflags 0.7.0.
* | | | Auto merge of #19274 - Manishearth:xhr-cancel, r=jdmbors-servo2017-11-2012-31/+98
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fetch cancellation This PR implements cancellation for fetch, and uses it for XHR. This means that fetch clients can now send a message to the fetch task asking for the network request to be aborted. Previously, clients like XHR had abort functionality but would implement it by simply ignoring future messages from the network task; and would not actually cancel the network fetch. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19274) <!-- Reviewable:end -->
| * | | Add aborted flag to response, set when fetch is abortedManish Goregaokar2017-11-203-8/+21
| | | |
| * | | Fetch cancellation: Listen for cancellation and prematurely abort if cancelledManish Goregaokar2017-11-201-0/+6
| | | |
| * | | Fetch cancellation: Add CancellationListenerManish Goregaokar2017-11-204-10/+38
| | | |
| * | | Fetch cancellation: Send cancellation message whenever XHR needs to abort a ↵Manish Goregaokar2017-11-171-0/+6
| | | | | | | | | | | | | | | | fetch
| * | | Fetch cancellation: Store cancel_chan in XHRManish Goregaokar2017-11-171-3/+11
| | | |
| * | | Fetch cancellation: Add cancel_chan to FetchContextManish Goregaokar2017-11-1710-16/+22
| | | |
* | | | Auto merge of #19272 - jonleighton:issue-19171-2, r=jdmbors-servo2017-11-207-82/+150
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Further changes in relation to #19171 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19272) <!-- Reviewable:end -->
| * | | | Extract common text control selection codeJon Leighton2017-11-185-91/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The API for text control selection is the same for both <input> and <textarea>: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#textFieldSelection Before this change, they had similar but not identical implementations with duplicate code. Now there is a common TextControl trait which contains the implementation used by both. As a result, some previously failing tests now pass.
| * | | | Refactor selection-start-end testJon Leighton2017-11-183-16/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move assertions about the initial value of selection{Start,End} to their own tests. This ensures that when one of these assertions fails, it doesn't prevent other tests from being defined. Thus we have a clearer view of which tests are passing or failing, since all tests get defined regardless of which assertions fail.
* | | | | Auto merge of #18676 - gterzian:continue_http_cache_work, r=jdmbors-servo2017-11-2037-631/+1238
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Continue http cache work <!-- Please describe your changes on the following line: --> Work in progress, and not quite worth a review yet. (Continuation of https://github.com/servo/servo/pull/4117) TODO - [ ] cache metadata (find some subset of`net_traits::Metadata` that can be shared across threads, it seems the problem is mainly stuff inside `hyper::header` in the `headers` field) - [ ] determine which other fields of a `Response` need to be cached, so a full and valid one can be returned upon a cache hit. - [ ] determine how to best share the cache across fetch threads (inside HttpState like I tried now?) - [ ] Spend more time reading the spec and make sure the cache follows it where it matters. - [ ] Make the current wpt tests pass. - [ ] More... --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #12972 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18676) <!-- Reviewable:end -->
| * | | | add pref to disable http cache, mozilla testsGregory Terzian2017-11-196-0/+363
| | | | |
| * | | | also cache redirectsGregory Terzian2017-11-171-7/+5
| | | | |
| * | | | allow unknown HTTP methodsGregory Terzian2017-11-165-43/+1
| | | | |
| * | | | more http cache workGregory Terzian2017-11-1639-2136/+770
| | | | |
| * | | | pass cache_mode from request to request initGregory Terzian2017-11-151-0/+1
| | | | |
| * | | | copy headers from script request to net requestGregory Terzian2017-11-157-249/+9
| | | | |
| * | | | Beginnings of a http cacheJosh Matthews2017-11-1419-0/+1893
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doom cache entries based on the initial response, and prevent matching against doomed cache enties. Evict cache entries that have passed their expiry date instead of matching them. Document the cache. Refactor incomplete entries to lessen Option-itis. Revalidate expired cache entries instead of unconditionally evicting them. Forbid missing docs in cache code. Revalidate must-revalidate entries. Fetch content tests from a local HTTP server. Track requests made to the test HTTP server. Add a simple test that a cached resource with no expiry is not revalidated. Correct inverted expiry check in revalidation code. Fix incorrect revalidation logic that dropped the consumer channels on the floor. Ensure that requests are cached based on their request headers. Run a separate http server instance for each test to avoid intermittent failures due to concurrent cache tests. Add a test for uncacheable responses. Address review comments.
* | | | | Auto merge of #19305 - asajeffrey:test-perf-os-and-arch-in-data, r=jdmbors-servo2017-11-202-1/+11
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Include OS and architecture in test-perf data <!-- Please describe your changes on the following line: --> Initially, we're just running test-perf on linux-nightly, but at some point we should run on other architectures. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they're test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19305) <!-- Reviewable:end -->
| * | | | | Include OS and architecture in test-perf data.Alan Jeffrey2017-11-202-1/+11
| | | | | |
* | | | | | Auto merge of #19297 - emilio:hidden-props, r=upsuperbors-servo2017-11-202-5/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: Expose some properties to chrome code, and hide some accidentally-exposed ones. I'm adding a test for internal properties after this in Gecko. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19297) <!-- Reviewable:end -->
| * | | | | | style: Expose some properties to chrome code, and hide some ↵Emilio Cobos Álvarez2017-11-202-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | accidentally-exposed ones.
* | | | | | | Auto merge of #19304 - asajeffrey:test-perf-dash-dash-submit, r=jdmbors-servo2017-11-201-1/+1
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed mach test-perf -submit to --submit. <!-- Please describe your changes on the following line: --> The `-submit` option should be `--submit` (2 dashes, not one). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they are test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19304) <!-- Reviewable:end -->
| * | | | | | Renamed mach test-perf -submut to --submit.Alan Jeffrey2017-11-201-1/+1
| | | | | | |
* | | | | | | Auto merge of #19301 - servo:bumps, r=jdmbors-servo2017-11-201-16/+17
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update gecko-media The last remaining use of bitflags 0.7 is now in clap. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19301) <!-- Reviewable:end -->
| * | | | | | | Update gecko-mediaAnthony Ramine2017-11-201-16/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The last remaining use of bitflags 0.7 is now in clap.
* | | | | | | | Auto merge of #19245 - asajeffrey:test-perf-update-manifest, r=jdmbors-servo2017-11-203-5/+87
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update tp5n manifest for test-perf <!-- Please describe your changes on the following line: --> Updated test-perf tp5n manifest. This PR provides a `test.manifest` file, that contains a subset of the tp5n tests that don't timeout (at least on my machine). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because this is test infrastructure <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19245) <!-- Reviewable:end -->
| * | | | | | | | Update tp5n manifest for test-perf.Alan Jeffrey2017-11-163-5/+87
| | | | | | | | |
* | | | | | | | | Auto merge of #19270 - jdm:imagemapresults, r=noxbors-servo2017-11-204-91/+8
|\ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update expected results for hash-name-reference.html. These are stable expected results, and we missed them because the test is marked as intermittent in #16179. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19270) <!-- Reviewable:end -->
| * | | | | | | | Add expected failure for long-expressions-should-not-crash.html.Josh Matthews2017-11-201-0/+4
| | | | | | | | |
| * | | | | | | | Add expected failure for border_radius_elliptical_a.html.Josh Matthews2017-11-171-0/+3
| | | | | | | | |
| * | | | | | | | Update expected result for box-shadow-syntax-001.xht.Josh Matthews2017-11-171-1/+1
| | | | | | | | |
| * | | | | | | | Update expected results for hash-name-reference.html.Josh Matthews2017-11-171-90/+0
| | | | | | | | |
* | | | | | | | | Auto merge of #19303 - emilio:flattened-tree-fallback, r=heycambors-servo2017-11-201-2/+4
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: Account for fallback content in GetFlattenedTreeParent. Otherwise we may inappropriately style it or what not. This asserts with the patches of bug 1414999 plus the cleanup of bug 1418456, since we no longer do StyleNewChildren (which walks over the flattened tree children). Too bad that GetXBLBinding is a virtual call in Gecko, probably can do just MAY_BE_IN_BINDING_MGR... Bug: 1418560 Reviewed-by: heycam MozReview-Commit-ID: CNU0YdKeaR0 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19303) <!-- Reviewable:end -->
| * | | | | | | | | style: Account for fallback content in GetFlattenedTreeParent.Emilio Cobos Álvarez2017-11-201-2/+4
| | |_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise we may inappropriately style it or what not. This asserts with the patches of bug 1414999 plus the cleanup of bug 1418456, since we no longer do StyleNewChildren (which walks over the flattened tree children). Too bad that GetXBLBinding is a virtual call in Gecko, probably can do just MAY_BE_IN_BINDING_MGR... Bug: 1418560 Reviewed-by: heycam MozReview-Commit-ID: CNU0YdKeaR0
* | | | | | | | | Auto merge of #19298 - CYBAI:implement-normal-for-fontsettings, r=emiliobors-servo2017-11-203-16/+8
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement normal for FontSettings As discussed with emilio in #19293 , this PR will move the `normal` function into `FontSettings` implementation. r? emilio --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes will update the implementation of `normal` function of `FontSettings`. - [x] These changes do not require tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19298) <!-- Reviewable:end -->
| * | | | | | | | Implement normal for FontSettingsCYBAI2017-11-203-16/+8
|/ / / / / / / /
* | | | | | | | Auto merge of #19296 - emilio:bye-unstyled-only, r=heycambors-servo2017-11-204-81/+19
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | style: Get rid of unstyled children only traversals. They're useless now, provided we remove the hack to not traverse XBL-bound elements on initial styling. Bug: 1418456 Reviewed-by: heycam MozReview-Commit-ID: AvBVdyF1wb6 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19296) <!-- Reviewable:end -->
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-25 23:35:25 +0000