aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix inset box-shadow to use the padding box (#33433)Oriol Brufau2024-09-135-13/+4
| | | | | As specified in https://drafts.csswg.org/css-backgrounds-3/#shadow-shape Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* Simplify table logic in effective_overflow() (#33431)Oriol Brufau2024-09-131-33/+22
| | | | | | | | | | | | | On tables, we need to treat an overflow value of `scroll` or `auto` as `visible`. Both `scroll` or `auto` are scrollable, which implies that the other axis must also have a scrollable value. Therefore, when we make the value behave as the non-scrollable `visible`, we need to adjust the other axis too. The previous logic was checking `is_scrollable()` but that wasn't necessary, since computed values must have the same scrollability. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* Trace more functions by adding perfetto tracing events (#33417)atbrakhi2024-09-139-4/+116
| | | Signed-off-by: atbrakhi <atbrakhi@igalia.com>
* compositor: Do not allow script to scroll past maximum scroll node offsets ↵Martin Robinson2024-09-132-3/+10
| | | | | (#33428) Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* layout: `<th>` should have `text-align: center` when the child of an element ↵Martin Robinson2024-09-124-26/+18
| | | | | | | | | with `text-align: initial` (#33427) This behavir is enabled via a special CSS value that we can share with Gecko. Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
* Cleanup after #33396 (#33429)Oriol Brufau2024-09-127-19/+58
| | | | | | Mostly formatting improvements, but also recovering a pair of parenthesis that was accidentally removed, changing the logic. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* Add support for `table-layout: fixed` (#33384)Oriol Brufau2024-09-1220-129/+55
| | | | | | | More details might be needed to fully support the feature, but this covers the basic functionality. Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* Avoid crash with large table column widths (#33424)Oriol Brufau2024-09-122-14/+15
| | | | | Fixes #33423 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* Accept zero values on some `width`/`height` attributes on table elements ↵Oriol Brufau2024-09-127-35/+4
| | | | | | | | | (#33425) We were incorrectly using `AttrValue::from_nonzero_dimension` to parse some attributes, instead of `AttrValue::from_dimension`. Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* Add `width` and `height` presentational hints for table-related elements ↵Oriol Brufau2024-09-1216-228/+65
| | | | | | | | | | | | | | | (#33405) We were only parsing the `width` attribute as a presentation hint for `<table>`, `<td>` and `<th>`. This patch also handles `<colgroup>` and `<col>`. Also, we weren't parsing `height` at all, now we do it for `<table>`, `<td>`, `<th>`, `<tr>`, `<tbody>`, `<thead>` and `<tfoot>`. One test is now crashing, but this was an existing issue: #33423 Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* chore: Fix two compiler warnings (#33421)Martin Robinson2024-09-122-3/+6
| | | Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* Upgrade to html5ever 0.29 and xml5ever 0.20 (#33412)Nico Burns2024-09-124-28/+26
| | | | | | | | | | | | | * Upgrade html5ever and xml5ever Signed-off-by: Nico Burns <nico@nicoburns.com> * Upgrade stylo (minor bump for upgraded 5ever deps) Signed-off-by: Nico Burns <nico@nicoburns.com> --------- Signed-off-by: Nico Burns <nico@nicoburns.com>
* Make CanGc derive Copy and Clone (#33407)Taym Haddadi2024-09-1215-72/+61
| | | Signed-off-by: Taym <haddadi.taym@gmail.com>
* libservo: Improve finding python (#33385)Jonathan Schwender2024-09-122-43/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * libservo: Improve finding python Servo is built in a virtual environment, which sets `VIRTUAL_ENV` to the base path of the venv. PYTHON3 is only set if mach or the user set it. Additional changes: - Use Path / var_os for Paths instead of strings. In General using Path APIs is preferable, since in rare cases valid paths may not be valid utf-8. - Don't search for python 3.8 anymore, since we require a newer version anyway. - Don't add the .exe suffix anymore, since Command::new() will take care of that. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * script: Improve finding python Synchronize `find_python` in scripts build.rs with the version in libservo. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Apply suggestions from code review Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Fix finding venv python on windows - On Windows the venv scripts and python binaries are in the `Scripts` subdirectory instead of `bin`. - We shouldn't check if the executable in the venv binary dir exists, since the actual file could have a `.exe` suffix. We don't need to consider the `.exe` suffix for the filename, since `Command` will handle that for us. We also anyway check the validity of the candidate file, by running `$candidate --version`. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* webxr: Update XRInputSource Gamepad handling, FakeXRInputController (#33403)Daniel Adams2024-09-1211-29/+84
| | | | | | | | | | | | | | | | | | | | | * Disconnect XRInputSource gamepads on removal Signed-off-by: Daniel Adams <msub2official@gmail.com> * Update Cargo.lock Signed-off-by: Daniel Adams <msub2official@gmail.com> * Comments, adjustments Signed-off-by: Daniel Adams <msub2official@gmail.com> * Update expectations Signed-off-by: Daniel Adams <msub2official@gmail.com> --------- Signed-off-by: Daniel Adams <msub2official@gmail.com>
* Handle all `white-space` values when intrinsically sizing an IFC (#33343)Oriol Brufau2024-09-1110-45/+351
| | | | | | | | | | | There were various cases like `text-wrap-mode: nowrap` and `white-space-collapse: break-spaces` that weren't handled well. Fixes #33335 flexbox_flex-formatting-interop.html fails now because we don't support `table-layout: fixed`. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* Use raqote from crates.io and update canvas Cargo.toml (#33411)Alex Touchet2024-09-112-5/+6
| | | Signed-off-by: Alex Touchet <26315797+atouchet@users.noreply.github.com>
* mach: remove python2 compatibility code (#33410)Jonathan Schwender2024-09-117-25/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * util.py: Remove six We don't need to support python2 anymore, so we can just use `str(x)` instead of `six.ensure_str(x)` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * config.py: Remove six We don't need to support python2 anymore, so we can just use `str(x)` instead of `six.ensure_str(x)` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * main.py: Remove six We don't need to support python2 anymore, so we can just use `str(x)` instead of `six.ensure_str(x)` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * main.py: Fix `--settings` being ignored Previously `paths` was unused in this function, and the usage for the settings_file would have no effect. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * terminal.py: Remove `six` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * registrar.py: Remove `six` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * mach/util.py: Remove `six` Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * mach: Remove python2 from the list of programming languages Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
* layout: Reverse space-between alignment properly for absolute children of ↵Martin Robinson2024-09-112-16/+6
| | | | | | | | | flex containers (#33406) When aligning with `space-between` the space should be allocated on the `flex-end` side of the container ie it should be mapped to `flex-start` (`start` and reversing if necssary). Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* fix clean-cargo-cache command (#33408)Gae242024-09-111-1/+1
| | | Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
* Raf delivery: run rafs for all pipeline if tick received for any. (#33395)Gregory Terzian2024-09-113-12/+42
| | | | | | | | | | | | | * update the rendering: run rafs for all pipeline, if tick received for any Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com> * prioritize only one updating of the rendering per event-loop wake-up Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com> --------- Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com>
* Let table-related boxes adjust their `overflow` values (#33400)Oriol Brufau2024-09-116-17/+64
| | | | | | | | | | The `overflow` property doesn't apply to table track and track groups, and table elements only accept a few `overflow` values. Therefore, this patch adds an `effective_overflow()` method to get the actual value that needs to be used. Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* layout: Right-to-left support for other layout modes (#33375)Martin Robinson2024-09-1199-856/+935
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change removes the `effective_writing_mode` concept and tries to properly implement right-to-left layout support for all non-inline writing modes. In general, what needs to happen is that rectangles need to be converted to physical rectangles using the containing block. A right-to-left rectangle's inline start is on the right physical side of the containing block. Likewise a positive inline offset in right-to-left text is a negative physical one. The implementation here is pretty good for most layout modes, but floats are still a bit in process. Currently, floats are processed in the logical layout of the block container, but there still might be issues with float interaction with mixed RTL and LTR. While this does move us closer to supporting vertical writing modes, this is still unsupported. New failures: - Vertical writing mode not supported: - `/css/CSS2/floats/floats-placement-vertical-001b.xht` - `/css/CSS2/floats/floats-placement-vertical-001c.xht` - Absolutes inlines should avoid floats (#33323) - `/css/css-position/position-absolute-dynamic-static-position-floats-004.html` - No support for grid - `/css/css-align/self-alignment/self-align-safe-unsafe-grid-003.html` - `/css/css-position/static-position/inline-level-absolute-in-block-level-context-009.html` - `/css/css-position/static-position/inline-level-absolute-in-block-level-context-010.html` - Cannot reproduce these locally on any platform. Very mysterious: - `/css/css-tables/row-group-margin-border-padding.html` - `/css/css-tables/row-margin-border-padding.html` - Exposes bugs we have related to hanging whitespace in preserved whitespace inlines: - `/css/css-text/white-space/trailing-space-and-text-alignment-rtl-003.html` - `/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-023.html` Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com>
* Stop using `time@0.1` in Servo (#33394)Martin Robinson2024-09-1118-103/+88
| | | | | | | | This removes the last few uses of `time@0.1` in Servo. There are still dependencies from `style` and `webrender`, but they will be removed soon as well. The uses of this version of `time` are replaced with `std::time` types and `time@0.3` when negative `Duration` is necessary. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* layout: Use `Au` in `ComputedValuesExt` (#33396)atbrakhi2024-09-1013-272/+240
| | | | | | | | | | | | | | | | | | | | * Use app unit in `ComputedValuesExt` Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: atbrakhi <atbrakhi@igalia.com> * Some miscellaneous fixes Signed-off-by: Martin Robinson <mrobinson@igalia.com> * remove redundant defination of `containing_block_inline_size` Signed-off-by: atbrakhi <atbrakhi@igalia.com> --------- Signed-off-by: atbrakhi <atbrakhi@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* Align Servo version between user agent string and servoshell about dialog ↵Taym Haddadi2024-09-101-18/+30
| | | | | | | | | | | | | | | (#33398) * Align Servo version between Agen and About screen for consistency Signed-off-by: Taym <haddadi.taym@gmail.com> * Improve passing servo_version to desktop_ua_string Signed-off-by: Taym <haddadi.taym@gmail.com> --------- Signed-off-by: Taym <haddadi.taym@gmail.com>
* Make Crashtests with test-wait wait (#33344)Taym Haddadi2024-09-1019-3/+48
| | | | | | | | | | | | | | | | | * Make Crashtests with test-wait wait Signed-off-by: Taym <haddadi.taym@gmail.com> * use Atom::from instead of the atom macro Signed-off-by: Taym <haddadi.taym@gmail.com> * Update test result expectations Signed-off-by: Taym <haddadi.taym@gmail.com> --------- Signed-off-by: Taym <haddadi.taym@gmail.com>
* Allow breaking line after space with `white-space: break-spaces` (#33376)Oriol Brufau2024-09-103-4/+40
| | | | | | | | | | | | | | `white-space: break-spaces` should allow a soft wrap opportunity *after* every preserved white space. Then, to avoid breaking before the first white space, `TextRunSegment::shape_text()` has some logic to separate it from the following spaces and put it with the preceding text instead. The problem was that, when combined with `word-break: keep-all`, we were then only checking whether there were more white spaces afterwards, ignoring the soft wrap opportunity after the first one. Also removing a duplicated `can_break_anywhere` variable. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* Plumb selected tracing spans into hitrace (#33324)Delan Azabani2024-09-107-11/+162
| | | | | | | | | | | | | | | | | * Plumb selected tracing spans into hitrace Signed-off-by: Delan Azabani <dazabani@igalia.com> * Tag the spans in #33189 with the `servo_profiling` field Signed-off-by: Delan Azabani <dazabani@igalia.com> * Add comment about fields vs extensions Signed-off-by: Delan Azabani <dazabani@igalia.com> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com>
* CI: fix self-hosted runners in Linux builds (#33389)Delan Azabani2024-09-101-1/+1
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* script: fixed document title being set to Some("") instead of None (#33354)Ben2024-09-101-26/+30
| | | | | | | | | | | | | | | | * Fixed document title being set to "" instead of None Signed-off-by: Benjamin Vincent Schulenburg <bennyschulenburg@gmx.de> * Update components/script/dom/document.rs Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Ben <bennyschulenburg@gmx.de> --------- Signed-off-by: Benjamin Vincent Schulenburg <bennyschulenburg@gmx.de> Signed-off-by: Ben <bennyschulenburg@gmx.de> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* Fallback to the url if a tabs title is empty (#33391)Ben2024-09-101-2/+2
| | | Signed-off-by: Benjamin Vincent Schulenburg <bennyschulenburg@gmx.de>
* Fix reordering of table-header-group and table-footer-group (#33383)Oriol Brufau2024-09-096-84/+121
| | | | | | | | | | | | | | | We weren't moving a table-header-group to the front if it was the first row group. However, there might still be preceding rows that don't belong to any row group. And similarly, we weren't moving a table-footer-group to the end if it was the last row group. However, there might still be following rows that don't belong to any row group. This patch fixes the logic, and enables existing tests from Microsoft that were missing a reference. Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* Send less title changes to the embedder (#33287)webbeef2024-09-091-3/+28
| | | | | | | | Instead of sending a title change for each incremental parsing change, we now do it when: - the element is bound to the tree. - the parser is done with the element (in pop()). - the title content changes after the parsing, eg. using document.title . Signed-off-by: webbeef <me@webbeef.org>
* Propagate `CanGc` from `Document::new()` (#33386)Andriy Sultanov2024-09-0941-393/+704
| | | | | | | | | | | | | * Add canGc as a parameter to autogenerated trait methods Signed-off-by: Andriy Sultanov <sultanovandriy@gmail.com> * Propagate CanGc from Document::new() Signed-off-by: Andriy Sultanov <sultanovandriy@gmail.com> --------- Signed-off-by: Andriy Sultanov <sultanovandriy@gmail.com>
* Initial support for `<link rel="prefetch">` (#33345)Simon Wülker2024-09-0911-183/+532
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Properly store link relations Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Send fetch request for prefetch links We don't actually *do* anything with the response yet (handle errors etc) but its a first step. Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Fire load/error events for prefetch loads Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Set prefetch destination/cors setting correctly Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Update WPT expectations Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Fix ./mach test-tidy errors Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Set correct "Accept" value for prefetch requests Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Add spec text to individual steps Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
* script: Added missing spec step in `Location::SetHash` (#33380)Cristian Brinza2024-09-094-6/+64
| | | | | | | | | | | | | | | | | * Implement missing spec step in Location::SetHash Signed-off-by: crbrz <cristianb@gmail.com> * Fixed wrong URL fragment when hash set to empty string Signed-off-by: crbrz <cristianb@gmail.com> * Add WPT tests Signed-off-by: crbrz <cristianb@gmail.com> --------- Signed-off-by: crbrz <cristianb@gmail.com>
* implement `console.timeLog` (#33377)Simon Wülker2024-09-096-54/+34
| | | | | | | | | | | | | * Implement console.timeLog Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> * Adjust WPT expectations Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
* Fix devtool crashs after entering window.location in console (#33381)Taym Haddadi2024-09-091-1/+6
| | | Signed-off-by: Taym <haddadi.taym@gmail.com>
* layout: Implement proper absolute child position for flexbox (#33346)Martin Robinson2024-09-0920-693/+647
| | | | | | | | | | | This implements the requirements outlined in the [flexbox specification] about how to position absolute children of flex containers. We must establish a static position rectangle (to use if all insets are auto) and also align the child into that rectangle. [flebox specification]: https://drafts.csswg.org/css-flexbox/#abspos-items Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
* script: Implement `TextEncoder::encodeInto()` (#33360)webbeef2024-09-094-280/+66
| | | | | | | | | | | | | | | | | | | * Implement TextEncoder::encodeInto() Signed-off-by: webbeef <me@webbeef.org> * Update components/script/dom/textencoder.rs Signed-off-by: Martin Robinson <mrobinson@igalia.com> * Update components/script/dom/textencoder.rs Signed-off-by: Martin Robinson <mrobinson@igalia.com> --------- Signed-off-by: webbeef <me@webbeef.org> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* android: make aarch64 the default target (#33379)Mukilan Thiyagarajan2024-09-092-3/+3
| | | Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* script: Use `time@0.3` for input elements and do conversion in a &str trait ↵Martin Robinson2024-09-095-481/+527
| | | | | | | | | | | | | | | | | (#33355) This changes converts all input element parsing and normalization to use `time` instead of `chrono`. `time` is used by our dependencies, so it makes sense to work toward removing the Servo dependency on chrono. In addition, parsing and normalization also moves to a trait on &str to prepare for the possibility of all script parsers moving to a separate crate that can have unit tests written against it. Code duplication is eliminated when possible and more conversion is done using integer types. These two things together mean we pass more tests now. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* webgpu: Factor out swapchain to separate file (#33367)Samson2024-09-099-328/+403
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move some stuff to swapchain.rs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Use typed WebGPUContextId instead of u64 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Extract create_swapchain function and move more stuff in it Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * extract destroy_swapchain Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * extract swapchain_present Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * extract update_wr_image callback Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * fixup Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* webxr: Update XRInputSource gamepad index to be -1 (#33369)Daniel Adams2024-09-095-6/+14
| | | | | | | | | | | | | * Update XRInputSource gamepad index to be -1 Signed-off-by: Daniel Adams <msub2official@gmail.com> * Update test expectations Signed-off-by: Daniel Adams <msub2official@gmail.com> --------- Signed-off-by: Daniel Adams <msub2official@gmail.com>
* CI: fix self-hosted runners in try-label builds (#33373)Delan Azabani2024-09-092-2/+2
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* Remove unused imports (#33371)Oriol Brufau2024-09-092-3/+3
| | | Signed-off-by: Oriol Brufau <obrufau@igalia.com>
* CI: use self-hosted runners for Linux build jobs (#33321)Delan Azabani2024-09-084-104/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * CI: use self-hosted runners for Linux build jobs Signed-off-by: Delan Azabani <dazabani@igalia.com> * Set ccache and incremental env variables when not self-hosted Signed-off-by: Delan Azabani <dazabani@igalia.com> * Force GitHub-hosted runner when in upload mode Signed-off-by: Delan Azabani <dazabani@igalia.com> * Revert s/python/python3/ now that our image has python Signed-off-by: Delan Azabani <dazabani@igalia.com> * Remove stray comment in timeout workflow Signed-off-by: Delan Azabani <dazabani@igalia.com> * Update description of runner-select job Signed-off-by: Delan Azabani <dazabani@igalia.com> * Apply suggestions from code review Address couple minor naming / formatting nits Signed-off-by: Martin Robinson <mrobinson@igalia.com> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* tidy: Fix rustdoc warnings and add a tidy check for a common URL issue (#33366)Martin Robinson2024-09-0819-36/+107
| | | | | | | | This change fixes all rustdoc errors and also adds a tidy check for a very common rustdoc URL issue. Eventually rustdoc warnings should likely cause the build to fail, but this catches those issues sooner in order to not waste so much developer time. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* net: use saturating_sub when substracting durations to prevent underflows ↵webbeef2024-09-084-5/+39
| | | | | | | | | | | | | | | | | | | (#33341) * net: use saturating_sub when substracting durations to prevent underflows Signed-off-by: webbeef <me@webbeef.org> * Add regression test. (#1) * Add regression test. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: webbeef <me@webbeef.org> Signed-off-by: Josh Matthews <josh@joshmatthews.net> Co-authored-by: Josh Matthews <josh@joshmatthews.net>
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-28 19:01:25 +0000