aboutsummaryrefslogtreecommitdiffstats
path: root/.github/workflows
Commit message (Collapse)AuthorAgeFilesLines
* Use try-parser in main workflow (#34146)Samson2024-11-201-47/+38
| | | | | this allows us to have fail-fast in MQ Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* ohos: Add basic IME and keyboard support (#34188)Jonathan Schwender2024-11-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ohos: Add basic IME and keyboard support - Add extremely basic support for keyboard events - Add basic IME support - Showing and hiding the IME - inserting text - deleting characters - very basic configuration of the IME Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Apply suggestions from code review Improve the log message Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> * Update ports/servoshell/egl/ohos.rs Co-authored-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> * ohos: Bump the minimum required SDK version to 5.0 Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * ohos: Remove pub from callbacks The callbacks don't need to be public, as we will be registering them. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Rename composition event Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * ohos: clippy in log Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * ohos: address some clippy warnings Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * ohos: Raise Error in mach if unsupported SDK version is used. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Add keyboard-types dependency for android Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> --------- Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> Co-authored-by: Josh Matthews <josh@joshmatthews.net> Co-authored-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com>
* CI: Fix lint job (#34257)Jonathan Schwender2024-11-151-0/+2
| | | | | cargo-deny 0.16.2 requires Rust 1.81, so we install the previous version Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
* CI: use new intermittent-tracker deployment (#34068)Delan Azabani2024-11-041-0/+2
| | | | | | | | | | | | | | | | | * CI: use new intermittent-tracker deployment Signed-off-by: Delan Azabani <dazabani@igalia.com> * Plumb new secrets into linux-wpt.yml environment Signed-off-by: Delan Azabani <dazabani@igalia.com> * Print effective dashboard URL in WPT runner Signed-off-by: Delan Azabani <dazabani@igalia.com> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com>
* Bigger timeout for mac unit tests (#34130)Samson2024-11-041-1/+1
| | | | | I noticed that in practice it takes about ~30min to run unit tests. Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
* ci: pin python to 3.12 for mac workflows (#34022)Mukilan Thiyagarajan2024-10-262-0/+10
| | | | | | | | | | | | | | | wptrunner breaks macos builds because it doesn't work well with 3.13 due to two issues: 1. The current version (10.3.0) of the 'pillow' dependency of wptrunner breaks with >=3.13 and needs to be upgraded. 2. Python 3.13 has removed the 'cgi' module which was deprecated in 3.11 and has no direct replacement. There are two files in wptrunner that use the cgi module and one of them is the vendored 'html5lib'. As a quick fix, pin the Python version on MacOS runner until web-platform-tests/wpt#48585 is addressed. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* CI: Fail the lint job when cargo-clippy reports some warnings (#33941)tanishka2024-10-211-2/+1
| | | | | | | | | | | | | | | | | | | * Fail the lint job when cargo-clippy reports some warnings Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com> * Remove todo comment Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com> * clippy: use Option::take instead of mem::replace Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> --------- Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com> Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* ci: Fix the WPT export job again by removing `--break-system-packages` (#33874)Martin Robinson2024-10-161-1/+1
| | | Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* CI: temporarily disable self-hosted runners for nightly.yml (#33834)Delan Azabani2024-10-143-1/+20
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* CI: pin ubuntu 22.04 in WPT Import (#33823)Samson2024-10-131-1/+1
| | | Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
* CI: Bump setup-ohos-sdk to v0.1.4 (#33739)Jonathan Schwender2024-10-131-6/+1
| | | | | | | | | | | | | | | | | * CI: Bump setup-ohos-sdk to v0.1.4 v0.1.3 had a bug when the SDK was restored from cache. This was fixed upstream, andcache-hit behavior is now also tested in upstream CI. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * CI: Use major tag again for setup-ohos-sdk Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
* ohos: publish nightly builds (#33801)Mukilan Thiyagarajan2024-10-112-11/+50
| | | Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* Use `--break-system-packages` when running pip in the WPT export job (#33749)Martin Robinson2024-10-091-1/+1
| | | | | | | This seems to be necessary now, in much the same way it is necessary on a normal Ubuntu system. I'm not sure what changed that this is now required. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* ci: pin the ubuntu runner version in lint job. (#33755)Mukilan Thiyagarajan2024-10-091-1/+1
| | | | | | | | Github has updated the `ubuntu-latest` label to use 24.04, but that breaks the lint job. Since the build job (github hosted and self hosted runners) still explicitly use 22.04, pin the same version for lint job until we upgrade all the workflows together. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* ohos: pin version of setup-ohos-sdk action to fix CI (#33719)Mukilan Thiyagarajan2024-10-081-1/+5
| | | | | | | | | | | | The most recent [v0.1.3] release seems to not set the expected OHOS_SDK_NATIVE and OHOS_BASE_SDK_HOME environment variables. This is causing the OHOS builds to fail in CI and blocking the merge queue. This change pins he action to the last known good version until the error can be addressed upstream. Fixes #33712. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* CI: increase self-hosted runner timeout from 30 to 120 seconds (#33596)Delan Azabani2024-10-011-1/+1
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* Bump sccache-action to v0.0.6 (#33566)Jonathan Schwender2024-09-275-5/+5
| | | | | | | | | | | | Interesting changes since v0.0.4 - fix: avoid downloading package when local cache exists in https://github.com/Mozilla-Actions/sccache-action/pull/123 - Output sccache stats as a notice and a summary table in https://github.com/Mozilla-Actions/sccache-action/pull/113 v0.0.6 changelog: https://github.com/Mozilla-Actions/sccache-action/releases/tag/v0.0.6 v0.0.5 changelog: https://github.com/Mozilla-Actions/sccache-action/releases/tag/v0.0.5 Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
* openharmony: add servoshell for ohos (#33295)Mukilan Thiyagarajan2024-09-202-0/+36
| | | | | | | | | | | | | * openharmony: add servoshell for ohos Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> * ohos: handle missing signing config on forks Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> --------- Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* CI: fix self-hosted runner timeout detection (#33471)Delan Azabani2024-09-173-3/+3
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* android: publish nightly builds for aarch64 (#33435)Mukilan Thiyagarajan2024-09-162-8/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * android: publish nightly builds for aarch64 Publish the aarch64 apk and aar packages to both Github Releases and S3 so that it can be linked from servo.org. The focus is on getting a working version of the APK on the homepage, so few issues are resolved with temporary solutions: 1) We publish the "release" profile instead of "production" since the latter will need changes in the gradle configuration (the changes required was previously blocked on #32720 which is now closed). 2) The scheme for the version code is simple and doesn't consider other factors such as API level and product variants discussed in the Android docs (https://developer.android.com/google/play/publishing/multiple-apks#VersionCodes) This should be fine for now as we don't publish to any store yet. The change also makes it so that the 'Release nightly' workflow will endup building all 4 variants for the Android target, but only aarch64 is uploaded. This is because GH Actions doesn't have a good way to skip a specific job in a matrix and the additionally code complexity needed to acheive it (either generating a JSON dynamically in a new job and using `fromJSON` in the matrix definition or skipping each individual step based on matrix.target and `inputs.upload`) didn't seem worth the cost saved (this is executed only once a day). Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> * android: add attestation for nightly build artifacts Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> --------- Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* CI: fix self-hosted runners in Linux builds (#33389)Delan Azabani2024-09-101-1/+1
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* CI: fix self-hosted runners in try-label builds (#33373)Delan Azabani2024-09-092-2/+2
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* CI: use self-hosted runners for Linux build jobs (#33321)Delan Azabani2024-09-084-104/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * CI: use self-hosted runners for Linux build jobs Signed-off-by: Delan Azabani <dazabani@igalia.com> * Set ccache and incremental env variables when not self-hosted Signed-off-by: Delan Azabani <dazabani@igalia.com> * Force GitHub-hosted runner when in upload mode Signed-off-by: Delan Azabani <dazabani@igalia.com> * Revert s/python/python3/ now that our image has python Signed-off-by: Delan Azabani <dazabani@igalia.com> * Remove stray comment in timeout workflow Signed-off-by: Delan Azabani <dazabani@igalia.com> * Update description of runner-select job Signed-off-by: Delan Azabani <dazabani@igalia.com> * Apply suggestions from code review Address couple minor naming / formatting nits Signed-off-by: Martin Robinson <mrobinson@igalia.com> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* CI: use monitor API for self-hosted runners (#33315)Delan Azabani2024-09-041-37/+15
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* CI: Force github hosted runners and remove concurrency on select-runner job ↵Samson2024-09-041-3/+6
| | | | | | | (#33308) temporary fix for #33276 Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
* Hack around DCO not in MQ (#33290)Samson2024-09-031-0/+12
| | | | | See https://github.com/servo/servo/pull/33283#issuecomment-2325240423 Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
* CI: label self-hosted runners with run id to aid debugging (#33283)Delan Azabani2024-09-031-0/+1
| | | Signed-off-by: Delan Azabani <dazabani@igalia.com>
* CI: use self-hosted runners for Windows build jobs (#33081)Delan Azabani2024-08-271-14/+165
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * CI: use self-hosted Windows runners in main workflow Signed-off-by: Delan Azabani <dazabani@igalia.com> * Fix a couple of robustness issues by generating a unique build id Signed-off-by: Delan Azabani <dazabani@igalia.com> * Work around needs-context expressions being busted in concurrency Signed-off-by: Delan Azabani <dazabani@igalia.com> * CI: use self-hosted Windows runners in try and try-label workflows Signed-off-by: Delan Azabani <dazabani@igalia.com> * Rename windows workflow back for simplicity Signed-off-by: Delan Azabani <dazabani@igalia.com> * Clarify why the copy resources step is for GitHub-hosted jobs only Signed-off-by: Delan Azabani <dazabani@igalia.com> * Fix cancelled status problem by dispatching instead of calling Signed-off-by: Delan Azabani <dazabani@igalia.com> * Tweak retry strategy to avoid hitting REST API rate limits Signed-off-by: Delan Azabani <dazabani@igalia.com> * Update dispatch-workflow.yml accordingly Signed-off-by: Delan Azabani <dazabani@igalia.com> * Rework to use simpler approach with runner labels Signed-off-by: Delan Azabani <dazabani@igalia.com> * Use org-scoped self-hosted runners Signed-off-by: Delan Azabani <dazabani@igalia.com> * Don’t run runner-timeout job when GitHub-hosted runner is selected Signed-off-by: Delan Azabani <dazabani@igalia.com> * Downgrade to Python 3.10 Signed-off-by: Delan Azabani <dazabani@igalia.com> * Avoid failing when RUNNER_API_TOKEN is missing (such as in forks) Signed-off-by: Delan Azabani <dazabani@igalia.com> * Fix undefined needs output when RUNNER_API_TOKEN is missing Signed-off-by: Delan Azabani <dazabani@igalia.com> * Reset working tree, in case it was dirty in the runner image Signed-off-by: Delan Azabani <dazabani@igalia.com> * Clearer runner assignment timeout jobs that fail and offer help Signed-off-by: Delan Azabani <dazabani@igalia.com> * Fix some other sources of incremental build breakage (but not PATH) Signed-off-by: Delan Azabani <dazabani@igalia.com> * Log reasons why we fall back to GitHub-hosted runners Signed-off-by: Delan Azabani <dazabani@igalia.com> * Allow self-hosted runners to be disabled via repository variable Signed-off-by: Delan Azabani <dazabani@igalia.com> * Always install crown, even on self-hosted runners Signed-off-by: Delan Azabani <dazabani@igalia.com> * Rename incremental build debugging step Signed-off-by: Delan Azabani <dazabani@igalia.com> * Clean up job friendly names Signed-off-by: Delan Azabani <dazabani@igalia.com> * Reduce fetch depth, now that this job no longer lints Signed-off-by: Delan Azabani <dazabani@igalia.com> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com>
* mach: introduce `BuildTarget` abstraction (#33114)Mukilan Thiyagarajan2024-08-261-1/+1
| | | | | | | | | | | | | | | | Introduce a new `BuildTarget` abstraction to centralize the code for supporting different ways of choosing the build target (e.g --android, --target x86_64-linux-android , --target aarch64-linux-ohos). This is currently handled in an adhoc fashion in different commands ( mach package, install, run) leading to a proliferation of keyword parameters for the commands and duplicated logic. The patch introduces a new `allow_target_configuration` decorator to do the validation and parsing of these parameters into the appropriate `BuildTarget` subclass, which is now stored as an instance attribute of the CommandBase class. All the code that previously relied on `self.cross_compile_target` has been switched to use the BuildTarget. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* CI: Add separate Lint&Tidy check and remove test-tidy from linux (#33150)Samson2024-08-2310-76/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Create separate Lint&Tidy check Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Remove quick-check as it's not longer relevant Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Add clippy to rust-toolchain Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * fix try parser test expectations Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * use lint in result Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Lint & Tidy -> Lint Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com> --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* wpt-tests-to-run -> wpt-args and make them last so they can override already ↵Samson2024-08-197-20/+21
| | | | | | | provide (#33115) d options Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
* ohos: Fix x86_64-unknown-linux-ohos (#33029)Jonathan Schwender2024-08-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | * ohos: Fix compilation for x86_64 Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * ohos: Use the SDK compiler-wrapper When compiling for x86_64-unknown-linux-ohos without the compiler wrapper, for some reason mozjs_sys will be refercing a wrong mangled symbol resulting in the following error when loading the .so at runtime: ``` _ZNSt3__111this_thread9sleep_forERKNS_6chrono8durationIxNS_5ratioILl1ELl1000000000EEEEE: symbol not found ``` This problem does not occur when compiling for aarch64 or when using the compiler wrapper. In this case the correct symbol `_ZNSt4__n111this_thread9sleep_forERKNS_6chrono8durationIxNS_5ratioILl1ELl1000000000EEEEE` is referenced. It's unclear why manually passing the flags via CFLAGS / CXXFLAGS does not work. Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> --------- Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
* ci: Only export WPT test changes on the `main` branch (#33033)Martin Robinson2024-08-131-0/+1
| | | | | | | This ensures that the WPT export job only runs on chnages that target the `main` branch. This makes it so changes to WPT tests in temporary branches aren't upstreamed. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* ci: allow android builds on forks to skip keystore configuration (#32927)Mukilan Thiyagarajan2024-08-041-0/+1
| | | | | | | | | Our build.gradle configuration already defaults to using the debug keystore when the keystore is not configured so only the CI needs this fix. Fixes #32922 Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* Free some space on android runners (#32907)Samson2024-08-011-0/+7
| | | Signed-off-by: Samson <16504129+sagudev@users.noreply.github.com>
* Update mozjs (SpiderMonkey) to 128.0 (#32769)Samson2024-07-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update mozjs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Fix changed readTransfer callback https://bugzilla.mozilla.org/show_bug.cgi?id=1842713 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Use NewExternalArrayBuffer from glue https://github.com/servo/mozjs/pull/474/commits/d33454be74ec5b8d8faf51fab3ed477b8913898b Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Fix columnorigin and filename being in latin1 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * fixup newexternalarray Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Float16 (this might require more work for codegen support) https://bugzilla.mozilla.org/show_bug.cgi?id=1833647 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * js.strict is removed https://bugzilla.mozilla.org/show_bug.cgi?id=1621603 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * asm options are now somewhere else https://hg.mozilla.org/mozilla-central/rev/26045c88e3972957087d535e7f259e08857bd2a2 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Comment out offthread compilation Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Set NDK to 26 Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Fix 1-origin handling Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Expect `FinalizationRegistry` interface Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Good expectations Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * more expectations Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Add `WeakRef` to interfaces expectation Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * mozjs upgrade: fixes for Android Android NDK's layout has changed in r26 and 'lib64' no longer exists under `toolchain/llvm/prebuilt/linux-x86_64`. The libraries that used to be it are now present in `lib` folder itself. This patch updates the build configuration to use the `lib` folder instead when configuring the LIBCLANG_PATH environment variable. This patch also updates to a newer mozjs version that includes fixes for linker errors faced on Android (see #32769). Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> * Patch libz-sys & update mozjs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * update NDK version in README Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> * Use servo/mozjs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Update mozjs again Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* Auto merge all WPT and dependabot PRs (#32775)Samson2024-07-152-22/+18
| | | | | | | | | | | | | | | * Auto merge all WPT and dependabot PRs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> * Adjust name of action Signed-off-by: Martin Robinson <mrobinson@igalia.com> --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* ci: fix security issue in try job workflow (#32724)Mukilan Thiyagarajan2024-07-086-16/+13
| | | | | | | | | | | | | | | | This [issue][1] was reported by GitHub user @RedYetiDev via the Security Advisory reporting mechanism on GitHub. The fix is also based on their proposed solution. The issue is that `refs/pull/{pr_number}/head` points to the latest commit of a PR and so it could be different than the commit that was reviewed when the try label was applied. The fix is to use the exact commit sha at the point when the try job is triggered, which is available in the `github` context as `github.event.pull_request.head.sha`. [1]: https://github.com/servo/servo/security/advisories/GHSA-fxqr-xgh8-3577 Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
* android: sign release APK with a custom key. (#32721)Mukilan Thiyagarajan2024-07-081-0/+10
| | | | | | | | | | | This PR adds support for signing all APKs we produce on the CI with a custom signing key. Currently the logic falls back to the debug key (which is generated by AGP and not persistent) if the environment variable for the keystore is not set. This allows local developer builds to work without requiring a key store. Once #32720 is resolved, we could sign just the production builds and remove the conditional logic. Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* mach: Expose a `--skip-static-analysis` to `mach boostrap` (#32587)Martin Robinson2024-06-243-3/+3
| | | | | This should speed up runners which just need to run the WPT tests. Fixes #32582.
* Make `crown` optional (#32494)Jonathan Schwender2024-06-244-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Make `crown` optional Add the optional `--use-crown` flag to mach * --use-crown for all platforms in CI Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Add documentation for `--use-crown` Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Update python/servo/command_base.py Co-authored-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com> Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * Raise Error if CARGO_BUILD_RUSTC conflicts with --use-crown Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * add dummy RUSTFLAG to trigger re-checking Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> --------- Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> Co-authored-by: Mukilan Thiyagarajan <mukilanthiagarajan@gmail.com>
* ci: Use a servo.org email address for the servo-wpt-sync GitHub bot (#32515)Martin Robinson2024-06-181-1/+1
| | | | | This is the new address of the WPT sync bot. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
* CI: Cache cargo-deny (#32543)Jonathan Schwender2024-06-185-0/+25
| | | | | | | | Use the `cargo-install` action to cache the cargo-deny output. `cargo-deny` is currently unconditionally installed during bootstrap, and takes around 2 minutes to install, so caching should give a significant speedup Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com>
* Add OpenHarmony support to mach and CI (#32507)Jonathan Schwender2024-06-173-0/+87
| | | | | | | | | | | | | | | | | | | | | | | | * Add ohos to mach Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> * Add OpenHarmony build to CI * Rename ohos sdk action I decided to rename the upstream ohos sdk action to setup-ohos-sdk, making it clearer that is a github action repository. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com> * Remove commented line Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> --------- Signed-off-by: Jonathan Schwender <jonathan.schwender@huawei.com> Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
* Sign off commits by WPT importer (#32502)Martin Robinson2024-06-141-1/+1
| | | This will be important to enforce signing off commits in the project.
* ci: Rename "try_labels.yml" to "try-label.yml" (#32503)Martin Robinson2024-06-141-0/+0
| | | | | This makes the name consistent with the other files in the directory which all use dashes and the singular "label" is a little bit more natural.
* Add a workaround for actions/runner-images#10001 (#32456)Martin Robinson2024-06-071-0/+3
| | | | Until GitHub updates their runner images, this workaround should allow the bots to work.
* ci: Disable legacy layout tests when landing PRs (#32405)Martin Robinson2024-05-311-1/+1
| | | | | This disables Layout 2013 checks when landing PRs. This means that results might get out of sync for 2013, but they should be updated weekly during WPT imports.
* ci: enable sccache for Rust compilation. (#32330)Mukilan Thiyagarajan2024-05-213-0/+3
| | | | | | | | | | This was previously disabled in #30508 due to sccache not working well with crown. The sccache issue (mozilla/sccache#861) linked in that PR is now closed and [testing][1] on my fork also seems to indicated we should be able to turn on sccache again. [1]: https://github.com/mukilan/servo/actions/runs/9154196647 Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
* Set RUSTUP_WINDOWS_PATH_ADD_BIN in CI (#32301)Samson2024-05-161-1/+2
|