diff options
Diffstat (limited to 'python/servo/testing_commands.py')
| -rw-r--r-- | python/servo/testing_commands.py | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index 7a821a08679..939b3434341 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -257,15 +257,30 @@ class MachCommands(CommandBase): category='testing') @CommandArgument('--faster', default=False, action="store_true", help="Only check changed files and skip the WPT lint in tidy, " - "if there are no changes in the WPT files") + "if there are no changes in the WPT files. Cannot be used with --all") + @CommandArgument('--all', default=False, action="store_true", dest="all_files", + help="Check all files, and run the WPT lint in tidy, " + "even if unchanged. Cannot be used with --faster") @CommandArgument('--no-progress', default=False, action="store_true", help="Don't show progress for tidy") @CommandArgument('--self-test', default=False, action="store_true", help="Run unit tests for tidy") - def test_tidy(self, faster, no_progress, self_test): + def test_tidy(self, faster, all_files, no_progress, self_test): if self_test: return test_tidy.do_tests() else: + # The `test-tidy` command is currently mid-migration from --faster to --all. + # Since --faster and --all are opposites, they cannot both be used at the same time + if faster and all_files: + print("Cannot tidy --all while also being --faster") + return -1 + + # |--faster|--all|behaviour of tidy.scan() + # | false|false|scan all files # This was the behaviour before adding --all + # | true|false|only scan changed files # Expected behaviour if --faster is used + # | false| true|scan all files # Expected behaviour if --all is used + # + # The pattern: if `faster` is true, go fast. Otherwise, go slow. return tidy.scan(faster, not no_progress) @Command('test-webidl', |