diff options
Diffstat (limited to 'components/script/dom')
-rw-r--r-- | components/script/dom/bindings/trace.rs | 2 | ||||
-rw-r--r-- | components/script/dom/csskeyframerule.rs | 26 | ||||
-rw-r--r-- | components/script/dom/csskeyframesrule.rs | 2 |
3 files changed, 18 insertions, 12 deletions
diff --git a/components/script/dom/bindings/trace.rs b/components/script/dom/bindings/trace.rs index efa1a5646f2..387709d7332 100644 --- a/components/script/dom/bindings/trace.rs +++ b/components/script/dom/bindings/trace.rs @@ -514,7 +514,7 @@ unsafe impl JSTraceable for StyleLocked<CssRules> { } } -unsafe impl JSTraceable for RwLock<Keyframe> { +unsafe impl JSTraceable for StyleLocked<Keyframe> { unsafe fn trace(&self, _trc: *mut JSTracer) { // Do nothing. } diff --git a/components/script/dom/csskeyframerule.rs b/components/script/dom/csskeyframerule.rs index 0f620bdc764..617546d6a76 100644 --- a/components/script/dom/csskeyframerule.rs +++ b/components/script/dom/csskeyframerule.rs @@ -12,21 +12,21 @@ use dom::cssstyledeclaration::{CSSModificationAccess, CSSStyleDeclaration, CSSSt use dom::cssstylesheet::CSSStyleSheet; use dom::window::Window; use dom_struct::dom_struct; -use parking_lot::RwLock; use std::sync::Arc; use style::keyframes::Keyframe; +use style::shared_lock::Locked; use style_traits::ToCss; #[dom_struct] pub struct CSSKeyframeRule { cssrule: CSSRule, #[ignore_heap_size_of = "Arc"] - keyframerule: Arc<RwLock<Keyframe>>, + keyframerule: Arc<Locked<Keyframe>>, style_decl: MutNullableJS<CSSStyleDeclaration>, } impl CSSKeyframeRule { - fn new_inherited(parent_stylesheet: &CSSStyleSheet, keyframerule: Arc<RwLock<Keyframe>>) + fn new_inherited(parent_stylesheet: &CSSStyleSheet, keyframerule: Arc<Locked<Keyframe>>) -> CSSKeyframeRule { CSSKeyframeRule { cssrule: CSSRule::new_inherited(parent_stylesheet), @@ -37,7 +37,7 @@ impl CSSKeyframeRule { #[allow(unrooted_must_root)] pub fn new(window: &Window, parent_stylesheet: &CSSStyleSheet, - keyframerule: Arc<RwLock<Keyframe>>) -> Root<CSSKeyframeRule> { + keyframerule: Arc<Locked<Keyframe>>) -> Root<CSSKeyframeRule> { reflect_dom_object(box CSSKeyframeRule::new_inherited(parent_stylesheet, keyframerule), window, CSSKeyframeRuleBinding::Wrap) @@ -48,11 +48,16 @@ impl CSSKeyframeRuleMethods for CSSKeyframeRule { // https://drafts.csswg.org/css-animations/#dom-csskeyframerule-style fn Style(&self) -> Root<CSSStyleDeclaration> { self.style_decl.or_init(|| { - CSSStyleDeclaration::new(self.global().as_window(), - CSSStyleOwner::CSSRule(JS::from_ref(self.upcast()), - self.keyframerule.read().block.clone()), - None, - CSSModificationAccess::ReadWrite) + let guard = self.cssrule.shared_lock().read(); + CSSStyleDeclaration::new( + self.global().as_window(), + CSSStyleOwner::CSSRule( + JS::from_ref(self.upcast()), + self.keyframerule.read_with(&guard).block.clone(), + ), + None, + CSSModificationAccess::ReadWrite, + ) }) } } @@ -64,6 +69,7 @@ impl SpecificCSSRule for CSSKeyframeRule { } fn get_css(&self) -> DOMString { - self.keyframerule.read().to_css_string().into() + let guard = self.cssrule.shared_lock().read(); + self.keyframerule.read_with(&guard).to_css_string().into() } } diff --git a/components/script/dom/csskeyframesrule.rs b/components/script/dom/csskeyframesrule.rs index d17eeeb51b5..288ae486d1d 100644 --- a/components/script/dom/csskeyframesrule.rs +++ b/components/script/dom/csskeyframesrule.rs @@ -67,7 +67,7 @@ impl CSSKeyframesRule { // because that's the rule that applies. Thus, rposition self.keyframesrule.read_with(&guard) .keyframes.iter().rposition(|frame| { - frame.read().selector == sel + frame.read_with(&guard).selector == sel }) } else { None |