diff options
7 files changed, 4 insertions, 35 deletions
diff --git a/components/script/dom/htmltablecolelement.rs b/components/script/dom/htmltablecolelement.rs index 36e0429230e..fbf7b2e9e32 100644 --- a/components/script/dom/htmltablecolelement.rs +++ b/components/script/dom/htmltablecolelement.rs @@ -101,7 +101,7 @@ impl VirtualMethods for HTMLTableColElement { } attr }, - local_name!("width") => AttrValue::from_nonzero_dimension(value.into()), + local_name!("width") => AttrValue::from_dimension(value.into()), _ => self .super_type() .unwrap() diff --git a/components/script/dom/htmltableelement.rs b/components/script/dom/htmltableelement.rs index b13113042fa..c835413c987 100644 --- a/components/script/dom/htmltableelement.rs +++ b/components/script/dom/htmltableelement.rs @@ -521,7 +521,7 @@ impl VirtualMethods for HTMLTableElement { match *local_name { local_name!("border") => AttrValue::from_u32(value.into(), 1), local_name!("width") => AttrValue::from_nonzero_dimension(value.into()), - local_name!("height") => AttrValue::from_nonzero_dimension(value.into()), + local_name!("height") => AttrValue::from_dimension(value.into()), local_name!("bgcolor") => AttrValue::from_legacy_color(value.into()), _ => self .super_type() diff --git a/components/script/dom/htmltablerowelement.rs b/components/script/dom/htmltablerowelement.rs index 6179c1fe063..0d0d6610ce5 100644 --- a/components/script/dom/htmltablerowelement.rs +++ b/components/script/dom/htmltablerowelement.rs @@ -182,7 +182,7 @@ impl VirtualMethods for HTMLTableRowElement { fn parse_plain_attribute(&self, local_name: &LocalName, value: DOMString) -> AttrValue { match *local_name { local_name!("bgcolor") => AttrValue::from_legacy_color(value.into()), - local_name!("height") => AttrValue::from_nonzero_dimension(value.into()), + local_name!("height") => AttrValue::from_dimension(value.into()), _ => self .super_type() .unwrap() diff --git a/components/script/dom/htmltablesectionelement.rs b/components/script/dom/htmltablesectionelement.rs index 5d7edf6ca83..136349aec4e 100644 --- a/components/script/dom/htmltablesectionelement.rs +++ b/components/script/dom/htmltablesectionelement.rs @@ -120,7 +120,7 @@ impl VirtualMethods for HTMLTableSectionElement { fn parse_plain_attribute(&self, local_name: &LocalName, value: DOMString) -> AttrValue { match *local_name { local_name!("bgcolor") => AttrValue::from_legacy_color(value.into()), - local_name!("height") => AttrValue::from_nonzero_dimension(value.into()), + local_name!("height") => AttrValue::from_dimension(value.into()), _ => self .super_type() .unwrap() diff --git a/tests/wpt/meta/html/rendering/dimension-attributes.html.ini b/tests/wpt/meta/html/rendering/dimension-attributes.html.ini index f3eaf8cdf25..77e01e40099 100644 --- a/tests/wpt/meta/html/rendering/dimension-attributes.html.ini +++ b/tests/wpt/meta/html/rendering/dimension-attributes.html.ini @@ -1702,30 +1702,3 @@ [<source height="0px"> mapping to <img> height property] expected: FAIL - - [<table height="0"> mapping to <table> height property] - expected: FAIL - - [<table height="0%"> mapping to <table> height property] - expected: FAIL - - [<table height="0px"> mapping to <table> height property] - expected: FAIL - - [<tr height="0"> mapping to <tr> height property] - expected: FAIL - - [<tr height="0%"> mapping to <tr> height property] - expected: FAIL - - [<tr height="0px"> mapping to <tr> height property] - expected: FAIL - - [<col width="0"> mapping to <col> width property] - expected: FAIL - - [<col width="0%"> mapping to <col> width property] - expected: FAIL - - [<col width="0px"> mapping to <col> width property] - expected: FAIL diff --git a/tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-column-width.html.ini b/tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-column-width.html.ini deleted file mode 100644 index 751d06fa211..00000000000 --- a/tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-column-width.html.ini +++ /dev/null @@ -1,2 +0,0 @@ -[table-column-width.html] - expected: FAIL diff --git a/tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-row-height.html.ini b/tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-row-height.html.ini deleted file mode 100644 index cf21f0ef4ff..00000000000 --- a/tests/wpt/meta/html/rendering/non-replaced-elements/tables/table-row-height.html.ini +++ /dev/null @@ -1,2 +0,0 @@ -[table-row-height.html] - expected: FAIL |