diff options
25 files changed, 146 insertions, 240 deletions
diff --git a/components/script/dom/create.rs b/components/script/dom/create.rs index b96406b60ed..52410a487b8 100644 --- a/components/script/dom/create.rs +++ b/components/script/dom/create.rs @@ -2,10 +2,13 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +use dom::bindings::error::{report_pending_exception, throw_dom_exception}; use dom::bindings::js::Root; +use dom::bindings::reflector::DomObject; use dom::document::Document; use dom::element::Element; use dom::element::ElementCreator; +use dom::globalscope::GlobalScope; use dom::htmlanchorelement::HTMLAnchorElement; use dom::htmlappletelement::HTMLAppletElement; use dom::htmlareaelement::HTMLAreaElement; @@ -77,6 +80,7 @@ use dom::htmlunknownelement::HTMLUnknownElement; use dom::htmlvideoelement::HTMLVideoElement; use dom::svgsvgelement::SVGSVGElement; use html5ever::{QualName, Prefix}; +use js::jsapi::JSAutoCompartment; use servo_config::prefs::PREFS; fn create_svg_element(name: QualName, @@ -106,11 +110,42 @@ fn create_svg_element(name: QualName, } } +// https://dom.spec.whatwg.org/#concept-create-element +#[allow(unsafe_code)] fn create_html_element(name: QualName, prefix: Option<Prefix>, document: &Document, creator: ElementCreator) -> Root<Element> { + assert!(name.ns == ns!(html)); + + // Step 4 + let definition = document.lookup_custom_element_definition(name.local.clone(), None); + + if let Some(definition) = definition { + // TODO: Handle customized built-in elements. Relies on CE upgrades. + if definition.is_autonomous() { + let local_name = name.local.clone(); + return match definition.create_element(document) { + Ok(element) => element, + Err(error) => { + // Step 6. Recovering from exception. + let global = GlobalScope::current().unwrap_or_else(|| document.global()); + + // Step 6.1.1 + unsafe { + let _ac = JSAutoCompartment::new(global.get_cx(), global.reflector().get_jsobject().get()); + throw_dom_exception(global.get_cx(), &global, error); + report_pending_exception(global.get_cx(), true); + } + + // Step 6.1.2 + Root::upcast(HTMLUnknownElement::new(local_name, prefix, document)) + }, + }; + } + } + create_native_html_element(name, prefix, document, creator) } diff --git a/components/script/dom/customelementregistry.rs b/components/script/dom/customelementregistry.rs index ee584a8bae1..3b151a8f764 100644 --- a/components/script/dom/customelementregistry.rs +++ b/components/script/dom/customelementregistry.rs @@ -7,23 +7,31 @@ use dom::bindings::cell::DOMRefCell; use dom::bindings::codegen::Bindings::CustomElementRegistryBinding; use dom::bindings::codegen::Bindings::CustomElementRegistryBinding::CustomElementRegistryMethods; use dom::bindings::codegen::Bindings::CustomElementRegistryBinding::ElementDefinitionOptions; +use dom::bindings::codegen::Bindings::ElementBinding::ElementMethods; use dom::bindings::codegen::Bindings::FunctionBinding::Function; -use dom::bindings::error::{Error, ErrorResult}; +use dom::bindings::conversions::{ConversionResult, FromJSValConvertible}; +use dom::bindings::error::{Error, ErrorResult, Fallible}; use dom::bindings::inheritance::Castable; use dom::bindings::js::{JS, Root}; use dom::bindings::reflector::{DomObject, Reflector, reflect_dom_object}; use dom::bindings::str::DOMString; +use dom::document::Document; use dom::domexception::{DOMErrorName, DOMException}; +use dom::element::Element; use dom::globalscope::GlobalScope; +use dom::htmlelement::HTMLElement; +use dom::node::Node; use dom::promise::Promise; use dom::window::Window; use dom_struct::dom_struct; use html5ever::LocalName; use js::conversions::ToJSValConvertible; -use js::jsapi::{IsConstructor, HandleObject, JS_GetProperty, JSAutoCompartment, JSContext}; -use js::jsval::{JSVal, UndefinedValue}; +use js::jsapi::{Construct1, IsConstructor, HandleValueArray, HandleObject}; +use js::jsapi::{JS_GetProperty, JSAutoCompartment, JSContext}; +use js::jsval::{JSVal, ObjectValue, UndefinedValue}; use std::cell::Cell; use std::collections::HashMap; +use std::ptr; use std::rc::Rc; /// https://html.spec.whatwg.org/multipage/#customelementregistry @@ -34,12 +42,12 @@ pub struct CustomElementRegistry { window: JS<Window>, #[ignore_heap_size_of = "Rc"] - when_defined: DOMRefCell<HashMap<DOMString, Rc<Promise>>>, + when_defined: DOMRefCell<HashMap<LocalName, Rc<Promise>>>, element_definition_is_running: Cell<bool>, #[ignore_heap_size_of = "Rc"] - definitions: DOMRefCell<HashMap<DOMString, Rc<CustomElementDefinition>>>, + definitions: DOMRefCell<HashMap<LocalName, Rc<CustomElementDefinition>>>, } impl CustomElementRegistry { @@ -65,6 +73,18 @@ impl CustomElementRegistry { self.when_defined.borrow_mut().clear() } + /// https://html.spec.whatwg.org/multipage/#look-up-a-custom-element-definition + pub fn lookup_definition(&self, + local_name: LocalName, + is: Option<LocalName>) + -> Option<Rc<CustomElementDefinition>> { + self.definitions.borrow().values().find(|definition| { + // Step 4-5 + definition.local_name == local_name && + (definition.name == local_name || Some(&definition.name) == is.as_ref()) + }).cloned() + } + pub fn lookup_definition_by_constructor(&self, constructor: HandleObject) -> Option<Rc<CustomElementDefinition>> { self.definitions.borrow().values().find(|definition| { definition.constructor.callback() == constructor.get() @@ -101,6 +121,7 @@ impl CustomElementRegistryMethods for CustomElementRegistry { fn Define(&self, name: DOMString, constructor_: Rc<Function>, options: &ElementDefinitionOptions) -> ErrorResult { let global_scope = self.window.upcast::<GlobalScope>(); rooted!(in(global_scope.get_cx()) let constructor = constructor_.callback()); + let name = LocalName::from(&*name); // Step 1 if unsafe { !IsConstructor(constructor.get()) } { @@ -137,10 +158,10 @@ impl CustomElementRegistryMethods for CustomElementRegistry { return Err(Error::NotSupported) } - extended_name + LocalName::from(&**extended_name) } else { // Step 7.3 - &name + name.clone() }; // Step 8 @@ -165,8 +186,8 @@ impl CustomElementRegistryMethods for CustomElementRegistry { result?; // Step 11 - let definition = CustomElementDefinition::new(LocalName::from(&*name), - LocalName::from(&**local_name), + let definition = CustomElementDefinition::new(name.clone(), + local_name, constructor_); // Step 12 @@ -188,7 +209,7 @@ impl CustomElementRegistryMethods for CustomElementRegistry { /// https://html.spec.whatwg.org/multipage/#dom-customelementregistry-get #[allow(unsafe_code)] unsafe fn Get(&self, cx: *mut JSContext, name: DOMString) -> JSVal { - match self.definitions.borrow().get(&name) { + match self.definitions.borrow().get(&LocalName::from(&*name)) { Some(definition) => { rooted!(in(cx) let mut constructor = UndefinedValue()); definition.constructor.to_jsval(cx, constructor.handle_mut()); @@ -202,6 +223,7 @@ impl CustomElementRegistryMethods for CustomElementRegistry { #[allow(unrooted_must_root)] fn WhenDefined(&self, name: DOMString) -> Rc<Promise> { let global_scope = self.window.upcast::<GlobalScope>(); + let name = LocalName::from(&*name); // Step 1 if !is_valid_custom_element_name(&name) { @@ -256,6 +278,53 @@ impl CustomElementDefinition { pub fn is_autonomous(&self) -> bool { self.name == self.local_name } + + /// https://dom.spec.whatwg.org/#concept-create-element Step 6.1 + #[allow(unsafe_code)] + pub fn create_element(&self, document: &Document) -> Fallible<Root<Element>> { + let window = document.window(); + let cx = window.get_cx(); + // Step 2 + rooted!(in(cx) let constructor = ObjectValue(self.constructor.callback())); + rooted!(in(cx) let mut element = ptr::null_mut()); + { + // Go into the constructor's compartment + let _ac = JSAutoCompartment::new(cx, self.constructor.callback()); + let args = HandleValueArray::new(); + if unsafe { !Construct1(cx, constructor.handle(), &args, element.handle_mut()) } { + return Err(Error::JSFailed); + } + } + + rooted!(in(cx) let element_val = ObjectValue(element.get())); + let element: Root<Element> = match unsafe { Root::from_jsval(cx, element_val.handle(), ()) } { + Ok(ConversionResult::Success(element)) => element, + Ok(ConversionResult::Failure(..)) => + return Err(Error::Type("Constructor did not return a DOM node".to_owned())), + _ => return Err(Error::JSFailed), + }; + + // Step 3 + if !element.is::<HTMLElement>() { + return Err(Error::Type("Constructor did not return a DOM node".to_owned())); + } + + // Steps 4-9 + if element.HasAttributes() || + element.upcast::<Node>().children_count() > 0 || + element.upcast::<Node>().has_parent() || + &*element.upcast::<Node>().owner_doc() != document || + *element.namespace() != ns!(html) || + *element.local_name() != self.local_name + { + return Err(Error::NotSupported); + } + + // Step 11 + // Element's `is` is None by default + + Ok(element) + } } /// https://html.spec.whatwg.org/multipage/#valid-custom-element-name diff --git a/components/script/dom/document.rs b/components/script/dom/document.rs index c97d352872c..a61421e7866 100644 --- a/components/script/dom/document.rs +++ b/components/script/dom/document.rs @@ -36,6 +36,7 @@ use dom::bindings::xmlname::{namespace_from_domstring, validate_and_extract, xml use dom::bindings::xmlname::XMLName::InvalidXMLName; use dom::closeevent::CloseEvent; use dom::comment::Comment; +use dom::customelementregistry::CustomElementDefinition; use dom::customevent::CustomEvent; use dom::documentfragment::DocumentFragment; use dom::documenttype::DocumentType; @@ -1996,6 +1997,26 @@ impl Document { self.window.layout().nodes_from_point_response() } + + /// https://html.spec.whatwg.org/multipage/#look-up-a-custom-element-definition + pub fn lookup_custom_element_definition(&self, + local_name: LocalName, + is: Option<LocalName>) + -> Option<Rc<CustomElementDefinition>> { + if !PREFS.get("dom.customelements.enabled").as_boolean().unwrap_or(false) { + return None; + } + + // Step 2 + if !self.has_browsing_context { + return None; + } + + // Step 3 + let registry = self.window.CustomElements(); + + registry.lookup_definition(local_name, is) + } } #[derive(PartialEq, HeapSizeOf)] diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs index cace0497433..f09001625d0 100644 --- a/components/script/dom/node.rs +++ b/components/script/dom/node.rs @@ -428,6 +428,11 @@ impl Node { self.preceding_siblings().count() as u32 } + /// Returns true if this node has a parent. + pub fn has_parent(&self) -> bool { + self.parent_node.get().is_some() + } + pub fn children_count(&self) -> u32 { self.children_count.get() } diff --git a/tests/wpt/metadata/custom-elements/CustomElementRegistry.html.ini b/tests/wpt/metadata/custom-elements/CustomElementRegistry.html.ini index e99a0cb2bdb..72117493595 100644 --- a/tests/wpt/metadata/custom-elements/CustomElementRegistry.html.ini +++ b/tests/wpt/metadata/custom-elements/CustomElementRegistry.html.ini @@ -1,8 +1,5 @@ [CustomElementRegistry.html] type: testharness - [customElements.define must not throw when defining another custom element in a different global object during Get(constructor, "prototype")] - expected: FAIL - [customElements.define must get callbacks of the constructor prototype] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/Document-createElement.html.ini b/tests/wpt/metadata/custom-elements/Document-createElement.html.ini deleted file mode 100644 index 9978606560f..00000000000 --- a/tests/wpt/metadata/custom-elements/Document-createElement.html.ini +++ /dev/null @@ -1,38 +0,0 @@ -[Document-createElement.html] - type: testharness - [document.createElement must create an instance of custom elements] - expected: FAIL - - [document.createElement must report a TypeError when the result of Construct is not a DOM node] - expected: FAIL - - [document.createElement must report a TypeError when the result of Construct is a TextNode] - expected: FAIL - - [document.createElement must report a NotSupportedError when attribute is added by setAttribute during construction] - expected: FAIL - - [document.createElement must report a NotSupportedError when attribute is added by attributes.setNamedItem during construction] - expected: FAIL - - [document.createElement must not report a NotSupportedError when attribute is added and removed during construction] - expected: FAIL - - [document.createElement must report a NotSupportedError when a Text child is added during construction] - expected: FAIL - - [document.createElement must report a NotSupportedError when a Comment child is added during construction] - expected: FAIL - - [document.createElement must report a NotSupportedError when an element child is added during construction] - expected: FAIL - - [document.createElement must not report a NotSupportedError when an element child is added and removed during construction] - expected: FAIL - - [document.createElement must report a NotSupportedError when the element gets inserted into another element during construction] - expected: FAIL - - [document.createElement must not report a NotSupportedError when the element is inserted and removed from another element during construction] - expected: FAIL - diff --git a/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-in-document-write.html.ini b/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-in-document-write.html.ini index acf53969d9d..f93d34eb9b8 100644 --- a/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-in-document-write.html.ini +++ b/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-in-document-write.html.ini @@ -1,8 +1,5 @@ [parser-constructs-custom-element-in-document-write.html] type: testharness - [HTML parser must instantiate custom elements inside document.write] - expected: FAIL - [Custom Elements: Changes to the HTML parser] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-synchronously.html.ini b/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-synchronously.html.ini index 191462ce811..48df95140d3 100644 --- a/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-synchronously.html.ini +++ b/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-element-synchronously.html.ini @@ -1,8 +1,5 @@ [parser-constructs-custom-element-synchronously.html] type: testharness - [HTML parser must only append nodes that appear before a custom element before instantiating the custom element] - expected: FAIL - [Custom Elements: Changes to the HTML parser] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-elements.html.ini b/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-elements.html.ini deleted file mode 100644 index d6aae45c4a3..00000000000 --- a/tests/wpt/metadata/custom-elements/parser/parser-constructs-custom-elements.html.ini +++ /dev/null @@ -1,5 +0,0 @@ -[parser-constructs-custom-elements.html] - type: testharness - [HTML parser must create a defined custom element before executing inline scripts] - expected: FAIL - diff --git a/tests/wpt/metadata/custom-elements/parser/parser-sets-attributes-and-children.html.ini b/tests/wpt/metadata/custom-elements/parser/parser-sets-attributes-and-children.html.ini index 177da52fce6..51e75dccba0 100644 --- a/tests/wpt/metadata/custom-elements/parser/parser-sets-attributes-and-children.html.ini +++ b/tests/wpt/metadata/custom-elements/parser/parser-sets-attributes-and-children.html.ini @@ -1,8 +1,5 @@ [parser-sets-attributes-and-children.html] type: testharness - [HTML parser must set the attributes or append children before calling constructor] - expected: FAIL - [Custom Elements: Changes to the HTML parser] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/parser/parser-uses-constructed-element.html.ini b/tests/wpt/metadata/custom-elements/parser/parser-uses-constructed-element.html.ini index 1c940fa0990..f3f6e422571 100644 --- a/tests/wpt/metadata/custom-elements/parser/parser-uses-constructed-element.html.ini +++ b/tests/wpt/metadata/custom-elements/parser/parser-uses-constructed-element.html.ini @@ -1,11 +1,5 @@ [parser-uses-constructed-element.html] type: testharness - [HTML parser must use the returned value of the custom element constructor instead of the one created before super() call] - expected: FAIL - - [HTML parser must use the returned value of the custom element constructor instead using the one created in super() call] - expected: FAIL - [Custom Elements: HTML parser must construct a custom element instead of upgrading] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/parser/parser-uses-registry-of-owner-document.html.ini b/tests/wpt/metadata/custom-elements/parser/parser-uses-registry-of-owner-document.html.ini index bd53f25903e..ef16e6972c8 100644 --- a/tests/wpt/metadata/custom-elements/parser/parser-uses-registry-of-owner-document.html.ini +++ b/tests/wpt/metadata/custom-elements/parser/parser-uses-registry-of-owner-document.html.ini @@ -9,3 +9,6 @@ [Custom Elements: HTML parser must use the owner document's custom element registry] expected: FAIL + [HTML parser must not instantiate custom elements inside template elements] + expected: FAIL + diff --git a/tests/wpt/metadata/custom-elements/reaction-timing.html.ini b/tests/wpt/metadata/custom-elements/reaction-timing.html.ini index 5b335cb5852..9abe37eb4e5 100644 --- a/tests/wpt/metadata/custom-elements/reaction-timing.html.ini +++ b/tests/wpt/metadata/custom-elements/reaction-timing.html.ini @@ -3,9 +3,6 @@ [setAttribute and removeAttribute must enqueue and invoke attributeChangedCallback] expected: FAIL - [Calling Node.prototype.cloneNode(false) must push a new element queue to the processing stack] - expected: FAIL - [Custom Elements: Custom element reactions must be invoked before returning to author scripts] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/reactions/Attr.html.ini b/tests/wpt/metadata/custom-elements/reactions/Attr.html.ini index 5a3ddc4ec85..bd4c3d13679 100644 --- a/tests/wpt/metadata/custom-elements/reactions/Attr.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/Attr.html.ini @@ -3,6 +3,3 @@ [value on Attr must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [value on Attr must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - diff --git a/tests/wpt/metadata/custom-elements/reactions/CSSStyleDeclaration.html.ini b/tests/wpt/metadata/custom-elements/reactions/CSSStyleDeclaration.html.ini index 25a52820a2e..63215ffadfd 100644 --- a/tests/wpt/metadata/custom-elements/reactions/CSSStyleDeclaration.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/CSSStyleDeclaration.html.ini @@ -3,87 +3,45 @@ [cssText on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL - [cssText on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it adds the style attribute but the style attribute is not observed] - expected: FAIL - [cssText on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute] expected: FAIL - [cssText on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it mutates the style attribute but the style attribute is not observed] - expected: FAIL - [setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL - [setProperty on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it adds the style attribute but the style attribute is not observed] - expected: FAIL - [setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute] expected: FAIL - [setProperty on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it mutates the style attribute but the style attribute is not observed] - expected: FAIL - [setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it makes a property important and the style attribute is observed] expected: FAIL - [setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it makes a property important but the style attribute is not observed] - expected: FAIL - [setPropertyValue on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL - [setPropertyValue on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it adds the style attribute but the style attribute is not observed] - expected: FAIL - [setPropertyValue on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute] expected: FAIL - [setPropertyValue on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it mutates the style attribute but the style attribute is not observed] - expected: FAIL - [setPropertyPriority on CSSStyleDeclaration must enqueue an attributeChanged reaction when it makes a property important and the style attribute is observed] expected: FAIL - [setPropertyPriority on CSSStyleDeclaration must enqueue an attributeChanged reaction when it makes a property important but the style attribute is not observed] - expected: FAIL - [removeProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it removes a property from the observed style attribute] expected: FAIL - [removeProperty on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it removes a property from the style attribute but the style attribute is not observed] - expected: FAIL - [cssFloat on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL - [cssFloat on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it adds the style attribute but the style attribute is not observed] - expected: FAIL - [A camel case attribute (borderWidth) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL - [A camel case attribute (borderWidth) on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it adds the style attribute but the style attribute is not observed] - expected: FAIL - [A camel case attribute (borderWidth) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute] expected: FAIL - [A camel case attribute (borderWidth) on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it mutates the style attribute but the style attribute is not observed] - expected: FAIL - [A dashed property (border-width) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL - [A dashed property (border-width) on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it adds the style attribute but the style attribute is not observed] - expected: FAIL - [A dashed property (border-width) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute] expected: FAIL - [A dashed property (border-width) on CSSStyleDeclaration must not enqueue an attributeChanged reaction when it mutates the style attribute but the style attribute is not observed] - expected: FAIL - [A webkit prefixed camel case attribute (webkitFilter) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/reactions/DOMStringMap.html.ini b/tests/wpt/metadata/custom-elements/reactions/DOMStringMap.html.ini index 9cd64315e1b..f92cc7c1ae7 100644 --- a/tests/wpt/metadata/custom-elements/reactions/DOMStringMap.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/DOMStringMap.html.ini @@ -3,24 +3,12 @@ [setter on DOMStringMap must enqueue an attributeChanged reaction when adding an observed data attribute] expected: FAIL - [setter on DOMStringMap must not enqueue an attributeChanged reaction when adding an unobserved data attribute] - expected: FAIL - [setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute] expected: FAIL [setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value] expected: FAIL - [setter on DOMStringMap must not enqueue an attributeChanged reaction when mutating the value of an unobserved data attribute] - expected: FAIL - [deleter on DOMStringMap must enqueue an attributeChanged reaction when removing an observed data attribute] expected: FAIL - [deleter on DOMStringMap must not enqueue an attributeChanged reaction when removing an unobserved data attribute] - expected: FAIL - - [deleter on DOMStringMap must not enqueue an attributeChanged reaction when it does not remove a data attribute] - expected: FAIL - diff --git a/tests/wpt/metadata/custom-elements/reactions/DOMTokenList.html.ini b/tests/wpt/metadata/custom-elements/reactions/DOMTokenList.html.ini index 5c7a1734d34..471f7e8fccf 100644 --- a/tests/wpt/metadata/custom-elements/reactions/DOMTokenList.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/DOMTokenList.html.ini @@ -3,15 +3,9 @@ [add on DOMTokenList must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [add on DOMTokenList must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [add on DOMTokenList must enqueue an attributeChanged reaction when adding a value to an existing attribute] expected: FAIL - [add on DOMTokenList must not enqueue an attributeChanged reaction when adding a value to an unobserved attribute] - expected: FAIL - [add on DOMTokenList must enqueue exactly one attributeChanged reaction when adding multiple values to an attribute] expected: FAIL @@ -24,9 +18,6 @@ [remove on DOMTokenList must enqueue an attributeChanged reaction even when removing a non-existent value from an attribute] expected: FAIL - [remove on DOMTokenList must not enqueue an attributeChanged reaction when removing a value from an unobserved attribute] - expected: FAIL - [toggle on DOMTokenList must enqueue an attributeChanged reaction when adding a value to an attribute] expected: FAIL @@ -39,21 +30,12 @@ [replace on DOMTokenList must not enqueue an attributeChanged reaction when the token to replace does not exist in the attribute] expected: FAIL - [replace on DOMTokenList must not enqueue an attributeChanged reaction when replacing a value in an unobserved attribute] - expected: FAIL - [the stringifier of DOMTokenList must enqueue an attributeChanged reaction when adding an observed attribute] expected: FAIL - [the stringifier of DOMTokenList must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [the stringifier of DOMTokenList must enqueue an attributeChanged reaction when mutating the value of an observed attribute] expected: FAIL - [the stringifier of DOMTokenList must not enqueue an attributeChanged reaction when mutating the value of an unobserved attribute] - expected: FAIL - [the stringifier of DOMTokenList must enqueue an attributeChanged reaction when the setter is called with the original value of the attribute] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/reactions/Document.html.ini b/tests/wpt/metadata/custom-elements/reactions/Document.html.ini index a31a31b0d2e..ec21b3a7030 100644 --- a/tests/wpt/metadata/custom-elements/reactions/Document.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/Document.html.ini @@ -1,11 +1,5 @@ [Document.html] type: testharness - [importNode on Document must not construct a new custom element when importing a custom element into a window-less document] - expected: FAIL - - [importNode on Document must construct a new custom element when importing a custom element from a template] - expected: FAIL - [adoptNode on Document must enqueue an adopted reaction when importing a custom element] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/reactions/Element.html.ini b/tests/wpt/metadata/custom-elements/reactions/Element.html.ini index 9407ce44d26..fa721851548 100644 --- a/tests/wpt/metadata/custom-elements/reactions/Element.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/Element.html.ini @@ -21,78 +21,36 @@ [setAttribute on Element must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [setAttribute on Element must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [setAttribute on Element must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [setAttribute on Element must enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - [setAttributeNS on Element must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [setAttributeNS on Element must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [setAttributeNS on Element must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [setAttributeNS on Element must enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - - [removeAttribute on Element must not enqueue an attributeChanged reaction when removing an unobserved attribute] - expected: FAIL - [removeAttribute on Element must enqueue an attributeChanged reaction when removing an existing attribute] expected: FAIL - [removeAttribute on Element must not enqueue an attributeChanged reaction when removing an existing unobserved attribute] - expected: FAIL - - [removeAttributeNS on Element must not enqueue an attributeChanged reaction when removing an unobserved attribute] - expected: FAIL - [removeAttributeNS on Element must enqueue an attributeChanged reaction when removing an existing attribute] expected: FAIL - [removeAttributeNS on Element must not enqueue an attributeChanged reaction when removing an existing unobserved attribute] - expected: FAIL - [setAttributeNode on Element must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [setAttributeNode on Element must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [setAttributeNode on Element must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [setAttributeNode on Element must enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - [setAttributeNodeNS on Element must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [setAttributeNodeNS on Element must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [setAttributeNodeNS on Element must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [setAttributeNodeNS on Element must enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - - [removeAttributeNode on Element must not enqueue an attributeChanged reaction when removing an unobserved attribute] - expected: FAIL - [removeAttributeNode on Element must enqueue an attributeChanged reaction when removing an existing attribute] expected: FAIL - [removeAttributeNode on Element must not enqueue an attributeChanged reaction when removing an existing unobserved attribute] - expected: FAIL - [insertAdjacentElement on Element must enqueue a connected reaction] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/reactions/NamedNodeMap.html.ini b/tests/wpt/metadata/custom-elements/reactions/NamedNodeMap.html.ini index 9361e3c2d0f..f1ffa8a7189 100644 --- a/tests/wpt/metadata/custom-elements/reactions/NamedNodeMap.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/NamedNodeMap.html.ini @@ -3,42 +3,18 @@ [setNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [setNamedItem on NamedNodeMap must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [setNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [setNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - [setNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when adding an attribute] expected: FAIL - [setNamedItemNS on NamedNodeMap must not enqueue an attributeChanged reaction when adding an unobserved attribute] - expected: FAIL - [setNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [setNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - - [removeNamedItem on NamedNodeMap must not enqueue an attributeChanged reaction when removing an unobserved attribute] - expected: FAIL - [removeNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when removing an existing attribute] expected: FAIL - [removeNamedItem on NamedNodeMap must not enqueue an attributeChanged reaction when removing an existing unobserved attribute] - expected: FAIL - - [removeNamedItemNS on NamedNodeMap must not enqueue an attributeChanged reaction when removing an unobserved attribute] - expected: FAIL - [removeNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when removing an existing attribute] expected: FAIL - [removeNamedItemNS on NamedNodeMap must not enqueue an attributeChanged reaction when removing an existing unobserved attribute] - expected: FAIL - diff --git a/tests/wpt/metadata/custom-elements/reactions/Node.html.ini b/tests/wpt/metadata/custom-elements/reactions/Node.html.ini index 87acc9aa613..a5be84ba635 100644 --- a/tests/wpt/metadata/custom-elements/reactions/Node.html.ini +++ b/tests/wpt/metadata/custom-elements/reactions/Node.html.ini @@ -3,15 +3,9 @@ [nodeValue on Node must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [nodeValue on Node must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - [textContent on Node must enqueue an attributeChanged reaction when replacing an existing attribute] expected: FAIL - [textContent on Node must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute] - expected: FAIL - [cloneNode on Node must enqueue an attributeChanged reaction when cloning an element with an observed attribute] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/upgrading.html.ini b/tests/wpt/metadata/custom-elements/upgrading.html.ini index 9a070a44860..269f72b5603 100644 --- a/tests/wpt/metadata/custom-elements/upgrading.html.ini +++ b/tests/wpt/metadata/custom-elements/upgrading.html.ini @@ -36,9 +36,6 @@ [Creating an element in an HTML document fetched by XHR and adopting back to a document with browsing context must enqueue a custom element upgrade reaction] expected: FAIL - [Creating an element in the document of an iframe must enqueue a custom element upgrade reaction if there is a matching definition] - expected: FAIL - ["define" in the document of an iframe must not enqueue a custom element upgrade reaction on a disconnected unresolved custom element] expected: FAIL diff --git a/tests/wpt/metadata/custom-elements/upgrading/Node-cloneNode.html.ini b/tests/wpt/metadata/custom-elements/upgrading/Node-cloneNode.html.ini index 3214c6fd3b0..548258e0e22 100644 --- a/tests/wpt/metadata/custom-elements/upgrading/Node-cloneNode.html.ini +++ b/tests/wpt/metadata/custom-elements/upgrading/Node-cloneNode.html.ini @@ -1,14 +1,5 @@ [Node-cloneNode.html] type: testharness - [Node.prototype.cloneNode(false) must be able to clone a custom element] - expected: FAIL - - [Node.prototype.cloneNode(false) must be able to clone a custom element inside an iframe] - expected: FAIL - - [Node.prototype.cloneNode(true) must be able to clone a descendent custom element] - expected: FAIL - [Node.prototype.cloneNode(true) must set parentNode, previousSibling, and nextSibling before upgrading custom elements] expected: FAIL diff --git a/tests/wpt/metadata/html/browsers/browsing-the-web/scroll-to-fragid/003.html.ini b/tests/wpt/metadata/html/browsers/browsing-the-web/scroll-to-fragid/003.html.ini index ae630f04075..23e4a811c3d 100644 --- a/tests/wpt/metadata/html/browsers/browsing-the-web/scroll-to-fragid/003.html.ini +++ b/tests/wpt/metadata/html/browsers/browsing-the-web/scroll-to-fragid/003.html.ini @@ -1,4 +1,5 @@ [003.html] type: testharness [Fragment Navigation: Updating scroll position] - expected: FAIL
\ No newline at end of file + expected: FAIL + diff --git a/tests/wpt/metadata/html/semantics/embedded-content/the-iframe-element/iframe-append-to-child-document.html.ini b/tests/wpt/metadata/html/semantics/embedded-content/the-iframe-element/iframe-append-to-child-document.html.ini index d73bfee8141..af1f00202d3 100644 --- a/tests/wpt/metadata/html/semantics/embedded-content/the-iframe-element/iframe-append-to-child-document.html.ini +++ b/tests/wpt/metadata/html/semantics/embedded-content/the-iframe-element/iframe-append-to-child-document.html.ini @@ -3,3 +3,4 @@ [Append iframe element to its own child document] bug: https://github.com/servo/servo/issues/17479 expected: FAIL + |