diff options
| -rw-r--r-- | components/canvas/webgl_paint_thread.rs | 2 | ||||
| -rw-r--r-- | components/script/dom/htmlcanvaselement.rs | 2 | ||||
| -rw-r--r-- | components/script/dom/webglprogram.rs | 2 | ||||
| -rw-r--r-- | components/script/dom/webglrenderingcontext.rs | 11 | ||||
| -rw-r--r-- | components/style/selector_matching.rs | 2 | ||||
| -rw-r--r-- | tests/wpt/web-platform-tests/XMLHttpRequest/OWNERS | 2 |
6 files changed, 10 insertions, 11 deletions
diff --git a/components/canvas/webgl_paint_thread.rs b/components/canvas/webgl_paint_thread.rs index 102a9f85f32..85f03e758ba 100644 --- a/components/canvas/webgl_paint_thread.rs +++ b/components/canvas/webgl_paint_thread.rs @@ -81,7 +81,7 @@ impl WebGLPaintThread { CanvasMsg::Common(message) => { match message { CanvasCommonMsg::Close => break, - // TODO(ecoal95): handle error nicely + // TODO(emilio): handle error nicely CanvasCommonMsg::Recreate(size) => painter.recreate(size).unwrap(), } }, diff --git a/components/script/dom/htmlcanvaselement.rs b/components/script/dom/htmlcanvaselement.rs index b078e87fe45..622824f88d9 100644 --- a/components/script/dom/htmlcanvaselement.rs +++ b/components/script/dom/htmlcanvaselement.rs @@ -206,7 +206,7 @@ impl HTMLCanvasElement { CanvasData::Pixels(pixel_data) => pixel_data.image_data.to_vec(), CanvasData::WebGL(_) - // TODO(ecoal95): Not sure if WebGL canvas is required for 2d spec, + // TODO(emilio): Not sure if WebGL canvas is required for 2d spec, // but I think it's not. => return None, } diff --git a/components/script/dom/webglprogram.rs b/components/script/dom/webglprogram.rs index 42eb0a23581..9df581f9afc 100644 --- a/components/script/dom/webglprogram.rs +++ b/components/script/dom/webglprogram.rs @@ -96,7 +96,7 @@ impl WebGLProgram { _ => return Err(WebGLError::InvalidOperation), }; - // TODO(ecoal95): Differentiate between same shader already assigned and other previous + // TODO(emilio): Differentiate between same shader already assigned and other previous // shader. if shader_slot.get().is_some() { return Err(WebGLError::InvalidOperation); diff --git a/components/script/dom/webglrenderingcontext.rs b/components/script/dom/webglrenderingcontext.rs index 5251585ea94..c5070cca69e 100644 --- a/components/script/dom/webglrenderingcontext.rs +++ b/components/script/dom/webglrenderingcontext.rs @@ -610,7 +610,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext { } } - // TODO(ecoal95): Probably in the future we should keep track of the + // TODO(emilio): Probably in the future we should keep track of the // generated objects, either here or in the webgl thread // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.5 fn CreateBuffer(&self) -> Option<Root<WebGLBuffer>> { @@ -1116,8 +1116,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext { if texture.is_none() { return self.webgl_error(InvalidOperation); } - // TODO(ecoal95): Validate more parameters - + // TODO(emilio): Validate more parameters let source = match source { Some(s) => s, None => return, @@ -1144,7 +1143,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext { }; let size = Size2D::new(img.width as i32, img.height as i32); - // TODO(ecoal95): Validate that the format argument is coherent with the image. + // TODO(emilio): Validate that the format argument is coherent with the image. // RGB8 should be easy to support too let mut data = match img.format { PixelFormat::RGBA8 => img.bytes.to_vec(), @@ -1155,7 +1154,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext { (data, size) }, - // TODO(ecoal95): Getting canvas data is implemented in CanvasRenderingContext2D, but + // TODO(emilio): Getting canvas data is implemented in CanvasRenderingContext2D, but // we need to refactor it moving it to `HTMLCanvasElement` and supporting WebGLContext ImageDataOrHTMLImageElementOrHTMLCanvasElementOrHTMLVideoElement::HTMLCanvasElement(canvas) => { let canvas = canvas.r(); @@ -1170,7 +1169,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext { => unimplemented!(), }; - // TODO(ecoal95): Invert axis, convert colorspace, premultiply alpha if requested + // TODO(emilio): Invert axis, convert colorspace, premultiply alpha if requested let msg = CanvasWebGLMsg::TexImage2D(target, level, internal_format as i32, size.width, size.height, format, data_type, pixels); diff --git a/components/style/selector_matching.rs b/components/style/selector_matching.rs index 2321b953e4c..90748ed7be9 100644 --- a/components/style/selector_matching.rs +++ b/components/style/selector_matching.rs @@ -266,7 +266,7 @@ impl<Impl: SelectorImplExt> Stylist<Impl> { let map = match pseudo_element { Some(ref pseudo) => match self.pseudos_map.get(pseudo) { Some(map) => map, - // TODO(ecoal95): get non eagerly-cascaded pseudo-element rules here. + // TODO(emilio): get non eagerly-cascaded pseudo-element rules here. // Actually assume there are no rules applicable. None => return true, }, diff --git a/tests/wpt/web-platform-tests/XMLHttpRequest/OWNERS b/tests/wpt/web-platform-tests/XMLHttpRequest/OWNERS index 7a809e70f6c..27421d921a0 100644 --- a/tests/wpt/web-platform-tests/XMLHttpRequest/OWNERS +++ b/tests/wpt/web-platform-tests/XMLHttpRequest/OWNERS @@ -1,4 +1,4 @@ -@ecoal95 +@emilio @hallvors @kangxu @caitp |