diff options
| -rw-r--r-- | components/plugins/lib.rs | 1 | ||||
| -rw-r--r-- | components/plugins/lints.rs | 25 |
2 files changed, 25 insertions, 1 deletions
diff --git a/components/plugins/lib.rs b/components/plugins/lib.rs index 221de13d289..d4894963f8f 100644 --- a/components/plugins/lib.rs +++ b/components/plugins/lib.rs @@ -27,6 +27,7 @@ mod jstraceable; pub fn plugin_registrar(reg: &mut Registry) { reg.register_lint_pass(box lints::TransmutePass as LintPassObject); reg.register_lint_pass(box lints::UnrootedPass as LintPassObject); + reg.register_lint_pass(box lints::PrivatizePass as LintPassObject); reg.register_syntax_extension(intern("jstraceable"), Decorator(box jstraceable::expand_jstraceable)) } diff --git a/components/plugins/lints.rs b/components/plugins/lints.rs index 605240d74e9..01d6a81a7a8 100644 --- a/components/plugins/lints.rs +++ b/components/plugins/lints.rs @@ -2,7 +2,8 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use syntax::{ast, codemap, visit}; +use syntax::{ast, ast_util, codemap, visit}; +use syntax::ast::Public; use syntax::attr::AttrMetaMethods; use rustc::lint::{Context, LintPass, LintArray}; use rustc::middle::ty::expr_ty; @@ -14,9 +15,12 @@ declare_lint!(TRANSMUTE_TYPE_LINT, Allow, "Warn and report types being transmuted") declare_lint!(UNROOTED_MUST_ROOT, Deny, "Warn and report usage of unrooted jsmanaged objects") +declare_lint!(PRIVATIZE, Deny, + "Allows to enforce private fields for struct definitions") pub struct TransmutePass; pub struct UnrootedPass; +pub struct PrivatizePass; impl LintPass for TransmutePass { fn get_lints(&self) -> LintArray { @@ -146,3 +150,22 @@ impl LintPass for UnrootedPass { } } +impl LintPass for PrivatizePass { + fn get_lints(&self) -> LintArray { + lint_array!(PRIVATIZE) + } + + fn check_struct_def(&mut self, cx: &Context, def: &ast::StructDef, _i: ast::Ident, _gen: &ast::Generics, id: ast::NodeId) { + if ty::has_attr(cx.tcx, ast_util::local_def(id), "privatize") { + for field in def.fields.iter() { + match field.node { + ast::StructField_ { kind: ast::NamedField(ident, visibility), .. } if visibility == Public => { + cx.span_lint(PRIVATIZE, field.span, + format!("Field {} is public where only private fields are allowed", ident.name).as_slice()); + } + _ => {} + } + } + } + } +} |