diff options
| -rw-r--r-- | README.md | 5 | ||||
| -rw-r--r-- | python/servo/build_commands.py | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/README.md b/README.md index 1553e0494b6..aecf062357d 100644 --- a/README.md +++ b/README.md @@ -194,6 +194,11 @@ export LIBCLANG_PATH=$(llvm-config --prefix)/lib64 You should change the installation to install the "Add python.exe to Path" feature. +You will also need to set the `PYTHON2` environment variable, e.g., to 'C:\Python27\python.exe' by doing: +``` +setx PYTHON2 "C:\Python27\python.exe" /m +``` + 2. Install Python 3.7 for Windows (https://www.python.org/downloads/release/python-374/). The Windows x86-64 MSI installer is fine. This is required in order to build the JavaScript engine, SpiderMonkey. You will also need to set the `PYTHON3` environment variable, e.g., to 'C:\Python37\python.exe' by doing: diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index 2aa70862fd6..e6b2cd6722a 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -972,7 +972,7 @@ def package_msvc_dlls(servo_exe_dir, target, vcinstalldir, vs_version): if os.path.isdir(redist_dir): for p in os.listdir(redist_dir)[::-1]: redist_path = path.join(redist_dir, p) - for v in ["VC141", "VC150", "VC160"]: + for v in ["VC141", "VC142", "VC150", "VC160"]: # there are two possible paths # `x64\Microsoft.VC*.CRT` or `onecore\x64\Microsoft.VC*.CRT` redist1 = path.join(redist_path, vs_platform, "Microsoft.{}.CRT".format(v)) |