auto merge of #4157 : nkdalmia/servo/master, r=jdm

Changes
* Implemented Storage Task
* Used Storage Task in methods of storage.rs
* Updated webstorage test expectations

Pending Changes:
* Handle Storage Event
* Throw QuotaExceededError in case of failure for method setItem
* localStorage as alias of sessionStorage

19 files changed, 47 insertions, 86 deletions

diff --git a/tests/wpt/metadata/html/dom/interfaces.html.ini b/tests/wpt/metadata/html/dom/interfaces.html.ini
index f0bef32d71f..cce96dfbdd2 100644
--- a/tests/wpt/metadata/html/dom/interfaces.html.ini
+++ b/tests/wpt/metadata/html/dom/interfaces.html.ini
@@ -8184,9 +8184,6 @@
   [Window interface: operation createImageBitmap(ImageBitmapSource,long,long,long,long)]
     expected: FAIL
 
-  [Window interface: attribute sessionStorage]
-    expected: FAIL
-
   [Window interface: attribute localStorage]
     expected: FAIL
 
@@ -8526,9 +8523,6 @@
   [Window interface: calling createImageBitmap(ImageBitmapSource,long,long,long,long) on window with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Window interface: window must inherit property "sessionStorage" with the proper type (123)]
-    expected: FAIL
-
   [Window interface: window must inherit property "localStorage" with the proper type (124)]
     expected: FAIL
 
@@ -9477,12 +9471,6 @@
   [Storage interface object length]
     expected: FAIL
 
-  [Storage interface: operation setItem(DOMString,DOMString)]
-    expected: FAIL
-
-  [Storage interface: operation removeItem(DOMString)]
-    expected: FAIL
-
   [StorageEvent interface: existence and properties of interface object]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/event_session_key.html.ini b/tests/wpt/metadata/webstorage/event_session_key.html.ini
index 744fb3e5420..47db65f5a6a 100644
--- a/tests/wpt/metadata/webstorage/event_session_key.html.ini
+++ b/tests/wpt/metadata/webstorage/event_session_key.html.ini
@@ -1,5 +1,3 @@
 [event_session_key.html]
   type: testharness
-  [Web Storage]
-    expected: FAIL
-
+  expected: TIMEOUT
diff --git a/tests/wpt/metadata/webstorage/event_session_newvalue.html.ini b/tests/wpt/metadata/webstorage/event_session_newvalue.html.ini
index b0e75796bbe..93223915309 100644
--- a/tests/wpt/metadata/webstorage/event_session_newvalue.html.ini
+++ b/tests/wpt/metadata/webstorage/event_session_newvalue.html.ini
@@ -1,5 +1,3 @@
 [event_session_newvalue.html]
   type: testharness
-  [Web Storage]
-    expected: FAIL
-
+  expected: TIMEOUT
diff --git a/tests/wpt/metadata/webstorage/event_session_oldvalue.html.ini b/tests/wpt/metadata/webstorage/event_session_oldvalue.html.ini
index 09faee86260..5696c9f23d2 100644
--- a/tests/wpt/metadata/webstorage/event_session_oldvalue.html.ini
+++ b/tests/wpt/metadata/webstorage/event_session_oldvalue.html.ini
@@ -1,5 +1,3 @@
 [event_session_oldvalue.html]
   type: testharness
-  [Web Storage]
-    expected: FAIL
-
+  expected: TIMEOUT
diff --git a/tests/wpt/metadata/webstorage/event_session_url.html.ini b/tests/wpt/metadata/webstorage/event_session_url.html.ini
index 0658a4316b5..13b6f17e586 100644
--- a/tests/wpt/metadata/webstorage/event_session_url.html.ini
+++ b/tests/wpt/metadata/webstorage/event_session_url.html.ini
@@ -1,5 +1,3 @@
 [event_session_url.html]
   type: testharness
-  [Web Storage]
-    expected: FAIL
-
+  expected: TIMEOUT
diff --git a/tests/wpt/metadata/webstorage/idlharness.html.ini b/tests/wpt/metadata/webstorage/idlharness.html.ini
index 3ece3937848..98e57ecd0ea 100644
--- a/tests/wpt/metadata/webstorage/idlharness.html.ini
+++ b/tests/wpt/metadata/webstorage/idlharness.html.ini
@@ -1,20 +1,11 @@
 [idlharness.html]
   type: testharness
-  [Window interface: attribute sessionStorage]
-    expected: FAIL
-
   [Window interface: attribute localStorage]
     expected: FAIL
 
   [Storage interface object length]
     expected: FAIL
 
-  [Storage interface: operation setItem(DOMString,DOMString)]
-    expected: FAIL
-
-  [Storage interface: operation removeItem(DOMString)]
-    expected: FAIL
-
   [Storage must be primary interface of window.localStorage]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/missing_arguments.html.ini b/tests/wpt/metadata/webstorage/missing_arguments.html.ini
index 5df976e4d8e..f77922a2628 100644
--- a/tests/wpt/metadata/webstorage/missing_arguments.html.ini
+++ b/tests/wpt/metadata/webstorage/missing_arguments.html.ini
@@ -15,21 +15,6 @@
   [Should throw TypeError for function "function () { localStorage.removeItem(); }".]
     expected: FAIL
 
-  [Should throw TypeError for function "function () { sessionStorage.key(); }".]
-    expected: FAIL
-
-  [Should throw TypeError for function "function () { sessionStorage.getItem(); }".]
-    expected: FAIL
-
-  [Should throw TypeError for function "function () { sessionStorage.setItem(); }".]
-    expected: FAIL
-
-  [Should throw TypeError for function "function () { sessionStorage.setItem("a"); }".]
-    expected: FAIL
-
-  [Should throw TypeError for function "function () { sessionStorage.removeItem(); }".]
-    expected: FAIL
-
   [Should throw TypeError for function "function () { new StorageEvent(); }".]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/storage_session_builtins.html.ini b/tests/wpt/metadata/webstorage/storage_session_builtins.html.ini
index f1e681fce43..2f37223fd76 100644
--- a/tests/wpt/metadata/webstorage/storage_session_builtins.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_session_builtins.html.ini
@@ -1,3 +1,5 @@
 [storage_session_builtins.html]
   type: testharness
-  expected: TIMEOUT
+  [Web Storage]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/webstorage/storage_session_clear.html.ini b/tests/wpt/metadata/webstorage/storage_session_clear.html.ini
deleted file mode 100644
index 64d98e868f8..00000000000
--- a/tests/wpt/metadata/webstorage/storage_session_clear.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[storage_session_clear.html]
-  type: testharness
-  [Web Storage]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/webstorage/storage_session_getitem.html.ini b/tests/wpt/metadata/webstorage/storage_session_getitem.html.ini
deleted file mode 100644
index 9891afe2bb2..00000000000
--- a/tests/wpt/metadata/webstorage/storage_session_getitem.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[storage_session_getitem.html]
-  type: testharness
-  [Web Storage]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini
index eb7d3891af6..bfa36046966 100644
--- a/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_session_getitem_js.html.ini
@@ -1,5 +1,5 @@
 [storage_session_getitem_js.html]
   type: testharness
-  [Web Storage]
+  [array access should be correct]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/storage_session_in_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_in_js.html.ini
index 17621fad1fe..9f51d1c2155 100644
--- a/tests/wpt/metadata/webstorage/storage_session_in_js.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_session_in_js.html.ini
@@ -1,8 +1,5 @@
 [storage_session_in_js.html]
   type: testharness
-  [Web Storage]
-    expected: FAIL
-
   [Web Storage 1]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/storage_session_index_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_index_js.html.ini
index 5591659dc27..3493e816e5a 100644
--- a/tests/wpt/metadata/webstorage/storage_session_index_js.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_session_index_js.html.ini
@@ -1,5 +1,5 @@
 [storage_session_index_js.html]
   type: testharness
-  [Web Storage]
+  [Web Storage 3]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/storage_session_key.html.ini b/tests/wpt/metadata/webstorage/storage_session_key.html.ini
deleted file mode 100644
index facca59931a..00000000000
--- a/tests/wpt/metadata/webstorage/storage_session_key.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[storage_session_key.html]
-  type: testharness
-  [Web Storage]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/webstorage/storage_session_length.html.ini b/tests/wpt/metadata/webstorage/storage_session_length.html.ini
deleted file mode 100644
index 5c12a356ac8..00000000000
--- a/tests/wpt/metadata/webstorage/storage_session_length.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[storage_session_length.html]
-  type: testharness
-  [Web Storage]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/webstorage/storage_session_removeitem.html.ini b/tests/wpt/metadata/webstorage/storage_session_removeitem.html.ini
deleted file mode 100644
index d06c9fc96af..00000000000
--- a/tests/wpt/metadata/webstorage/storage_session_removeitem.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[storage_session_removeitem.html]
-  type: testharness
-  [Web Storage]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/webstorage/storage_session_removeitem_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_removeitem_js.html.ini
index e5660e2834f..8567a6f56bb 100644
--- a/tests/wpt/metadata/webstorage/storage_session_removeitem_js.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_session_removeitem_js.html.ini
@@ -1,5 +1,5 @@
 [storage_session_removeitem_js.html]
   type: testharness
-  [Web Storage]
+  [Web Storage 1]
     expected: FAIL
 
diff --git a/tests/wpt/metadata/webstorage/storage_session_setitem.html.ini b/tests/wpt/metadata/webstorage/storage_session_setitem.html.ini
deleted file mode 100644
index 7214b6860ef..00000000000
--- a/tests/wpt/metadata/webstorage/storage_session_setitem.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[storage_session_setitem.html]
-  type: testharness
-  [Web Storage]
-    expected: FAIL
-
diff --git a/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini b/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini
index 4c75248ed6e..7486cce7dc6 100644
--- a/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini
+++ b/tests/wpt/metadata/webstorage/storage_session_setitem_js.html.ini
@@ -1,5 +1,41 @@
 [storage_session_setitem_js.html]
   type: testharness
-  [Web Storage]
+  [Web Storage 2]
+    expected: FAIL
+
+  [Web Storage 3]
+    expected: FAIL
+
+  [Web Storage 4]
+    expected: FAIL
+
+  [Web Storage 5]
+    expected: FAIL
+
+  [Web Storage 6]
+    expected: FAIL
+
+  [Web Storage 7]
+    expected: FAIL
+
+  [Web Storage 8]
+    expected: FAIL
+
+  [Web Storage 9]
+    expected: FAIL
+
+  [Web Storage 10]
+    expected: FAIL
+
+  [Web Storage 11]
+    expected: FAIL
+
+  [Web Storage 12]
+    expected: FAIL
+
+  [Web Storage 13]
+    expected: FAIL
+
+  [Web Storage 14]
     expected: FAIL