diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-10-16 04:50:43 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-16 04:50:43 -0400 |
| commit | 4625160f0af794e2675e8a81389c44dfa291c3d5 (patch) | |
| tree | b284870acd802cd886d921afdb34eaf31a24a5d0 /support/magicleap/Servo2D/code | |
| parent | 9ea4ca448a4c663ffa2320ca4ef63d709f2c21a6 (diff) | |
| parent | 1538587f2fc59d354c05d7af589697d67dd77586 (diff) | |
| download | servo-4625160f0af794e2675e8a81389c44dfa291c3d5.tar.gz servo-4625160f0af794e2675e8a81389c44dfa291c3d5.zip | |
Auto merge of #21882 - dguenther:update-document-open, r=nox
Update document.open to latest spec
<!-- Please describe your changes on the following line: -->
This is one of my first contributions, so I might need some direction cleaning it up -- I ran web-platform-tests locally, but the suite has several intermittent passes/failures for me. Thanks!
Few notes:
* I may have been wrong to eliminate all of the resets listed in what was formerly Step 18 (starts with `self.implementation.set(None);`). It's not clear to me that they're still needed or if so, what step they would fall under, but I didn't notice any web platform tests break as a result.
* <s>If I'm reading the spec right, there's a discrepancy in the error returned by the three-parameter overload of Document.open between the spec and web-platform-tests/implementations in other browsers. As written, I favored the spec, but it causes one web-platform-test to fail.</s> This has been resolved in https://github.com/whatwg/html/pull/4066
* I'm not 100% certain that tests pass as expected, I had several intermittent failures that disappeared when re-run.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21445
<!-- Either: -->
- [x] There are tests for these changes (existing web-platform-tests)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21882)
<!-- Reviewable:end -->
Diffstat (limited to 'support/magicleap/Servo2D/code')
0 files changed, 0 insertions, 0 deletions