diff options
author | Gae24 <96017547+Gae24@users.noreply.github.com> | 2024-06-10 12:03:07 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-10 10:03:07 +0000 |
commit | e6ea4a9c298c02138938c27851ccf9cca0523f67 (patch) | |
tree | afadb8bec7f8a3e774ff79e5982b2b6df21bfd9b /support/android | |
parent | 6f414df867cb8aea02dbc7009000096c17eeb3ab (diff) | |
download | servo-e6ea4a9c298c02138938c27851ccf9cca0523f67.tar.gz servo-e6ea4a9c298c02138938c27851ccf9cca0523f67.zip |
Android: fix url resolution (#32422)
* fix localhost
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
* android: parse search bar field in rust
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
* Update comment to reflect new function behavior
---------
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Diffstat (limited to 'support/android')
-rw-r--r-- | support/android/apk/servoapp/src/main/java/org/mozilla/servo/MainActivity.java | 32 | ||||
-rw-r--r-- | support/android/apk/servoview/src/main/java/org/mozilla/servoview/ServoView.java | 6 |
2 files changed, 15 insertions, 23 deletions
diff --git a/support/android/apk/servoapp/src/main/java/org/mozilla/servo/MainActivity.java b/support/android/apk/servoapp/src/main/java/org/mozilla/servo/MainActivity.java index ccdfb1dcd9c..13b1985ad51 100644 --- a/support/android/apk/servoapp/src/main/java/org/mozilla/servo/MainActivity.java +++ b/support/android/apk/servoapp/src/main/java/org/mozilla/servo/MainActivity.java @@ -17,7 +17,6 @@ import android.util.Log; import android.view.View; import android.view.inputmethod.EditorInfo; import android.view.inputmethod.InputMethodManager; -import android.webkit.URLUtil; import android.widget.Button; import android.widget.EditText; import android.widget.ProgressBar; @@ -79,7 +78,7 @@ public class MainActivity extends Activity implements Servo.Client { mServoView.setServoArgs(args, log); if (Intent.ACTION_VIEW.equals(intent.getAction())) { - mServoView.loadUri(intent.getData()); + mServoView.loadUri(intent.getData().toString()); } setupUrlField(); } @@ -102,8 +101,9 @@ public class MainActivity extends Activity implements Servo.Client { return false; }); mUrlField.setOnFocusChangeListener((v, hasFocus) -> { - if(v.getId() == R.id.urlfield && !hasFocus) { - InputMethodManager imm = (InputMethodManager) getSystemService(Context.INPUT_METHOD_SERVICE); + if (v.getId() == R.id.urlfield && !hasFocus) { + InputMethodManager imm = + (InputMethodManager) getSystemService(Context.INPUT_METHOD_SERVICE); assert imm != null; imm.hideSoftInputFromWindow(v.getWindowToken(), 0); } @@ -113,41 +113,33 @@ public class MainActivity extends Activity implements Servo.Client { private void loadUrlFromField() { String text = mUrlField.getText().toString(); text = text.trim(); - String uri; - if (text.contains(" ") || !text.contains(".")) { - uri = URLUtil.composeSearchUrl(text, "https://duckduckgo.com/html/?q=%s", "%s"); - } else { - uri = URLUtil.guessUrl(text); - - if (uri.startsWith("http://") && !text.startsWith("http://")) { - uri = uri.replaceFirst("http://", "https://"); - } - } - - mServoView.loadUri(Uri.parse(uri)); + mServoView.loadUri(text); } // From activity_main.xml: public void onReloadClicked(View v) { mServoView.reload(); } + public void onBackClicked(View v) { mServoView.goBack(); } + public void onForwardClicked(View v) { mServoView.goForward(); } + public void onStopClicked(View v) { mServoView.stop(); } @Override public void onAlert(String message) { - AlertDialog.Builder builder = new AlertDialog.Builder(this); - builder.setMessage(message); - AlertDialog alert = builder.create(); - alert.show(); + AlertDialog.Builder builder = new AlertDialog.Builder(this); + builder.setMessage(message); + AlertDialog alert = builder.create(); + alert.show(); } @Override diff --git a/support/android/apk/servoview/src/main/java/org/mozilla/servoview/ServoView.java b/support/android/apk/servoview/src/main/java/org/mozilla/servoview/ServoView.java index 1ab99a43756..b9e6d47e64d 100644 --- a/support/android/apk/servoview/src/main/java/org/mozilla/servoview/ServoView.java +++ b/support/android/apk/servoview/src/main/java/org/mozilla/servoview/ServoView.java @@ -211,11 +211,11 @@ public class ServoView extends SurfaceView mServo.stop(); } - public void loadUri(Uri uri) { + public void loadUri(String uri) { if (mServo != null) { - mServo.loadUri(uri.toString()); + mServo.loadUri(uri); } else { - mInitialUri = uri.toString(); + mInitialUri = uri; } } |