diff options
author | Matt Brubeck <mbrubeck@limpet.net> | 2014-05-01 17:13:03 -0700 |
---|---|---|
committer | Matt Brubeck <mbrubeck@limpet.net> | 2014-05-02 09:30:57 -0700 |
commit | 4821df6216635f47d400a6aab4e7b5d7a4be8440 (patch) | |
tree | d1fc69f5e3107904befd86187577ad338d2a85c0 /src | |
parent | 8af9ce07f8ec9dddc926c1f76ade9e84427034db (diff) | |
download | servo-4821df6216635f47d400a6aab4e7b5d7a4be8440.tar.gz servo-4821df6216635f47d400a6aab4e7b5d7a4be8440.zip |
Replace Au::zero_* with generic methods
Diffstat (limited to 'src')
-rw-r--r-- | src/components/gfx/font.rs | 3 | ||||
-rw-r--r-- | src/components/gfx/text/glyph.rs | 7 | ||||
-rw-r--r-- | src/components/main/layout/block.rs | 3 | ||||
-rw-r--r-- | src/components/main/layout/box_.rs | 8 | ||||
-rw-r--r-- | src/components/main/layout/flow.rs | 4 | ||||
-rw-r--r-- | src/components/main/layout/layout_task.rs | 2 | ||||
-rw-r--r-- | src/components/util/geometry.rs | 25 | ||||
m--------- | src/support/geom/rust-geom | 0 |
8 files changed, 14 insertions, 38 deletions
diff --git a/src/components/gfx/font.rs b/src/components/gfx/font.rs index 3eac7a9362c..9f00a883098 100644 --- a/src/components/gfx/font.rs +++ b/src/components/gfx/font.rs @@ -7,6 +7,7 @@ use azure::azure_hl::{BackendType, ColorPattern}; use azure::scaled_font::ScaledFont; use geom::{Point2D, Rect, Size2D}; use std::cast; +use std::num::Zero; use std::ptr; use std::str; use std::rc::Rc; @@ -366,7 +367,7 @@ impl Font { for (glyphs, _offset, slice_range) in run.iter_slices_for_range(range) { for (_i, glyph) in glyphs.iter_glyphs_for_char_range(&slice_range) { let glyph_advance = glyph.advance(); - let glyph_offset = glyph.offset().unwrap_or(Au::zero_point()); + let glyph_offset = glyph.offset().unwrap_or(Zero::zero()); let azglyph = struct__AzGlyph { mIndex: glyph.index() as uint32_t, diff --git a/src/components/gfx/text/glyph.rs b/src/components/gfx/text/glyph.rs index 2559ada64d9..37cfd67a01e 100644 --- a/src/components/gfx/text/glyph.rs +++ b/src/components/gfx/text/glyph.rs @@ -5,10 +5,9 @@ use servo_util::vec::*; use servo_util::range::Range; use servo_util::geometry::Au; -use servo_util::geometry; use std::cmp::{Ord, Eq}; -use std::num::NumCast; +use std::num::{NumCast, Zero}; use std::mem; use std::u16; use std::slice; @@ -441,7 +440,7 @@ impl GlyphData { ligature_start: bool) -> GlyphData { let offset = match offset { - None => geometry::zero_point(), + None => Zero::zero(), Some(o) => o }; @@ -536,7 +535,7 @@ impl<'a> GlyphStore { fn glyph_is_compressible(data: &GlyphData) -> bool { is_simple_glyph_id(data.index) && is_simple_advance(data.advance) - && data.offset == geometry::zero_point() + && data.offset.is_zero() && data.cluster_start // others are stored in detail buffer } diff --git a/src/components/main/layout/block.rs b/src/components/main/layout/block.rs index 15113300249..b1579bee2a0 100644 --- a/src/components/main/layout/block.rs +++ b/src/components/main/layout/block.rs @@ -36,6 +36,7 @@ use servo_msg::compositor_msg::{FixedPosition, LayerId, Scrollable}; use servo_util::geometry::Au; use servo_util::geometry; use servo_util::smallvec::{SmallVec, SmallVec0}; +use std::num::Zero; use style::computed_values::{LPA_Auto, LPA_Length, LPA_Percentage, LPN_Length, LPN_None}; use style::computed_values::{LPN_Percentage, LP_Length, LP_Percentage}; use sync::Arc; @@ -1548,7 +1549,7 @@ impl Flow for BlockFlow { if self.is_root() { debug!("Setting root position"); - self.base.position.origin = Au::zero_point(); + self.base.position.origin = Zero::zero(); self.base.position.size.width = ctx.screen_size.width; self.base.floats = Floats::new(); // Root element is not floated diff --git a/src/components/main/layout/box_.rs b/src/components/main/layout/box_.rs index 9cfeca57578..014fb63a97f 100644 --- a/src/components/main/layout/box_.rs +++ b/src/components/main/layout/box_.rs @@ -430,7 +430,7 @@ impl Box { Box { node: OpaqueNodeMethods::from_thread_safe_layout_node(node), style: node.style().clone(), - border_box: RefCell::new(Au::zero_rect()), + border_box: RefCell::new(Rect::zero()), border: RefCell::new(Zero::zero()), padding: RefCell::new(Zero::zero()), margin: RefCell::new(Zero::zero()), @@ -446,7 +446,7 @@ impl Box { Box { node: OpaqueNodeMethods::from_thread_safe_layout_node(node), style: node.style().clone(), - border_box: RefCell::new(Au::zero_rect()), + border_box: RefCell::new(Rect::zero()), border: RefCell::new(Zero::zero()), padding: RefCell::new(Zero::zero()), margin: RefCell::new(Zero::zero()), @@ -473,7 +473,7 @@ impl Box { Box { node: OpaqueNodeMethods::from_thread_safe_layout_node(node), style: Arc::new(node_style), - border_box: RefCell::new(Au::zero_rect()), + border_box: RefCell::new(Rect::zero()), border: RefCell::new(Zero::zero()), padding: RefCell::new(Zero::zero()), margin: RefCell::new(Zero::zero()), @@ -492,7 +492,7 @@ impl Box { Box { node: node, style: style, - border_box: RefCell::new(Au::zero_rect()), + border_box: RefCell::new(Rect::zero()), border: RefCell::new(Zero::zero()), padding: RefCell::new(Zero::zero()), margin: RefCell::new(Zero::zero()), diff --git a/src/components/main/layout/flow.rs b/src/components/main/layout/flow.rs index 935701ff127..1114f676ba7 100644 --- a/src/components/main/layout/flow.rs +++ b/src/components/main/layout/flow.rs @@ -818,8 +818,8 @@ impl BaseFlow { prev_sibling: Rawlink::none(), intrinsic_widths: IntrinsicWidths::new(), - position: Au::zero_rect(), - overflow: Au::zero_rect(), + position: Rect::zero(), + overflow: Rect::zero(), parallel: FlowParallelInfo::new(), diff --git a/src/components/main/layout/layout_task.rs b/src/components/main/layout/layout_task.rs index 1a9b685a2a8..ec05eec152d 100644 --- a/src/components/main/layout/layout_task.rs +++ b/src/components/main/layout/layout_task.rs @@ -749,7 +749,7 @@ impl LayoutTask { union_boxes_for_node(&mut rect, display_list.iter(), node) } } - reply_chan.send(ContentBoxResponse(rect.unwrap_or(Au::zero_rect()))) + reply_chan.send(ContentBoxResponse(rect.unwrap_or(Rect::zero()))) } ContentBoxesQuery(node, reply_chan) => { let node: OpaqueNode = OpaqueNodeMethods::from_script_node(node); diff --git a/src/components/util/geometry.rs b/src/components/util/geometry.rs index 9b371c7565b..93a5adc832a 100644 --- a/src/components/util/geometry.rs +++ b/src/components/util/geometry.rs @@ -4,7 +4,6 @@ use geom::point::Point2D; use geom::rect::Rect; -use geom::size::Size2D; use std::num::{NumCast, One, Zero}; use std::fmt; @@ -153,17 +152,6 @@ impl Au { } #[inline] - pub fn zero_point() -> Point2D<Au> { - Point2D(Au(0), Au(0)) - } - - #[inline] - pub fn zero_rect() -> Rect<Au> { - let z = Au(0); - Rect(Point2D(z, z), Size2D(z, z)) - } - - #[inline] pub fn from_pt(pt: f64) -> Au { from_px(pt_to_px(pt) as int) } @@ -198,19 +186,6 @@ pub fn px_to_pt(px: f64) -> f64 { px / 96f64 * 72f64 } -pub fn zero_rect() -> Rect<Au> { - let z = Au(0); - Rect(Point2D(z, z), Size2D(z, z)) -} - -pub fn zero_point() -> Point2D<Au> { - Point2D(Au(0), Au(0)) -} - -pub fn zero_size() -> Size2D<Au> { - Size2D(Au(0), Au(0)) -} - pub fn from_frac_px(px: f64) -> Au { Au((px * 60f64) as i32) } diff --git a/src/support/geom/rust-geom b/src/support/geom/rust-geom -Subproject 8d67075e4affa75fc0872ebfdcc9b3ec8c6fe69 +Subproject ab55c3f4f6edab87fe5802c58866d1e4455232a |