diff options
author | bors-servo <release+servo@mozilla.com> | 2013-12-23 10:49:05 -0800 |
---|---|---|
committer | bors-servo <release+servo@mozilla.com> | 2013-12-23 10:49:05 -0800 |
commit | cb336a18317195512a276971856081cb8ef86b0e (patch) | |
tree | c0825aaf562a02471d15d9193840ea15870b5eed /src/components/script/script_task.rs | |
parent | acdc0e1afa166db978c36236c94fa139b3ca9a88 (diff) | |
parent | 95913d1fed59df431e584b66d2770664b383caab (diff) | |
download | servo-cb336a18317195512a276971856081cb8ef86b0e.tar.gz servo-cb336a18317195512a276971856081cb8ef86b0e.zip |
auto merge of #1438 : Ms2ger/servo/cleanup-get_attribute, r=jdm
Passing these around as strings is an anti-pattern, IMO.
Diffstat (limited to 'src/components/script/script_task.rs')
-rw-r--r-- | src/components/script/script_task.rs | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/components/script/script_task.rs b/src/components/script/script_task.rs index 38803bb4456..9400a519d92 100644 --- a/src/components/script/script_task.rs +++ b/src/components/script/script_task.rs @@ -13,6 +13,7 @@ use dom::event::{Event_, ResizeEvent, ReflowEvent, ClickEvent, MouseDownEvent, M use dom::event::Event; use dom::eventtarget::AbstractEventTarget; use dom::htmldocument::HTMLDocument; +use dom::namespace::Null; use dom::node::{AbstractNode, LayoutDataRef}; use dom::window::{TimerData, Window}; use html::hubbub_html_parser::HtmlParserResult; @@ -811,7 +812,7 @@ impl ScriptTask { let mut anchors = doc_node.traverse_preorder().filter(|node| node.is_anchor_element()); do anchors.find |node| { do node.with_imm_element |elem| { - match elem.get_attr(None, "name") { + match elem.get_attr(Null, "name") { Some(name) => eq_slice(name, fragid), None => false } @@ -910,7 +911,7 @@ impl ScriptTask { fn load_url_from_element(&self, page: @mut Page, element: &Element) { // if the node's element is "a," load url from href attr - let attr = element.get_attr(None, "href"); + let attr = element.get_attr(Null, "href"); for href in attr.iter() { debug!("ScriptTask: clicked on link to {:s}", *href); let click_frag = href.starts_with("#"); |