diff options
author | Tim Kuehn <tkuehn@cmu.edu> | 2013-07-29 15:35:26 -0700 |
---|---|---|
committer | Tim Kuehn <tkuehn@cmu.edu> | 2013-07-29 15:53:28 -0700 |
commit | 2b94dd6664d96f33b1224161fd7b07d824845831 (patch) | |
tree | 34db97744f3df634d480d41cd4dd8742eb8582a1 /src/components/script/script_task.rs | |
parent | ec30e97ddfc57416b50e34d3e506c8f1be66aa7e (diff) | |
download | servo-2b94dd6664d96f33b1224161fd7b07d824845831.tar.gz servo-2b94dd6664d96f33b1224161fd7b07d824845831.zip |
remove unused arg from script_task::handle_navigate_msg
remove unnecessary commented-out code
Diffstat (limited to 'src/components/script/script_task.rs')
-rw-r--r-- | src/components/script/script_task.rs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/components/script/script_task.rs b/src/components/script/script_task.rs index 42939cbb16e..4a93901bc34 100644 --- a/src/components/script/script_task.rs +++ b/src/components/script/script_task.rs @@ -61,7 +61,7 @@ pub enum ScriptMsg { /// Executes a standalone script. ExecuteMsg(PipelineId, Url), /// Instructs the script task to send a navigate message to the constellation. - NavigateMsg(PipelineId, NavigationDirection), + NavigateMsg(NavigationDirection), /// Sends a DOM event. SendEventMsg(PipelineId, Event), /// Fires a JavaScript timeout. @@ -450,7 +450,7 @@ impl ScriptTask { ExecuteMsg(id, url) => self.handle_execute_msg(id, url), SendEventMsg(id, event) => self.handle_event(id, event), FireTimerMsg(id, timer_data) => self.handle_fire_timer_msg(id, timer_data), - NavigateMsg(id, direction) => self.handle_navigate_msg(id, direction), + NavigateMsg(direction) => self.handle_navigate_msg(direction), ReflowCompleteMsg(id) => self.handle_reflow_complete_msg(id), ResizeInactiveMsg(new_size) => self.handle_resize_inactive_msg(new_size), ExitMsg => { @@ -535,7 +535,8 @@ impl ScriptTask { } /// Handles a navigate forward or backward message. - fn handle_navigate_msg(&self, pipeline_id: PipelineId, direction: NavigationDirection) { + /// TODO(tkuehn): is it ever possible to navigate only on a subframe? + fn handle_navigate_msg(&self, direction: NavigationDirection) { self.constellation_chan.send(constellation_msg::NavigateMsg(direction)); } @@ -582,7 +583,6 @@ impl ScriptTask { // Define the script DOM bindings. // // FIXME: Can this be done earlier, to save the flag? - //let js_info = page.js_info.get_ref(); if !js_info.bindings_initialized { define_bindings(js_info.js_compartment); js_info.bindings_initialized = true; @@ -718,7 +718,7 @@ impl ScriptTask { } } - ClickEvent(page_button, point) => { + ClickEvent(_button, point) => { debug!("ClickEvent: clicked at %?", point); let root = page.frame.expect("root frame is None").document.root; |