aboutsummaryrefslogtreecommitdiffstats
path: root/src/components/script/dom/htmltableelement.rs
diff options
context:
space:
mode:
authorbors-servo <release+servo@mozilla.com>2013-09-17 17:04:13 -0700
committerbors-servo <release+servo@mozilla.com>2013-09-17 17:04:13 -0700
commit1bc68f7effdb4f0629072969d2ad8e76c5aadff9 (patch)
tree094d8e54c73c4964bca4d69014d14859c0c02f46 /src/components/script/dom/htmltableelement.rs
parentb77c3eaaa0f926e3deca9043950ab63196b3246b (diff)
parentd6141edfd449333c50e00833ad6476604bf50ceb (diff)
downloadservo-1bc68f7effdb4f0629072969d2ad8e76c5aadff9.tar.gz
servo-1bc68f7effdb4f0629072969d2ad8e76c5aadff9.zip
auto merge of #944 : larsbergstrom/servo/iframe_display, r=pcwalton
The quadtree was checking to see if a window's position was within the clip region before drawing it. However, the window's position is in page-relative coordinates whereas the clip region is in window-relative coordinates. So, unless the iframe happened to fall in the clip range, it would never have tiles returned. If an iframe had enough content that it spilled outside of its clip range, different logic was triggered that would cause it to receive a ReRenderMsg anyway, which circumvented all of this. @eschweic, can you please review this if you have a minute? I believe that I've correctly captured the four checks we want to make (two each for ```x``` and ```y``` directions to determine if the window is in or out, but I'd appreciate another set of eyes on it. For some example data, in a call to ```get_tile_rects``` for an iframe that is sized to 400x400 and is 428-ish pixels down the page, with a browser frame that is 600 total pixels tall, that function is called with: window origin geom::point::Point2D<f32>{x: 9f32, y: 428.6000061f32} window size geom::size::Size2D<f32>{width: 400f32, height: 171.3999939f32} self origin geom::point::Point2D<f32>{x: 0f32, y: 0f32} self size 512f32" clip: size::Size2D<f32>{width: 400f32, height: 400f32}
Diffstat (limited to 'src/components/script/dom/htmltableelement.rs')
0 files changed, 0 insertions, 0 deletions