diff options
author | Josh Matthews <josh@joshmatthews.net> | 2014-03-31 18:41:28 -0400 |
---|---|---|
committer | Josh Matthews <josh@joshmatthews.net> | 2014-05-03 14:18:30 -0400 |
commit | d7b96db33ca8f2b8a162df38e0f00e95f5ea6fa1 (patch) | |
tree | efd1e7f7ec1dd30467c2a67306e1a639837abead /src/components/script/dom/htmlelement.rs | |
parent | ffdc3f5b32a345b88eed774848924e862d47c093 (diff) | |
download | servo-d7b96db33ca8f2b8a162df38e0f00e95f5ea6fa1.tar.gz servo-d7b96db33ca8f2b8a162df38e0f00e95f5ea6fa1.zip |
Implement safe rooting strategy via Unrooted, Root, JSRef, and JS.
Diffstat (limited to 'src/components/script/dom/htmlelement.rs')
-rw-r--r-- | src/components/script/dom/htmlelement.rs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/components/script/dom/htmlelement.rs b/src/components/script/dom/htmlelement.rs index a7852aec276..d49ce843bd1 100644 --- a/src/components/script/dom/htmlelement.rs +++ b/src/components/script/dom/htmlelement.rs @@ -5,7 +5,7 @@ use dom::bindings::codegen::BindingDeclarations::HTMLElementBinding; use dom::bindings::codegen::InheritTypes::ElementCast; use dom::bindings::codegen::InheritTypes::HTMLElementDerived; -use dom::bindings::js::{JS, JSRef}; +use dom::bindings::js::{JS, JSRef, Unrooted}; use dom::bindings::error::{ErrorResult, Fallible}; use dom::document::Document; use dom::element::{Element, ElementTypeId, HTMLElementTypeId}; @@ -39,7 +39,7 @@ impl HTMLElement { } } - pub fn new(localName: DOMString, document: &JSRef<Document>) -> JS<HTMLElement> { + pub fn new(localName: DOMString, document: &JSRef<Document>) -> Unrooted<HTMLElement> { let element = HTMLElement::new_inherited(HTMLElementTypeId, localName, document.unrooted()); Node::reflect_node(~element, document, HTMLElementBinding::Wrap) } @@ -143,7 +143,7 @@ impl HTMLElement { Ok(()) } - pub fn GetOffsetParent(&self) -> Option<JS<Element>> { + pub fn GetOffsetParent(&self) -> Option<Unrooted<Element>> { None } @@ -164,9 +164,9 @@ impl HTMLElement { } } -impl VirtualMethods for JS<HTMLElement> { +impl<'a> VirtualMethods for JSRef<'a, HTMLElement> { fn super_type(&self) -> Option<~VirtualMethods:> { - let element: JS<Element> = ElementCast::from(self); - Some(~element as ~VirtualMethods:) + let element: &JSRef<Element> = ElementCast::from_ref(self); + Some(~element.clone() as ~VirtualMethods:) } } |