Remove the pointless terminator from ConstantSpec slices.

1 files changed, 6 insertions, 13 deletions

diff --git a/src/components/script/dom/bindings/utils.rs b/src/components/script/dom/bindings/utils.rs
index c7020823273..f6e9a1e1ba6 100644
--- a/src/components/script/dom/bindings/utils.rs
+++ b/src/components/script/dom/bindings/utils.rs
@@ -312,10 +312,8 @@ fn CreateInterfaceObject(cx: *mut JSContext, global: *mut JSObject, receiver: *m
 }
 
 fn DefineConstants(cx: *mut JSContext, obj: *mut JSObject, constants: &'static [ConstantSpec]) -> bool {
-    for spec in constants.iter() {
-        if spec.name.is_null() {
-            return true;
-        }
+    constants.iter().all(|spec| {
+        assert!(spec.name.is_not_null());
         let jsval = match spec.value {
             NullVal => NullValue(),
             IntVal(i) => Int32Value(i),
@@ -325,16 +323,11 @@ fn DefineConstants(cx: *mut JSContext, obj: *mut JSObject, constants: &'static [
             VoidVal => UndefinedValue(),
         };
         unsafe {
-            if JS_DefineProperty(cx, obj, spec.name,
-                                 jsval, None,
-                                 None,
-                                 JSPROP_ENUMERATE | JSPROP_READONLY |
-                                 JSPROP_PERMANENT) == 0 {
-                return false;
-            }
+            JS_DefineProperty(cx, obj, spec.name, jsval, None, None,
+                              JSPROP_ENUMERATE | JSPROP_READONLY |
+                              JSPROP_PERMANENT) != 0
         }
-    }
-    fail!();
+    })
 }
 
 fn DefineMethods(cx: *mut JSContext, obj: *mut JSObject, methods: &'static [JSFunctionSpec]) -> bool {