diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-04-24 19:41:32 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-04-24 19:41:32 -0400 |
commit | 9c6d9f612eab36e1c3a88f7ef72f2d9b699b563d (patch) | |
tree | ee84a42c8051258488a638f58722b6ed18b91482 /servo-tidy.toml | |
parent | 4f4fb32264ab94406c189471e9ec753a06011b23 (diff) | |
parent | 8c9aca2ea336270aa2d2e18e30b672af6db03136 (diff) | |
download | servo-9c6d9f612eab36e1c3a88f7ef72f2d9b699b563d.tar.gz servo-9c6d9f612eab36e1c3a88f7ef72f2d9b699b563d.zip |
Auto merge of #20687 - kwonoj:fix-capture-wr-guard, r=KiChjang
fix(browser): do not omit unexpected keyevent
<!-- Please describe your changes on the following line: -->
- closes #20681
This PR intends to fix regression caused by changes I created in #20315. In code, it matches keyevent aggressively for any pattern includes `Some('3')`, ends up actual key event does not bubbles up. This PR applies correct pattern guard to pick up specific keyevent only, other events falls back to default patterns.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20681 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- manually verified
1. typing `3` in input field works
2. ctrl-shift-3 create webrender capture (verified on mac os)
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20687)
<!-- Reviewable:end -->
Diffstat (limited to 'servo-tidy.toml')
0 files changed, 0 insertions, 0 deletions