diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-11-06 11:30:26 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-11-06 11:30:26 -0500 |
| commit | 8df38f5e29d0005b792d403c3c54d35748448100 (patch) | |
| tree | f13c673108b6a21b7ed25d39ab4310101df005b5 /python | |
| parent | 32d97d695e7aaf8fea9003dc1e4ef69e6f645ffb (diff) | |
| parent | 357f23fae1dff82eac983137b4e80f66d48bfa91 (diff) | |
| download | servo-8df38f5e29d0005b792d403c3c54d35748448100.tar.gz servo-8df38f5e29d0005b792d403c3c54d35748448100.zip | |
Auto merge of #22122 - Darkspirit:httpsdeps, r=jdm
Consistent servo-deps download URL
This PR ensures consistent https:// downloads for Servo dependencies.
It should be fine because
* https://servo-deps.s3.amazonaws.com is already used for MSVC deps:
https://github.com/servo/servo/blob/e217672c1ab665a68aca36bb5086956254604e75/python/servo/bootstrap.py#L286
* .travis.yml already downloads from [another https url](https://github.com/servo/servo/blob/e217672c1ab665a68aca36bb5086956254604e75/.travis.yml#L28) (https://sh.rustup.rs).
* In #22088 I saw the gstreamer dependency being download via https.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22122)
<!-- Reviewable:end -->
Diffstat (limited to 'python')
| -rw-r--r-- | python/servo/build_commands.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index b6aa53bf15e..ab9c769fb9f 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -437,7 +437,7 @@ class MachCommands(CommandBase): # Follow these instructions to build and deploy new binaries # https://github.com/servo/libgstreamer_android_gen#build print("Downloading GStreamer dependencies") - gst_url = "http://servo-deps.s3.amazonaws.com/gstreamer/%s" % gst_lib_zip + gst_url = "https://servo-deps.s3.amazonaws.com/gstreamer/%s" % gst_lib_zip print(gst_url) urllib.urlretrieve(gst_url, gst_lib_zip) zip_ref = zipfile.ZipFile(gst_lib_zip, "r") |