aboutsummaryrefslogtreecommitdiffstats
path: root/python
diff options
context:
space:
mode:
authorMs2ger <ms2ger@gmail.com>2015-01-19 13:40:29 +0100
committerMs2ger <ms2ger@gmail.com>2015-01-19 13:48:32 +0100
commit394f8163433559cea294cb4a4e335cc43ccde1fe (patch)
tree152db85a8df8c3e01dc881f62b66adbf2e8617f6 /python
parent60a901328acb871c7cdad64e14777b91dc61cb05 (diff)
downloadservo-394f8163433559cea294cb4a4e335cc43ccde1fe.tar.gz
servo-394f8163433559cea294cb4a4e335cc43ccde1fe.zip
Disallow lines that span more than 160 columns.
The Rust style guide suggests 100, but we have too many violations in the tree already. This check can be tightened over time.
Diffstat (limited to 'python')
-rw-r--r--python/tidy.py9
1 files changed, 8 insertions, 1 deletions
diff --git a/python/tidy.py b/python/tidy.py
index da930eea333..fc282aaa464 100644
--- a/python/tidy.py
+++ b/python/tidy.py
@@ -56,6 +56,13 @@ def check_license(contents):
yield (1, "incorrect license")
+def check_length(contents):
+ lines = contents.splitlines(True)
+ for idx, line in enumerate(lines):
+ if len(line) >= 160:
+ yield (idx + 1, "(much) overlong line")
+
+
def check_whitespace(contents):
lines = contents.splitlines(True)
for idx, line in enumerate(lines):
@@ -88,7 +95,7 @@ def scan():
all_files = collect_file_names(directories_to_check)
files_to_check = filter(should_check, all_files)
- checking_functions = [check_license, check_whitespace]
+ checking_functions = [check_license, check_length, check_whitespace]
errors = collect_errors_for_files(files_to_check, checking_functions)
errors = list(errors)