aboutsummaryrefslogtreecommitdiffstats
path: root/python
diff options
context:
space:
mode:
authorbors-servo <infra@servo.org>2023-07-01 17:33:20 +0200
committerGitHub <noreply@github.com>2023-07-01 17:33:20 +0200
commitc41334ee3d76631de703d9fdb65b58c7144234bc (patch)
tree2fbaff0513c1a1b938d66c6b3f21e449bd85cf68 /python
parent82b37df3be757cb2c7d1fc58f5e628941d3926e5 (diff)
parente681e2b3f3e91b4dd6e0112263e976fcb22e8c83 (diff)
downloadservo-c41334ee3d76631de703d9fdb65b58c7144234bc.tar.gz
servo-c41334ee3d76631de703d9fdb65b58c7144234bc.zip
Auto merge of #29955 - servo:windows-subsystem, r=jdm
Set the Windows subsystem using a rust directive This is one less thing that mach has to do now. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they do not change behavior. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'python')
-rw-r--r--python/servo/build_commands.py5
1 files changed, 0 insertions, 5 deletions
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py
index d56246f9c1d..9fbdac6a1c0 100644
--- a/python/servo/build_commands.py
+++ b/python/servo/build_commands.py
@@ -425,11 +425,6 @@ class MachCommands(CommandBase):
)
assert os.path.exists(servo_exe_dir)
- # on msvc builds, use editbin to change the subsystem to windows, but only
- # on release builds -- on debug builds, it hides log output
- if not dev and not libsimpleservo:
- call(["editbin", "/nologo", "/subsystem:windows", path.join(servo_exe_dir, "servo.exe")],
- verbose=verbose)
# on msvc, we need to copy in some DLLs in to the servo.exe dir and the directory for unit tests.
for ssl_lib in ["libssl.dll", "libcrypto.dll"]:
ssl_path = path.join(env['OPENSSL_LIB_DIR'], "../bin", ssl_lib)