aboutsummaryrefslogtreecommitdiffstats
path: root/python
diff options
context:
space:
mode:
authorPaul Rouget <me@paulrouget.com>2019-11-04 12:44:52 +0100
committerPaul Rouget <me@paulrouget.com>2019-11-04 12:44:52 +0100
commitb1753fea2de8ee4ba33bbc6b8b1f583508f9663e (patch)
tree5cd4ffbe03bcdcb055033b0f7b74cf1fd898f6f3 /python
parentf626355b67fc007d5961c446d5a4ddbcc3785698 (diff)
downloadservo-b1753fea2de8ee4ba33bbc6b8b1f583508f9663e.tar.gz
servo-b1753fea2de8ee4ba33bbc6b8b1f583508f9663e.zip
remove allfiles option for clang-format
Diffstat (limited to 'python')
-rw-r--r--python/servo/testing_commands.py8
1 files changed, 3 insertions, 5 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py
index 53e7c3c901f..1aa2b0961e5 100644
--- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -341,7 +341,7 @@ class MachCommands(CommandBase):
clangfmt_failed = False
if not no_cpp:
- available, cmd, files = setup_clangfmt(all_files)
+ available, cmd, files = setup_clangfmt()
if available:
for file in files:
stdout = subprocess.check_output([cmd, "-output-replacements-xml", file])
@@ -480,7 +480,7 @@ class MachCommands(CommandBase):
def format_code(self, no_cpp):
if not no_cpp:
- available, cmd, files = setup_clangfmt(True)
+ available, cmd, files = setup_clangfmt()
if available and len(files) > 0:
check_call([cmd, "-i"] + files)
@@ -797,7 +797,7 @@ def create_parser_create():
return p
-def setup_clangfmt(all_files):
+def setup_clangfmt():
cmd = "clang-format.exe" if sys.platform == "win32" else "clang-format"
try:
version = subprocess.check_output([cmd, "--version"]).rstrip()
@@ -809,8 +809,6 @@ def setup_clangfmt(all_files):
print("clang-format not installed. Skipping CPP formatting.")
return False, None, None
gitcmd = ['git', 'ls-files']
- if not all_files:
- gitcmd.append('-m')
gitfiles = subprocess.check_output(gitcmd + CLANGFMT_CPP_DIRS).splitlines()
filtered = [line for line in gitfiles if line.endswith(".h") or line.endswith(".cpp")]
return True, cmd, filtered