diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-12-02 20:18:05 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-12-02 20:18:05 -0800 |
commit | 7c346e0d943fd518031437bcc7d10fee16213ff3 (patch) | |
tree | dc8719aabc2a84efe0e07aad16a100d28752fcfe /python | |
parent | 106a538e7e2898902093a77307f004ab79a270d8 (diff) | |
parent | 6fec4d76456b303e3e47c15bb4628cd3647438ad (diff) | |
download | servo-7c346e0d943fd518031437bcc7d10fee16213ff3.tar.gz servo-7c346e0d943fd518031437bcc7d10fee16213ff3.zip |
Auto merge of #14421 - upsuper:patch-2, r=emilio
Treat top-level number in calc() invalid
<!-- Please describe your changes on the following line: -->
This should probably considered as a temporary fix (for [bug 1321206](https://bugzilla.mozilla.org/show_bug.cgi?id=1321206)), to avoid assertion when trying to serialize calc value with only numbers. Certain properties (e.g. `line-height`) would eventually need to keep numbers inside calc.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Currently, CalcLengthOrPercentage doesn't actually keep the number value. If we don't treat it invalid, we can end up generating empty `calc()` value when one contains numbers (e.g. `calc(1)`), which would violate assertion elsewhere that `calc` must not be empty.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14421)
<!-- Reviewable:end -->
Diffstat (limited to 'python')
0 files changed, 0 insertions, 0 deletions