diff options
| author | Corey Farwell <coreyf@rwell.org> | 2015-07-05 12:10:53 -0700 |
|---|---|---|
| committer | Corey Farwell <coreyf@rwell.org> | 2015-07-09 19:42:31 +0900 |
| commit | 0ec2375cabb69abbfd1014bfb68136fdea6edadb (patch) | |
| tree | 8a24a61ae92605810bdd7163aad10204833e9a99 /python | |
| parent | fe17067d6a30b85a0346fd1ccb2b95e2081e6962 (diff) | |
| download | servo-0ec2375cabb69abbfd1014bfb68136fdea6edadb.tar.gz servo-0ec2375cabb69abbfd1014bfb68136fdea6edadb.zip | |
Remove tidy blacklist for 'script/dom/bindings/*'
Recently, I found myself reading through the Python codegen scripts that
live in 'components/script/dom/bindings/*' and noticed that there were
many tidy violations: unnecessary semicolons, weird spacing, unused
variables, lack of license headers, etc. Considering these files are now
living in our tree and mostly maintained directly by contributors of
Servo (as opposed to being from upstream), I feel these files should not
be excluded from our normal tidy process. This commit removes the
blacklist on these files and fixes all tidy violations.
I added these subdirectories to the blacklist because they appear to be
maintained upstream somewhere else:
* "components/script/dom/bindings/codegen/parser/*",
* "components/script/dom/bindings/codegen/ply/*",
Also, I added a '# noqa' comment which tells us to ignore the
flake8 errors for that line. I chose to ignore this (instead of fixing
it) to make the work for this commit simpler for me.
Diffstat (limited to 'python')
| -rw-r--r-- | python/tidy.py | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/python/tidy.py b/python/tidy.py index 75b372995e1..c65425de01a 100644 --- a/python/tidy.py +++ b/python/tidy.py @@ -32,9 +32,10 @@ ignored_files = [ "python/mozinfo/*", "python/mozlog/*", "python/toml/*", + "components/script/dom/bindings/codegen/parser/*", + "components/script/dom/bindings/codegen/ply/*", # Generated and upstream code combined with our own. Could use cleanup - "components/script/dom/bindings/codegen/*", "components/style/properties/mod.rs", "target/*", "ports/gonk/src/native_window_glue.cpp", @@ -72,7 +73,13 @@ def should_check_reftest(file_name): return file_name.endswith(reftest_filetype) +EMACS_HEADER = "/* -*- Mode:" +VIM_HEADER = "/* vim:" + + def check_license(contents): + while contents.startswith(EMACS_HEADER) or contents.startswith(VIM_HEADER): + _, _, contents = contents.partition("\n") valid_license = any(contents.startswith(license) for license in licenses) acknowledged_bad_license = "xfail-license" in contents[:100] if not (valid_license or acknowledged_bad_license): |