diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-09-27 15:28:09 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-09-27 15:28:09 -0500 |
commit | 040075ad085f7e74f207241fedba144d710f42b7 (patch) | |
tree | a0eb4cb13d2e2ac84bd45dbf31cab784c01a6259 /python/tidy/servo_tidy_tests | |
parent | ec5ae8562d2c1f78a4fc65254b31759cf8b1b0cd (diff) | |
parent | ce249d9384a613a463781c673b8243658be69891 (diff) | |
download | servo-040075ad085f7e74f207241fedba144d710f42b7.tar.gz servo-040075ad085f7e74f207241fedba144d710f42b7.zip |
Auto merge of #13358 - rjgoldsborough:form-action-url-11219, r=mbrubeck
Form action url 11219
First pass at fixing #10580.
I've added a new macro that returns a DomString with either the attr val or the doc url.
I then made the form element use that macro on the action attribute.
I also added a test that contains an iframe with a form and base url that submits to a page in
a resources directory.
I made all these changes based on https://github.com/servo/servo/pull/11219#issuecomment-223318881.
The only thing I'm confused on is how to change step 8. It looks to just be getting the action so I'm wondering if I need to change either step 9 or 10 instead?
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #10580 (github issue number if applicable).
- [X] There are tests for these changes OR
using that macro with the form action,
making the form submit process use base url,
adding tests.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13358)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy_tests')
0 files changed, 0 insertions, 0 deletions