diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-10-14 16:14:40 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-10-14 16:14:40 -0400 |
commit | 5327758b9bd48d3dc5c453a15092546f9e53b8b9 (patch) | |
tree | 391f7bb5f36e8bb9636276ecd91a6eb528bb7d91 /python/tidy/servo_tidy_tests | |
parent | 4dcd1e71fa7e72e88ad74fdcc72d9ea8593b389b (diff) | |
parent | 74e44078d7a9eff26db69f97da6582c968eb75b5 (diff) | |
download | servo-5327758b9bd48d3dc5c453a15092546f9e53b8b9.tar.gz servo-5327758b9bd48d3dc5c453a15092546f9e53b8b9.zip |
Auto merge of #21944 - codehag:devtools-add-thread-interrupt, r=jdm
DevTools - add Interrupt method to ThreadActor
This is one of three pull requests that allows the DevTools Debugger to render.
The two related prs are #21942 and #21943
In this pr, I introduced the `interrupt` method to the threadActor. This is arguably a carry-over from the firefox devtools, where the debugger server is running in the same event loop as the content scripts, and it can only update itself when the debugger server is paused. Depending on how debugging is, or how debugging will be implemented on servo, this method may need to be adjusted for "debugger events" and "script events".
After all three patches on this topic are merged, you should be able to see the debugger \o/ (but no sources yet)
<img width="900" alt="screen shot 2018-10-14 at 16 57 07" src="https://user-images.githubusercontent.com/26968615/46918408-35f30180-cfd2-11e8-9a98-8e1540adc894.png">
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21944)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy_tests')
0 files changed, 0 insertions, 0 deletions