diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-11-01 01:13:35 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-11-01 01:13:35 -0500 |
commit | 291f393723d22a582bb9a49ef7294ec14eca2127 (patch) | |
tree | 6bff5ca222554e11f70f48674f561593202e219f /python/tidy/servo_tidy_tests/test_tidy.py | |
parent | c69c6cf58bb31de36af98d4b84dfdec2724d5b5b (diff) | |
parent | 32ba45ab6fe350c70aaad0ed29b66995571186c7 (diff) | |
download | servo-291f393723d22a582bb9a49ef7294ec14eca2127.tar.gz servo-291f393723d22a582bb9a49ef7294ec14eca2127.zip |
Auto merge of #13986 - iamrohit7:tidy-feature-attrs, r=Wafflespeanut
Make test-tidy check for alphabetical ordering of #![feature(...)] statements
<!-- Please describe your changes on the following line: -->
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #13954 (github issue number if applicable).
<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13986)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy_tests/test_tidy.py')
-rw-r--r-- | python/tidy/servo_tidy_tests/test_tidy.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/python/tidy/servo_tidy_tests/test_tidy.py b/python/tidy/servo_tidy_tests/test_tidy.py index 7bec2c61718..d997bb00f82 100644 --- a/python/tidy/servo_tidy_tests/test_tidy.py +++ b/python/tidy/servo_tidy_tests/test_tidy.py @@ -127,6 +127,14 @@ class CheckTidiness(unittest.TestCase): self.assertEqual('extra space after test_fun', errors.next()[2]) self.assertNoMoreErrors(errors) + feature_errors = tidy.collect_errors_for_files(iterFile('lib.rs'), [], [tidy.check_rust], print_text=False) + + self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2]) + self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2]) + self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2]) + self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2]) + self.assertNoMoreErrors(feature_errors) + def test_spec_link(self): tidy.SPEC_BASE_PATH = base_path errors = tidy.collect_errors_for_files(iterFile('speclink.rs'), [], [tidy.check_spec], print_text=False) |