diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-12-10 23:06:03 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-12-10 23:06:03 -0500 |
commit | ded86439880f733c0165417ecfb44c706c1e7fc0 (patch) | |
tree | 35083ab83e9ca6990efa5c2ee72fe9cdeabe5b22 /python/tidy/servo_tidy_tests/empty_file.rs | |
parent | e900c22105bed088cbd89113caf82cb3a6e20a3d (diff) | |
parent | ed88a67cca98acf585510f7a14f453b2964617cb (diff) | |
download | servo-ded86439880f733c0165417ecfb44c706c1e7fc0.tar.gz servo-ded86439880f733c0165417ecfb44c706c1e7fc0.zip |
Auto merge of #25227 - gterzian:remove_unnecessary_thread_in_filereader, r=jdm
Remove unnecessary thread in filereader, add stream TODO
<!-- Please describe your changes on the following line: -->
I think there are no benefits to queuing the various `FileReadingTask` from a thread, and reading the actual blob bytes are still done on the main-thread. We could try to move the reading off the main-thread(but note the `Blob` is not something you would want to move to another thread "as-is" since it's a `DomObject`), and I think we should just aim for implementing streams and follow the spec instead.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'python/tidy/servo_tidy_tests/empty_file.rs')
0 files changed, 0 insertions, 0 deletions