diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-05-23 15:40:30 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-05-23 15:40:30 -0400 |
commit | 0cad37718da6d1665cc3e89e0924ad430952e566 (patch) | |
tree | cb8b1a1871791caa9974f6d18ee45b2d040ae290 /python/tidy/servo_tidy/licenseck.py | |
parent | 521748c01e0a932ecb7d6801732e2a5cc516903e (diff) | |
parent | 20266fa103f277531d8fc6fb92c52527f5c716f8 (diff) | |
download | servo-0cad37718da6d1665cc3e89e0924ad430952e566.tar.gz servo-0cad37718da6d1665cc3e89e0924ad430952e566.zip |
Auto merge of #20840 - fabricedesre:save-localstorage, r=Manishearth
Save local storage at every change and not just on shutdown
<!-- Please describe your changes on the following line: -->
Currently local storage is saved to `local_data.json` only at shutdown when the storage thread receives the `StorageThreadMsg::Exit` message. This is not reliable enough in any case, and especially problematic for a young engine like Servo. Data loss ensues...
I kept the exit message in the storage thread even if we are not doing work anymore. I can remove it if needed but it should be useful once we move to a better storage backend than a json file.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because we don't have tests for that persistence layer.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20840)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy/servo_tidy/licenseck.py')
0 files changed, 0 insertions, 0 deletions