diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-04-01 03:30:57 +0530 |
|---|---|---|
| committer | bors-servo <lbergstrom+bors@mozilla.com> | 2016-04-01 03:30:57 +0530 |
| commit | 7518c4de9317af3a643fc35131e556104b8693fa (patch) | |
| tree | c46e2c7af67d406f6582c22549c63b29a4125611 /python/tidy.py | |
| parent | 524a004e771b465e3de9ebbc33816e50949d6a25 (diff) | |
| parent | df82a5b24f8ff13be158387838dc7d9202d9ad02 (diff) | |
| download | servo-7518c4de9317af3a643fc35131e556104b8693fa.tar.gz servo-7518c4de9317af3a643fc35131e556104b8693fa.zip | |
Auto merge of #10082 - asajeffrey:remove-constellation-panic, r=glennw
Removed panicking when frame or pipeline lookup fails.
Removed the methods `pipeline(id)`, `pipeline_mut(id)`, `frame(id)` and `frame_mut(id)` from constellation, which panicked when the table lookup failed.
The panics were causing race conditions, e.g. visiting google.com and resizing the page would cause a panic, most likely due to an iframe being added and removed, with the `DOMLoad` event arriving after the iframe had been removed, causing a panic.
This patch fixes #10017 and #8769 (although in non-webrender builds there's now a different panic, see https://github.com/servo/servo/issues/10017#issuecomment-198160200).
There are a few `TODO` items in the initial commit, for cases where it's not completely obvious what to do in the case of failure.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10082)
<!-- Reviewable:end -->
Diffstat (limited to 'python/tidy.py')
0 files changed, 0 insertions, 0 deletions