aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo
diff options
context:
space:
mode:
authorDelan Azabani <dazabani@igalia.com>2025-04-01 17:00:40 +0800
committerGitHub <noreply@github.com>2025-04-01 09:00:40 +0000
commit30b712aaf970bae8acb32b67a2591429625ad75b (patch)
treeb40004b0d2d83ff1ea18afe99810550deb964d07 /python/servo
parentfcef1dff9d31e8b2bc28417150c117a268dd450a (diff)
downloadservo-30b712aaf970bae8acb32b67a2591429625ad75b.tar.gz
servo-30b712aaf970bae8acb32b67a2591429625ad75b.zip
devtools: Fix id collisions by using incrementing counters (#35971)
Devtools clients need a `browserId`, `browsingContextID`, and `outerWindowID`, which correspond to WebViewId, BrowsingContextId, and PipelineId in Servo. These u32 values were previously derived from our sharded (u32,u32) id values by taking only the `index` (second u32) and ignoring the `namespace_id` (first u32), leading to collisions. This patch fixes that by mapping those Servo ids to sequential u32 values. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #35954 <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> --------- Signed-off-by: Delan Azabani <dazabani@igalia.com>
Diffstat (limited to 'python/servo')
-rw-r--r--python/servo/testing_commands.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py
index 2094147df83..b19b4920336 100644
--- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -163,6 +163,7 @@ class MachCommands(CommandBase):
"background_hang_monitor",
"base",
"constellation",
+ "devtools",
"fonts",
"hyper_serde",
"layout_2020",