diff options
| author | Mukilan Thiyagarajan <me@mukilan.in> | 2023-05-21 11:33:22 +0530 |
|---|---|---|
| committer | Mukilan Thiyagarajan <me@mukilan.in> | 2023-05-21 16:13:36 +0530 |
| commit | df71aa2f1ef738c8970cdaae63ec15363163137c (patch) | |
| tree | ab87d9c831dd7a0266316afe6f62056f4750df16 /python/servo | |
| parent | 1bb713521bc2f92526429622fa2da13d10f65200 (diff) | |
| download | servo-df71aa2f1ef738c8970cdaae63ec15363163137c.tar.gz servo-df71aa2f1ef738c8970cdaae63ec15363163137c.zip | |
Avoid relinking plugin dylibs
The `copy_dependencies` logic is invoking
`change_non_system_libraries_path` with absolute paths
to gstreamer *plugin dylibs*.
`change_non_system_libraries_path` skips editing links
in servo binary to relocatable dylibs, but the since the
plugins have absolute paths, they are treated as
'non-relocable' and it will try to edit the *non-existent*
(since plugins are loaded dynamically) link in servo bin.
These unnecessary calls to change_link_name is cause
of the slowness identified in #29764
This PR fixes the issue by ensuring plugins are not
included in the call to change_non_system_libraries_path
Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
Diffstat (limited to 'python/servo')
| -rw-r--r-- | python/servo/build_commands.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index 1f69637ad85..ed018029349 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -858,8 +858,8 @@ def copy_dependencies(binary_path, lib_path, gst_root): # Update binary libraries binary_dependencies = set(otool(binary_path)) - binary_dependencies = binary_dependencies.union(macos_plugins()) change_non_system_libraries_path(binary_dependencies, relative_path, binary_path) + binary_dependencies = binary_dependencies.union(macos_plugins()) # Update dependencies libraries need_checked = binary_dependencies |