diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2024-09-11 06:40:11 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-11 13:40:11 +0000 |
| commit | 027fc53e2fa6b5d15f0e73e6685266b77e993a35 (patch) | |
| tree | 3dea68e2730646942f4b02e12f3b8600d4abbea6 /python/servo/util.py | |
| parent | bc8d8b62c3017dbdb413a636b80bc3a2df0172d6 (diff) | |
| download | servo-027fc53e2fa6b5d15f0e73e6685266b77e993a35.tar.gz servo-027fc53e2fa6b5d15f0e73e6685266b77e993a35.zip | |
layout: Right-to-left support for other layout modes (#33375)
This change removes the `effective_writing_mode` concept and tries to
properly implement right-to-left layout support for all non-inline
writing modes. In general, what needs to happen is that rectangles
need to be converted to physical rectangles using the containing block.
A right-to-left rectangle's inline start is on the right physical side
of the containing block. Likewise a positive inline offset in
right-to-left text is a negative physical one.
The implementation here is pretty good for most layout modes, but floats
are still a bit in process. Currently, floats are processed in the
logical layout of the block container, but there still might be issues
with float interaction with mixed RTL and LTR.
While this does move us closer to supporting vertical writing modes,
this is still unsupported.
New failures:
- Vertical writing mode not supported:
- `/css/CSS2/floats/floats-placement-vertical-001b.xht`
- `/css/CSS2/floats/floats-placement-vertical-001c.xht`
- Absolutes inlines should avoid floats (#33323)
- `/css/css-position/position-absolute-dynamic-static-position-floats-004.html`
- No support for grid
- `/css/css-align/self-alignment/self-align-safe-unsafe-grid-003.html`
- `/css/css-position/static-position/inline-level-absolute-in-block-level-context-009.html`
- `/css/css-position/static-position/inline-level-absolute-in-block-level-context-010.html`
- Cannot reproduce these locally on any platform. Very mysterious:
- `/css/css-tables/row-group-margin-border-padding.html`
- `/css/css-tables/row-margin-border-padding.html`
- Exposes bugs we have related to hanging whitespace in preserved
whitespace inlines:
- `/css/css-text/white-space/trailing-space-and-text-alignment-rtl-003.html`
- `/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-023.html`
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com>
Diffstat (limited to 'python/servo/util.py')
0 files changed, 0 insertions, 0 deletions